* [PATCH] python3: Add recommended modules to nativesdk install @ 2018-04-04 19:25 Tom Hochstein 2018-04-05 13:55 ` Richard Purdie 0 siblings, 1 reply; 5+ messages in thread From: Tom Hochstein @ 2018-04-04 19:25 UTC (permalink / raw) To: openembedded-core The python3 installation in the SDK did not include the minimum set of modules. Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com> --- meta/recipes-devtools/python/python3_3.5.5.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-devtools/python/python3_3.5.5.bb b/meta/recipes-devtools/python/python3_3.5.5.bb index d458d32..f893b84 100644 --- a/meta/recipes-devtools/python/python3_3.5.5.bb +++ b/meta/recipes-devtools/python/python3_3.5.5.bb @@ -211,6 +211,7 @@ py_package_preprocess () { # manual dependency additions RPROVIDES_${PN}-modules = "${PN}" +RRECOMMENDS_${PN}-core_append_class-nativesdk = " nativesdk-python3-modules" RRECOMMENDS_${PN}-crypt = "openssl" RRECOMMENDS_${PN}-crypt_class-nativesdk = "nativesdk-openssl" -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] python3: Add recommended modules to nativesdk install 2018-04-04 19:25 [PATCH] python3: Add recommended modules to nativesdk install Tom Hochstein @ 2018-04-05 13:55 ` Richard Purdie 2018-04-07 15:37 ` Tom Hochstein 0 siblings, 1 reply; 5+ messages in thread From: Richard Purdie @ 2018-04-05 13:55 UTC (permalink / raw) To: Tom Hochstein, openembedded-core On Wed, 2018-04-04 at 14:25 -0500, Tom Hochstein wrote: > The python3 installation in the SDK did not include the minimum set > of modules. > > Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com> > --- > meta/recipes-devtools/python/python3_3.5.5.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-devtools/python/python3_3.5.5.bb > b/meta/recipes-devtools/python/python3_3.5.5.bb > index d458d32..f893b84 100644 > --- a/meta/recipes-devtools/python/python3_3.5.5.bb > +++ b/meta/recipes-devtools/python/python3_3.5.5.bb > @@ -211,6 +211,7 @@ py_package_preprocess () { > > # manual dependency additions > RPROVIDES_${PN}-modules = "${PN}" > +RRECOMMENDS_${PN}-core_append_class-nativesdk = " nativesdk-python3- > modules" > RRECOMMENDS_${PN}-crypt = "openssl" > RRECOMMENDS_${PN}-crypt_class-nativesdk = "nativesdk-openssl" This doesn't look correct, if you want the SDK to contain all python modules, surely you'd just add nativesdk-python3-modules rather than forcing this everywhere? Cheers, Richard ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] python3: Add recommended modules to nativesdk install 2018-04-05 13:55 ` Richard Purdie @ 2018-04-07 15:37 ` Tom Hochstein 2018-04-09 13:54 ` Burton, Ross 0 siblings, 1 reply; 5+ messages in thread From: Tom Hochstein @ 2018-04-07 15:37 UTC (permalink / raw) To: Richard Purdie, openembedded-core@lists.openembedded.org A colleague pointed out that what we installed in the SDK for python 3 was not functional, and that a minimal set of modules was required. I'm not an expert, but I found a similar line in the python 2 recipe and thought it might be what was needed here. Tom -----Original Message----- From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org] Sent: Thursday, April 5, 2018 8:56 AM To: Tom Hochstein <tom.hochstein@nxp.com>; openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] python3: Add recommended modules to nativesdk install On Wed, 2018-04-04 at 14:25 -0500, Tom Hochstein wrote: > The python3 installation in the SDK did not include the minimum set of > modules. > > Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com> > --- > meta/recipes-devtools/python/python3_3.5.5.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-devtools/python/python3_3.5.5.bb > b/meta/recipes-devtools/python/python3_3.5.5.bb > index d458d32..f893b84 100644 > --- a/meta/recipes-devtools/python/python3_3.5.5.bb > +++ b/meta/recipes-devtools/python/python3_3.5.5.bb > @@ -211,6 +211,7 @@ py_package_preprocess () { > > # manual dependency additions > RPROVIDES_${PN}-modules = "${PN}" > +RRECOMMENDS_${PN}-core_append_class-nativesdk = " nativesdk-python3- > modules" > RRECOMMENDS_${PN}-crypt = "openssl" > RRECOMMENDS_${PN}-crypt_class-nativesdk = "nativesdk-openssl" This doesn't look correct, if you want the SDK to contain all python modules, surely you'd just add nativesdk-python3-modules rather than forcing this everywhere? Cheers, Richard ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] python3: Add recommended modules to nativesdk install 2018-04-07 15:37 ` Tom Hochstein @ 2018-04-09 13:54 ` Burton, Ross 2018-04-09 14:03 ` Burton, Ross 0 siblings, 1 reply; 5+ messages in thread From: Burton, Ross @ 2018-04-09 13:54 UTC (permalink / raw) To: Tom Hochstein; +Cc: openembedded-core@lists.openembedded.org That's definitely a hack. If SDKs should contain Python then install python3 (which will install -core and -modules), if not then don't install it. The corner-case is a SDK which though dependencies installs half a Python, in which case I'd say you should just explicitly add all of Python. Ross On 7 April 2018 at 16:37, Tom Hochstein <tom.hochstein@nxp.com> wrote: > A colleague pointed out that what we installed in the SDK for python 3 was not functional, and that a minimal set of modules was required. I'm not an expert, but I found a similar line in the python 2 recipe and thought it might be what was needed here. > > Tom > > -----Original Message----- > From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org] > Sent: Thursday, April 5, 2018 8:56 AM > To: Tom Hochstein <tom.hochstein@nxp.com>; openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH] python3: Add recommended modules to nativesdk install > > On Wed, 2018-04-04 at 14:25 -0500, Tom Hochstein wrote: >> The python3 installation in the SDK did not include the minimum set of >> modules. >> >> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com> >> --- >> meta/recipes-devtools/python/python3_3.5.5.bb | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/recipes-devtools/python/python3_3.5.5.bb >> b/meta/recipes-devtools/python/python3_3.5.5.bb >> index d458d32..f893b84 100644 >> --- a/meta/recipes-devtools/python/python3_3.5.5.bb >> +++ b/meta/recipes-devtools/python/python3_3.5.5.bb >> @@ -211,6 +211,7 @@ py_package_preprocess () { >> >> # manual dependency additions >> RPROVIDES_${PN}-modules = "${PN}" >> +RRECOMMENDS_${PN}-core_append_class-nativesdk = " nativesdk-python3- >> modules" >> RRECOMMENDS_${PN}-crypt = "openssl" >> RRECOMMENDS_${PN}-crypt_class-nativesdk = "nativesdk-openssl" > > This doesn't look correct, if you want the SDK to contain all python modules, surely you'd just add nativesdk-python3-modules rather than forcing this everywhere? > > Cheers, > > Richard > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] python3: Add recommended modules to nativesdk install 2018-04-09 13:54 ` Burton, Ross @ 2018-04-09 14:03 ` Burton, Ross 0 siblings, 0 replies; 5+ messages in thread From: Burton, Ross @ 2018-04-09 14:03 UTC (permalink / raw) To: Tom Hochstein; +Cc: openembedded-core@lists.openembedded.org Carried on thinking after sending this and I now think that in a SDK we probably want to enforce all-or-nothing and this is the easiest way. Can you expand the commit message so the rationale doesn't get lost? Ross On 9 April 2018 at 14:54, Burton, Ross <ross.burton@intel.com> wrote: > That's definitely a hack. If SDKs should contain Python then install > python3 (which will install -core and -modules), if not then don't > install it. The corner-case is a SDK which though dependencies > installs half a Python, in which case I'd say you should just > explicitly add all of Python. > > Ross > > > > On 7 April 2018 at 16:37, Tom Hochstein <tom.hochstein@nxp.com> wrote: >> A colleague pointed out that what we installed in the SDK for python 3 was not functional, and that a minimal set of modules was required. I'm not an expert, but I found a similar line in the python 2 recipe and thought it might be what was needed here. >> >> Tom >> >> -----Original Message----- >> From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org] >> Sent: Thursday, April 5, 2018 8:56 AM >> To: Tom Hochstein <tom.hochstein@nxp.com>; openembedded-core@lists.openembedded.org >> Subject: Re: [OE-core] [PATCH] python3: Add recommended modules to nativesdk install >> >> On Wed, 2018-04-04 at 14:25 -0500, Tom Hochstein wrote: >>> The python3 installation in the SDK did not include the minimum set of >>> modules. >>> >>> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com> >>> --- >>> meta/recipes-devtools/python/python3_3.5.5.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/meta/recipes-devtools/python/python3_3.5.5.bb >>> b/meta/recipes-devtools/python/python3_3.5.5.bb >>> index d458d32..f893b84 100644 >>> --- a/meta/recipes-devtools/python/python3_3.5.5.bb >>> +++ b/meta/recipes-devtools/python/python3_3.5.5.bb >>> @@ -211,6 +211,7 @@ py_package_preprocess () { >>> >>> # manual dependency additions >>> RPROVIDES_${PN}-modules = "${PN}" >>> +RRECOMMENDS_${PN}-core_append_class-nativesdk = " nativesdk-python3- >>> modules" >>> RRECOMMENDS_${PN}-crypt = "openssl" >>> RRECOMMENDS_${PN}-crypt_class-nativesdk = "nativesdk-openssl" >> >> This doesn't look correct, if you want the SDK to contain all python modules, surely you'd just add nativesdk-python3-modules rather than forcing this everywhere? >> >> Cheers, >> >> Richard >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-09 14:03 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-04-04 19:25 [PATCH] python3: Add recommended modules to nativesdk install Tom Hochstein 2018-04-05 13:55 ` Richard Purdie 2018-04-07 15:37 ` Tom Hochstein 2018-04-09 13:54 ` Burton, Ross 2018-04-09 14:03 ` Burton, Ross
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox