Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andre McCurdy <armccurdy@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 2/3] native.bbclass: drop _virtclass-native and _virtclass-nativesdk overrides
Date: Wed,  9 May 2018 20:14:56 -0700	[thread overview]
Message-ID: <1525922097-15292-2-git-send-email-armccurdy@gmail.com> (raw)
In-Reply-To: <1525922097-15292-1-git-send-email-armccurdy@gmail.com>

The _virtclass-XXX over-rides are problematic in that they are higher
priority than _forcevariable, which is documented as being the
highest priority over-ride.

Since they are now obsolete (replaced by _class-native and
_class-nativesdk) drop them entirely rather than try to fix their
priority.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/classes/native.bbclass    | 2 --
 meta/classes/nativesdk.bbclass | 1 -
 2 files changed, 3 deletions(-)

diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
index 7f2df17..ad7e98a 100644
--- a/meta/classes/native.bbclass
+++ b/meta/classes/native.bbclass
@@ -154,8 +154,6 @@ python native_virtclass_handler () {
                 newdeps.append(dep)
         d.setVar(varname, " ".join(newdeps))
 
-    e.data.setVar("OVERRIDES", e.data.getVar("OVERRIDES", False) + ":virtclass-native")
-
     map_dependencies("DEPENDS", e.data)
     for pkg in [e.data.getVar("PN"), "", "${PN}"]:
         map_dependencies("RDEPENDS", e.data, pkg)
diff --git a/meta/classes/nativesdk.bbclass b/meta/classes/nativesdk.bbclass
index 69fb45c8..ab566e9 100644
--- a/meta/classes/nativesdk.bbclass
+++ b/meta/classes/nativesdk.bbclass
@@ -78,7 +78,6 @@ python nativesdk_virtclass_handler () {
 
     e.data.setVar("MLPREFIX", "nativesdk-")
     e.data.setVar("PN", "nativesdk-" + e.data.getVar("PN").replace("-nativesdk", "").replace("nativesdk-", ""))
-    e.data.setVar("OVERRIDES", e.data.getVar("OVERRIDES", False) + ":virtclass-nativesdk")
 }
 
 python () {
-- 
1.9.1



  reply	other threads:[~2018-05-10  3:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10  3:14 [PATCH 1/3] bitbake.conf: make libc over-ride lower priority than _forcevariable Andre McCurdy
2018-05-10  3:14 ` Andre McCurdy [this message]
2018-05-10  3:14 ` [PATCH 3/3] bitbake.conf: drop _build-${BUILD_OS} over-ride Andre McCurdy
2018-05-10  5:44   ` Khem Raj
2018-05-10 15:47     ` Dan McGregor
2018-05-10 16:33       ` Burton, Ross
2018-05-10 17:09         ` Dan McGregor
2018-05-10 17:57           ` Christopher Larson
2018-05-10  5:41 ` [PATCH 1/3] bitbake.conf: make libc over-ride lower priority than _forcevariable Khem Raj
2018-05-10 22:33   ` Andre McCurdy
2018-05-10 22:40     ` Khem Raj
2018-05-11  0:53       ` Andre McCurdy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525922097-15292-2-git-send-email-armccurdy@gmail.com \
    --to=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox