Re: [PATCH 3/3] bitbake.conf: drop _build-${BUILD_OS} over-ride

[Khem Raj <raj.khem@gmail.com>]

On 5/9/18 8:14 PM, Andre McCurdy wrote:
> Building on a host OS other than a recent version of Linux is not
> recommended or supported. Drop the historical _build-${BUILD_OS}
> over-ride to avoid giving the impression that other host OS's might
> be supported.

if this is not causing issues, I would suggest to keep this in.

> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>   meta/classes/cross.bbclass  | 1 -
>   meta/classes/native.bbclass | 1 -
>   meta/conf/bitbake.conf      | 2 +-
>   3 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/meta/classes/cross.bbclass b/meta/classes/cross.bbclass
> index 4e85cab2..34d7951 100644
> --- a/meta/classes/cross.bbclass
> +++ b/meta/classes/cross.bbclass
> @@ -37,7 +37,6 @@ CPPFLAGS = "${BUILD_CPPFLAGS}"
>   CFLAGS = "${BUILD_CFLAGS}"
>   CXXFLAGS = "${BUILD_CFLAGS}"
>   LDFLAGS = "${BUILD_LDFLAGS}"
> -LDFLAGS_build-darwin = "-L${STAGING_LIBDIR_NATIVE}"
>   
>   TOOLCHAIN_OPTIONS = ""
>   
> diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
> index ad7e98a..ddccfe2e1 100644
> --- a/meta/classes/native.bbclass
> +++ b/meta/classes/native.bbclass
> @@ -44,7 +44,6 @@ CPPFLAGS = "${BUILD_CPPFLAGS}"
>   CFLAGS = "${BUILD_CFLAGS}"
>   CXXFLAGS = "${BUILD_CXXFLAGS}"
>   LDFLAGS = "${BUILD_LDFLAGS}"
> -LDFLAGS_build-darwin = "-L${STAGING_LIBDIR_NATIVE} "
>   
>   STAGING_BINDIR = "${STAGING_BINDIR_NATIVE}"
>   STAGING_BINDIR_CROSS = "${STAGING_BINDIR_NATIVE}"
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index a772cab..702f498 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -735,7 +735,7 @@ DISTRO_NAME ??= "OpenEmbedded"
>   #
>   # This works for  functions as well, they are really just environment variables.
>   # Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
> -OVERRIDES = "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}${LIBCOVERRIDE}:forcevariable"
> +OVERRIDES = "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}${LIBCOVERRIDE}:forcevariable"
>   LIBCOVERRIDE ?= ""
>   CLASSOVERRIDE ?= "class-target"
>   DISTROOVERRIDES ?= "${@d.getVar('DISTRO') or ''}"
>