openembedded-core.lists.openembedded.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] binutils : enable production of EFI binaries on x86-64
@ 2018-07-25  3:16 Christopher Clark
  2018-07-25  5:56 ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Clark @ 2018-07-25  3:16 UTC (permalink / raw)
  To: openembedded-core

From: Christopher Clark <christopher.clark6@baesystems.com>

When MACHINE_FEATURES includes "efi" and target is x86-64,
enable the linker to produce Portable Executables: EFI binaries.

Supplies "--enable-targets=x86_64-pep" in EXTRA_OECONF.

Enables building the EFI variant of the Xen hypervisor.

Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
---
 meta/recipes-devtools/binutils/binutils.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
index 37813dd..eedcc7e 100644
--- a/meta/recipes-devtools/binutils/binutils.inc
+++ b/meta/recipes-devtools/binutils/binutils.inc
@@ -69,12 +69,15 @@ python do_package_prepend() {
 
 B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
 
+ENABLE_EFI_BINARIES_x86-64 = "--enable-targets=x86_64-pep"
+
 EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
                 --disable-werror \
                 --enable-deterministic-archives \
                 --enable-plugins \
                 ${LDGOLD} \
-                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
+                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
+                ${@bb.utils.contains('MACHINE_FEATURES', 'efi', '${ENABLE_EFI_BINARIES}', '', d)}"
 
 LDGOLD_class-native = ""
 LDGOLD_class-crosssdk = ""
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] binutils : enable production of EFI binaries on x86-64
  2018-07-25  3:16 [PATCH] binutils : enable production of EFI binaries on x86-64 Christopher Clark
@ 2018-07-25  5:56 ` Khem Raj
  2018-07-25  9:55   ` Burton, Ross
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2018-07-25  5:56 UTC (permalink / raw)
  To: christopher.w.clark; +Cc: Patches and discussions about the oe-core layer

On Tue, Jul 24, 2018 at 8:16 PM Christopher Clark
<christopher.w.clark@gmail.com> wrote:
>
> From: Christopher Clark <christopher.clark6@baesystems.com>
>
> When MACHINE_FEATURES includes "efi" and target is x86-64,
> enable the linker to produce Portable Executables: EFI binaries.
>
> Supplies "--enable-targets=x86_64-pep" in EXTRA_OECONF.
>
> Enables building the EFI variant of the Xen hypervisor.
>
> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
> ---
>  meta/recipes-devtools/binutils/binutils.inc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
> index 37813dd..eedcc7e 100644
> --- a/meta/recipes-devtools/binutils/binutils.inc
> +++ b/meta/recipes-devtools/binutils/binutils.inc
> @@ -69,12 +69,15 @@ python do_package_prepend() {
>
>  B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
>
> +ENABLE_EFI_BINARIES_x86-64 = "--enable-targets=x86_64-pep"
> +



>  EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
>                  --disable-werror \
>                  --enable-deterministic-archives \
>                  --enable-plugins \
>                  ${LDGOLD} \
> -                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
> +                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
> +                ${@bb.utils.contains('MACHINE_FEATURES', 'efi', '${ENABLE_EFI_BINARIES}', '', d)}"

I think we should avoid using machine features rather enable this
emulation unconditionally for efi enabled
targets, which for now are arm/x86/x86_64/aarch64

>
>  LDGOLD_class-native = ""
>  LDGOLD_class-crosssdk = ""
> --
> 2.7.4
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] binutils : enable production of EFI binaries on x86-64
  2018-07-25  5:56 ` Khem Raj
@ 2018-07-25  9:55   ` Burton, Ross
  0 siblings, 0 replies; 3+ messages in thread
From: Burton, Ross @ 2018-07-25  9:55 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

Yes, please just enable it as widely as possible.

Ross

On 25 July 2018 at 06:56, Khem Raj <raj.khem@gmail.com> wrote:
> On Tue, Jul 24, 2018 at 8:16 PM Christopher Clark
> <christopher.w.clark@gmail.com> wrote:
>>
>> From: Christopher Clark <christopher.clark6@baesystems.com>
>>
>> When MACHINE_FEATURES includes "efi" and target is x86-64,
>> enable the linker to produce Portable Executables: EFI binaries.
>>
>> Supplies "--enable-targets=x86_64-pep" in EXTRA_OECONF.
>>
>> Enables building the EFI variant of the Xen hypervisor.
>>
>> Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
>> ---
>>  meta/recipes-devtools/binutils/binutils.inc | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
>> index 37813dd..eedcc7e 100644
>> --- a/meta/recipes-devtools/binutils/binutils.inc
>> +++ b/meta/recipes-devtools/binutils/binutils.inc
>> @@ -69,12 +69,15 @@ python do_package_prepend() {
>>
>>  B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
>>
>> +ENABLE_EFI_BINARIES_x86-64 = "--enable-targets=x86_64-pep"
>> +
>
>
>
>>  EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
>>                  --disable-werror \
>>                  --enable-deterministic-archives \
>>                  --enable-plugins \
>>                  ${LDGOLD} \
>> -                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
>> +                ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
>> +                ${@bb.utils.contains('MACHINE_FEATURES', 'efi', '${ENABLE_EFI_BINARIES}', '', d)}"
>
> I think we should avoid using machine features rather enable this
> emulation unconditionally for efi enabled
> targets, which for now are arm/x86/x86_64/aarch64
>
>>
>>  LDGOLD_class-native = ""
>>  LDGOLD_class-crosssdk = ""
>> --
>> 2.7.4
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-25  9:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-25  3:16 [PATCH] binutils : enable production of EFI binaries on x86-64 Christopher Clark
2018-07-25  5:56 ` Khem Raj
2018-07-25  9:55   ` Burton, Ross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).