[PATCH] python3: set PYTHONHOME for nativesdk

[PATCH] python3: set PYTHONHOME for nativesdk

[liu.ming50]

From: Cheuk Wing Leung <cwleung@kth.se>

commit c5629268b0f8ae0a425c98337d13e8dc83107e13:
[
    python: set PYTHONHOME for nativesdk

    This ensures that the nativesdk python functions correctly without needing to
    set PYTHONHOME in the sdk environment setup script.
]

it's also needed for python3.

Signed-off-by: Cheuk Wing Leung <cwleung@kth.se>
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 meta/recipes-devtools/python/python3_3.5.6.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
index e179658..c481aad 100644
--- a/meta/recipes-devtools/python/python3_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3_3.5.6.bb
@@ -179,7 +179,7 @@ do_install() {
 }
 
 do_install_append_class-nativesdk () {
-	create_wrapper ${D}${bindir}/python${PYTHON_MAJMIN} TERMINFO_DIRS='${sysconfdir}/terminfo:/etc/terminfo:/usr/share/terminfo:/usr/share/misc/terminfo:/lib/terminfo' PYTHONNOUSERSITE='1'
+	create_wrapper ${D}${bindir}/python${PYTHON_MAJMIN} PYTHONHOME='${prefix}' TERMINFO_DIRS='${sysconfdir}/terminfo:/etc/terminfo:/usr/share/terminfo:/usr/share/misc/terminfo:/lib/terminfo' PYTHONNOUSERSITE='1'
 }
 
 SSTATE_SCAN_FILES += "Makefile"
-- 
2.7.4

Re: [PATCH] python3: set PYTHONHOME for nativesdk

[Richard Purdie]

On Thu, 2018-10-11 at 16:15 +0200, liu.ming50@gmail.com wrote:
> From: Cheuk Wing Leung <cwleung@kth.se>
> 
> commit c5629268b0f8ae0a425c98337d13e8dc83107e13:
> [
>     python: set PYTHONHOME for nativesdk
> 
>     This ensures that the nativesdk python functions correctly
> without needing to
>     set PYTHONHOME in the sdk environment setup script.
> ]
> 
> it's also needed for python3.
> 
> Signed-off-by: Cheuk Wing Leung <cwleung@kth.se>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>  meta/recipes-devtools/python/python3_3.5.6.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I think its this which is causing breakage:


https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step3b


https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step2b


https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step1b

Cheers,

Richard

Re: [PATCH] python3: set PYTHONHOME for nativesdk

[Ming Liu]

[-- Attachment #1: Type: text/plain, Size: 2106 bytes --]

Hi, Richard:

> I think its this which is causing breakage:
>
>
https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step3b
>
>
https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step2b
>
>
https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step1b

Are you sure about this? This patch creates a nativesdk python3 wrapper
which supposes to run on SDK machine, it should not impact native sysroot
binaries, and I could not reproduce the error with the patch applied on my
local machine. (Ubuntu-16.04)

//Ming Liu


<liu.ming50@gmail.com> 於 2018年10月11日 週四 下午4:16寫道：

> From: Cheuk Wing Leung <cwleung@kth.se>
>
> commit c5629268b0f8ae0a425c98337d13e8dc83107e13:
> [
>     python: set PYTHONHOME for nativesdk
>
>     This ensures that the nativesdk python functions correctly without
> needing to
>     set PYTHONHOME in the sdk environment setup script.
> ]
>
> it's also needed for python3.
>
> Signed-off-by: Cheuk Wing Leung <cwleung@kth.se>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>  meta/recipes-devtools/python/python3_3.5.6.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
> b/meta/recipes-devtools/python/python3_3.5.6.bb
> index e179658..c481aad 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -179,7 +179,7 @@ do_install() {
>  }
>
>  do_install_append_class-nativesdk () {
> -       create_wrapper ${D}${bindir}/python${PYTHON_MAJMIN}
> TERMINFO_DIRS='${sysconfdir}/terminfo:/etc/terminfo:/usr/share/terminfo:/usr/share/misc/terminfo:/lib/terminfo'
> PYTHONNOUSERSITE='1'
> +       create_wrapper ${D}${bindir}/python${PYTHON_MAJMIN}
> PYTHONHOME='${prefix}'
> TERMINFO_DIRS='${sysconfdir}/terminfo:/etc/terminfo:/usr/share/terminfo:/usr/share/misc/terminfo:/lib/terminfo'
> PYTHONNOUSERSITE='1'
>  }
>
>  SSTATE_SCAN_FILES += "Makefile"
> --
> 2.7.4
>
>

[-- Attachment #2: Type: text/html, Size: 3530 bytes --]

Re: [PATCH] python3: set PYTHONHOME for nativesdk

[richard.purdie]

On Fri, 2018-10-12 at 13:37 +0200, Ming Liu wrote:
> Hi, Richard:
> 
> > I think its this which is causing breakage:
> >
> > 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step3b
> >
> > 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step2b
> >
> > 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/106/steps/7/logs/step1b
> 
> Are you sure about this? This patch creates a nativesdk python3
> wrapper which supposes to run on SDK machine, it should not impact
> native sysroot binaries, and I could not reproduce the error with the
> patch applied on my local machine. (Ubuntu-16.04)

Sorry for the false alarm, its actually the cmake patches sine after
dropping those, -next built cleanly. Cc'ing Pascal Bach...

Cheers,

Richard