* [PATCH 0/4] ppc/musl: Improve support
@ 2019-01-12 9:22 Serhey Popovych
2019-01-12 9:22 ` [PATCH 1/4] systemd: Correctly check ENABLE_GSHADOW with if/endif Serhey Popovych
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Serhey Popovych @ 2019-01-12 9:22 UTC (permalink / raw)
To: openembedded-core
This is followup set of improvements for recently merged musl on PowerPC
fixes. It fixes more issues discovered later after first series merged.
See individual commit message for details on each change presented.
Build tested following images with musl as libc:
core-image-sato-dev
core-image-full-cmdline
Boot tested using KVM-HV on IBM POWER8 and HVM-PR on old Power Mac G5.
Serhey Popovych (4):
systemd: Correctly check ENABLE_GSHADOW with if/endif
systemd: Use arch overrides instead of machine
mpfr: Disable float128 when building with musl as libc
valgrind: Mark powerpc64 with musl as incompatible
...user-util-properly-protect-use-of-gshadow.patch | 38 ++++++++++++++++++++++
...clude-gshadow-only-if-ENABLE_GSHADOW-is-1.patch | 29 -----------------
...se-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch | 28 ++++++++++++++++
meta/recipes-core/systemd/systemd_239.bb | 9 ++---
meta/recipes-devtools/valgrind/valgrind_3.14.0.bb | 3 ++
meta/recipes-support/mpfr/mpfr_4.0.1.bb | 2 ++
6 files changed, 76 insertions(+), 33 deletions(-)
create mode 100644 meta/recipes-core/systemd/systemd/0005-basic-user-util-properly-protect-use-of-gshadow.patch
delete mode 100644 meta/recipes-core/systemd/systemd/0005-include-gshadow-only-if-ENABLE_GSHADOW-is-1.patch
create mode 100644 meta/recipes-core/systemd/systemd/0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch
--
2.7.4
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/4] systemd: Correctly check ENABLE_GSHADOW with if/endif 2019-01-12 9:22 [PATCH 0/4] ppc/musl: Improve support Serhey Popovych @ 2019-01-12 9:22 ` Serhey Popovych 2019-01-12 9:22 ` [PATCH 2/4] systemd: Use arch overrides instead of machine Serhey Popovych ` (2 subsequent siblings) 3 siblings, 0 replies; 9+ messages in thread From: Serhey Popovych @ 2019-01-12 9:22 UTC (permalink / raw) To: openembedded-core Use commit 4f07ffa8f5ab ("Use #if instead of #ifdef for ENABLE_GSHADOW") from upstream to check ENABLE_GSHADOW correctly that is defined as 0 in case of musl. While there replace specific patch with one from upstream that does exactly the same commit 66a5b5ce9b99 ("basic/user-util: properly protect use of gshadow"). Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> --- ...user-util-properly-protect-use-of-gshadow.patch | 38 ++++++++++++++++++++++ ...clude-gshadow-only-if-ENABLE_GSHADOW-is-1.patch | 29 ----------------- ...se-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch | 28 ++++++++++++++++ meta/recipes-core/systemd/systemd_239.bb | 3 +- 4 files changed, 68 insertions(+), 30 deletions(-) create mode 100644 meta/recipes-core/systemd/systemd/0005-basic-user-util-properly-protect-use-of-gshadow.patch delete mode 100644 meta/recipes-core/systemd/systemd/0005-include-gshadow-only-if-ENABLE_GSHADOW-is-1.patch create mode 100644 meta/recipes-core/systemd/systemd/0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch diff --git a/meta/recipes-core/systemd/systemd/0005-basic-user-util-properly-protect-use-of-gshadow.patch b/meta/recipes-core/systemd/systemd/0005-basic-user-util-properly-protect-use-of-gshadow.patch new file mode 100644 index 0000000..518c05b --- /dev/null +++ b/meta/recipes-core/systemd/systemd/0005-basic-user-util-properly-protect-use-of-gshadow.patch @@ -0,0 +1,38 @@ +From 66a5b5ce9b991327d594f7b635de16999ca54093 Mon Sep 17 00:00:00 2001 +From: "Yann E. MORIN" <yann.morin.1998@free.fr> +Date: Wed, 21 Nov 2018 18:09:04 +0100 +Subject: basic/user-util: properly protect use of gshadow + +Commit 100d5f6ee6 (user-util: add new wrappers for [...] database +files), ammended by commit 4f07ffa8f5 (Use #if instead of #ifdef for +ENABLE_GSHADOW) moved code from sysuser to basic/user-util. + +In doing so, the combination of both commits properly propagated the +ENABLE_GSHADOW conditions around the function manipulating gshadow, but +they forgot to protect the inclusion of the gshadow.h header. + +Fix that to be able to build on C libraries that do not provide gshadow +(e.g. uClibc-ng, where it does not exist.) + +Upstream-Status: Backport [https://github.com/systemd/systemd/commit/66a5b5ce9b991327d594f7b635de16999ca54093] +--- + src/basic/user-util.h | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/src/basic/user-util.h b/src/basic/user-util.h +index b6de0e423..cc899ee76 100644 +--- a/src/basic/user-util.h ++++ b/src/basic/user-util.h +@@ -2,7 +2,9 @@ + #pragma once + + #include <grp.h> ++#if ENABLE_GSHADOW + #include <gshadow.h> ++#endif + #include <pwd.h> + #include <shadow.h> + #include <stdbool.h> +-- +2.18.1 + diff --git a/meta/recipes-core/systemd/systemd/0005-include-gshadow-only-if-ENABLE_GSHADOW-is-1.patch b/meta/recipes-core/systemd/systemd/0005-include-gshadow-only-if-ENABLE_GSHADOW-is-1.patch deleted file mode 100644 index 6d5faf5..0000000 --- a/meta/recipes-core/systemd/systemd/0005-include-gshadow-only-if-ENABLE_GSHADOW-is-1.patch +++ /dev/null @@ -1,29 +0,0 @@ -From a2c4d46944892174930135672508389a04e191f0 Mon Sep 17 00:00:00 2001 -From: Chen Qi <Qi.Chen@windriver.com> -Date: Fri, 29 Jun 2018 13:53:29 +0800 -Subject: [PATCH 05/19] include gshadow only if ENABLE_GSHADOW is 1 - -Upstream-Status: Inappropriate [musl] - -Signed-off-by: Chen Qi <Qi.Chen@windriver.com> ---- - src/basic/user-util.h | 2 ++ - 1 file changed, 2 insertions(+) - -diff --git a/src/basic/user-util.h b/src/basic/user-util.h -index b74f16885..f9c1e29c4 100644 ---- a/src/basic/user-util.h -+++ b/src/basic/user-util.h -@@ -2,7 +2,9 @@ - #pragma once - - #include <grp.h> -+#if ENABLE_GSHADOW - #include <gshadow.h> -+#endif - #include <pwd.h> - #include <shadow.h> - #include <stdbool.h> --- -2.11.0 - diff --git a/meta/recipes-core/systemd/systemd/0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch b/meta/recipes-core/systemd/systemd/0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch new file mode 100644 index 0000000..a9c1c9c --- /dev/null +++ b/meta/recipes-core/systemd/systemd/0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch @@ -0,0 +1,28 @@ +From 4f07ffa8f5ab85011422bb7114f1cddf49d4923d Mon Sep 17 00:00:00 2001 +From: ChenQi1989 <40684930+ChenQi1989@users.noreply.github.com> +Date: Fri, 29 Jun 2018 06:54:07 +0000 +Subject: Use #if instead of #ifdef for ENABLE_GSHADOW + +ENABLE_GSHADOW is defined to be 0 or 1. So #if should be used instead of #ifdef. + +Upstream-Status: Backport [https://github.com/systemd/systemd/commit/4f07ffa8f5ab85011422bb7114f1cddf49d4923d] +--- + src/basic/user-util.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/basic/user-util.h b/src/basic/user-util.h +index b74f16885..b2f198c89 100644 +--- a/src/basic/user-util.h ++++ b/src/basic/user-util.h +@@ -102,7 +102,7 @@ int fgetgrent_sane(FILE *stream, struct group **gr); + int putpwent_sane(const struct passwd *pw, FILE *stream); + int putspent_sane(const struct spwd *sp, FILE *stream); + int putgrent_sane(const struct group *gr, FILE *stream); +-#ifdef ENABLE_GSHADOW ++#if ENABLE_GSHADOW + int fgetsgent_sane(FILE *stream, struct sgrp **sg); + int putsgent_sane(const struct sgrp *sg, FILE *stream); + #endif +-- +2.18.1 + diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-core/systemd/systemd_239.bb index be836ff..0f1fa27 100644 --- a/meta/recipes-core/systemd/systemd_239.bb +++ b/meta/recipes-core/systemd/systemd_239.bb @@ -46,7 +46,7 @@ SRC_URI_MUSL = "file://0001-Use-getenv-when-secure-versions-are-not-available.pa file://0002-don-t-use-glibc-specific-qsort_r.patch \ file://0003-comparison_fn_t-is-glibc-specific-use-raw-signature-.patch \ file://0004-add-fallback-parse_printf_format-implementation.patch \ - file://0005-include-gshadow-only-if-ENABLE_GSHADOW-is-1.patch \ + file://0005-basic-user-util-properly-protect-use-of-gshadow.patch \ file://0006-src-basic-missing.h-check-for-missing-strndupa.patch \ file://0007-Include-netinet-if_ether.h.patch \ file://0008-don-t-fail-if-GLOB_BRACE-and-GLOB_ALTDIRFUNC-is-not-.patch \ @@ -63,6 +63,7 @@ SRC_URI_MUSL = "file://0001-Use-getenv-when-secure-versions-are-not-available.pa file://0019-Do-not-disable-buffering-when-writing-to-oom_score_a.patch \ file://0020-distinguish-XSI-compliant-strerror_r-from-GNU-specif.patch \ file://0021-Hide-__start_BUS_ERROR_MAP-and-__stop_BUS_ERROR_MAP.patch \ + file://0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch \ " # Workaround undefined reference to `__stack_chk_fail_local' on qemux86 and qemuppc for musl -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] systemd: Use arch overrides instead of machine 2019-01-12 9:22 [PATCH 0/4] ppc/musl: Improve support Serhey Popovych 2019-01-12 9:22 ` [PATCH 1/4] systemd: Correctly check ENABLE_GSHADOW with if/endif Serhey Popovych @ 2019-01-12 9:22 ` Serhey Popovych 2019-01-12 15:35 ` Khem Raj 2019-01-12 9:22 ` [PATCH 3/4] mpfr: Disable float128 when building with musl as libc Serhey Popovych 2019-01-12 9:22 ` [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible Serhey Popovych 3 siblings, 1 reply; 9+ messages in thread From: Serhey Popovych @ 2019-01-12 9:22 UTC (permalink / raw) To: openembedded-core With custom BSP and build with musl we still affected by undefined reference to stack-protector specific functions. Use arch overrides instead of machine to ensure fix applied to entire architecture instead of custom machine like qemux86 and qemuppc. Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> --- meta/recipes-core/systemd/systemd_239.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-core/systemd/systemd_239.bb index 0f1fa27..2e11d71 100644 --- a/meta/recipes-core/systemd/systemd_239.bb +++ b/meta/recipes-core/systemd/systemd_239.bb @@ -66,9 +66,9 @@ SRC_URI_MUSL = "file://0001-Use-getenv-when-secure-versions-are-not-available.pa file://0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch \ " -# Workaround undefined reference to `__stack_chk_fail_local' on qemux86 and qemuppc for musl -SRC_URI_append_libc-musl_qemux86 = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" -SRC_URI_append_libc-musl_qemuppc = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" +# Workaround undefined reference to `__stack_chk_fail_local' on x86 and powerpc for musl +SRC_URI_append_libc-musl_x86 = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" +SRC_URI_append_libc-musl_powerpc = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" PAM_PLUGINS = " \ pam-plugin-unix \ -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/4] systemd: Use arch overrides instead of machine 2019-01-12 9:22 ` [PATCH 2/4] systemd: Use arch overrides instead of machine Serhey Popovych @ 2019-01-12 15:35 ` Khem Raj 0 siblings, 0 replies; 9+ messages in thread From: Khem Raj @ 2019-01-12 15:35 UTC (permalink / raw) To: Serhey Popovych; +Cc: Patches and discussions about the oe-core layer On Sat, Jan 12, 2019 at 1:23 AM Serhey Popovych <serhe.popovych@gmail.com> wrote: > > With custom BSP and build with musl we still affected by undefined > reference to stack-protector specific functions. > > Use arch overrides instead of machine to ensure fix applied to entire > architecture instead of custom machine like qemux86 and qemuppc. > > Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> > --- > meta/recipes-core/systemd/systemd_239.bb | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-core/systemd/systemd_239.bb > index 0f1fa27..2e11d71 100644 > --- a/meta/recipes-core/systemd/systemd_239.bb > +++ b/meta/recipes-core/systemd/systemd_239.bb > @@ -66,9 +66,9 @@ SRC_URI_MUSL = "file://0001-Use-getenv-when-secure-versions-are-not-available.pa > file://0022-Use-if-instead-of-ifdef-for-ENABLE_GSHADOW.patch \ > " > > -# Workaround undefined reference to `__stack_chk_fail_local' on qemux86 and qemuppc for musl > -SRC_URI_append_libc-musl_qemux86 = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" > -SRC_URI_append_libc-musl_qemuppc = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" > +# Workaround undefined reference to `__stack_chk_fail_local' on x86 and powerpc for musl > +SRC_URI_append_libc-musl_x86 = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" > +SRC_URI_append_libc-musl_powerpc = " file://0001-Remove-fstack-protector-flags-to-workaround-musl-bui.patch" this seems wrong to me. While you are here, can we try to link with -lssp-nonshared instead ? > > PAM_PLUGINS = " \ > pam-plugin-unix \ > -- > 2.7.4 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] mpfr: Disable float128 when building with musl as libc 2019-01-12 9:22 [PATCH 0/4] ppc/musl: Improve support Serhey Popovych 2019-01-12 9:22 ` [PATCH 1/4] systemd: Correctly check ENABLE_GSHADOW with if/endif Serhey Popovych 2019-01-12 9:22 ` [PATCH 2/4] systemd: Use arch overrides instead of machine Serhey Popovych @ 2019-01-12 9:22 ` Serhey Popovych 2019-01-12 9:22 ` [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible Serhey Popovych 3 siblings, 0 replies; 9+ messages in thread From: Serhey Popovych @ 2019-01-12 9:22 UTC (permalink / raw) To: openembedded-core Since it does not support float128 type. Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> --- meta/recipes-support/mpfr/mpfr_4.0.1.bb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-support/mpfr/mpfr_4.0.1.bb b/meta/recipes-support/mpfr/mpfr_4.0.1.bb index 2eee76a..ccf7fdc 100644 --- a/meta/recipes-support/mpfr/mpfr_4.0.1.bb +++ b/meta/recipes-support/mpfr/mpfr_4.0.1.bb @@ -16,4 +16,6 @@ SRC_URI[sha256sum] = "67874a60826303ee2fb6affc6dc0ddd3e749e9bfcb4c8655e3953d0458 UPSTREAM_CHECK_URI = "http://www.mpfr.org/mpfr-current/" +EXTRA_OECONF_append_libc-musl = " --disable-float128" + BBCLASSEXTEND = "native nativesdk" -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible 2019-01-12 9:22 [PATCH 0/4] ppc/musl: Improve support Serhey Popovych ` (2 preceding siblings ...) 2019-01-12 9:22 ` [PATCH 3/4] mpfr: Disable float128 when building with musl as libc Serhey Popovych @ 2019-01-12 9:22 ` Serhey Popovych 2019-01-12 15:29 ` Khem Raj 3 siblings, 1 reply; 9+ messages in thread From: Serhey Popovych @ 2019-01-12 9:22 UTC (permalink / raw) To: openembedded-core Building musl for powerpc64 enforces elfv2 ABI since commit 68c964185519 ("arch-powerpc64.inc: Use elfv2 ABI when building with musl") that is not compatible with valgrind. Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> --- meta/recipes-devtools/valgrind/valgrind_3.14.0.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb index 4d15a50..d882319 100644 --- a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb +++ b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb @@ -58,6 +58,9 @@ COMPATIBLE_HOST_linux-muslx32 = 'null' COMPATIBLE_HOST_mipsarchr6 = 'null' COMPATIBLE_HOST_linux-gnun32 = 'null' +# Disable for powerpc64 with musl +COMPATIBLE_HOST_libc-musl_powerpc64 = 'null' + inherit autotools ptest multilib_header EXTRA_OECONF = "--enable-tls --without-mpicc" -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible 2019-01-12 9:22 ` [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible Serhey Popovych @ 2019-01-12 15:29 ` Khem Raj 2019-01-12 16:53 ` Serhey Popovych 0 siblings, 1 reply; 9+ messages in thread From: Khem Raj @ 2019-01-12 15:29 UTC (permalink / raw) To: Serhey Popovych; +Cc: Patches and discussions about the oe-core layer On Sat, Jan 12, 2019 at 1:23 AM Serhey Popovych <serhe.popovych@gmail.com> wrote: > > Building musl for powerpc64 enforces elfv2 ABI since commit 68c964185519 > ("arch-powerpc64.inc: Use elfv2 ABI when building with musl") that is > not compatible with valgrind. > > Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> > --- > meta/recipes-devtools/valgrind/valgrind_3.14.0.bb | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb > index 4d15a50..d882319 100644 > --- a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb > +++ b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb > @@ -58,6 +58,9 @@ COMPATIBLE_HOST_linux-muslx32 = 'null' > COMPATIBLE_HOST_mipsarchr6 = 'null' > COMPATIBLE_HOST_linux-gnun32 = 'null' > > +# Disable for powerpc64 with musl > +COMPATIBLE_HOST_libc-musl_powerpc64 = 'null' lets do it for powerpc64el too > + > inherit autotools ptest multilib_header > > EXTRA_OECONF = "--enable-tls --without-mpicc" > -- > 2.7.4 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible 2019-01-12 15:29 ` Khem Raj @ 2019-01-12 16:53 ` Serhey Popovych 2019-01-12 18:30 ` Khem Raj 0 siblings, 1 reply; 9+ messages in thread From: Serhey Popovych @ 2019-01-12 16:53 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1.1: Type: text/plain, Size: 1530 bytes --] Khem Raj wrote: > On Sat, Jan 12, 2019 at 1:23 AM Serhey Popovych > <serhe.popovych@gmail.com> wrote: >> >> Building musl for powerpc64 enforces elfv2 ABI since commit 68c964185519 >> ("arch-powerpc64.inc: Use elfv2 ABI when building with musl") that is >> not compatible with valgrind. >> >> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> >> --- >> meta/recipes-devtools/valgrind/valgrind_3.14.0.bb | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb >> index 4d15a50..d882319 100644 >> --- a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb >> +++ b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb >> @@ -58,6 +58,9 @@ COMPATIBLE_HOST_linux-muslx32 = 'null' >> COMPATIBLE_HOST_mipsarchr6 = 'null' >> COMPATIBLE_HOST_linux-gnun32 = 'null' >> >> +# Disable for powerpc64 with musl >> +COMPATIBLE_HOST_libc-musl_powerpc64 = 'null' > > lets do it for powerpc64el too I guess powerpc64le is GNU standard target, not *el. Support for powerpc64le is missing in OE. Before it is added I'd prefer not to do this for powerpc64le. >> + >> inherit autotools ptest multilib_header >> >> EXTRA_OECONF = "--enable-tls --without-mpicc" >> -- >> 2.7.4 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 501 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible 2019-01-12 16:53 ` Serhey Popovych @ 2019-01-12 18:30 ` Khem Raj 0 siblings, 0 replies; 9+ messages in thread From: Khem Raj @ 2019-01-12 18:30 UTC (permalink / raw) To: Serhey Popovych; +Cc: Patches and discussions about the oe-core layer On Sat, Jan 12, 2019 at 8:53 AM Serhey Popovych <serhe.popovych@gmail.com> wrote: > > Khem Raj wrote: > > On Sat, Jan 12, 2019 at 1:23 AM Serhey Popovych > > <serhe.popovych@gmail.com> wrote: > >> > >> Building musl for powerpc64 enforces elfv2 ABI since commit 68c964185519 > >> ("arch-powerpc64.inc: Use elfv2 ABI when building with musl") that is > >> not compatible with valgrind. > >> > >> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com> > >> --- > >> meta/recipes-devtools/valgrind/valgrind_3.14.0.bb | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb > >> index 4d15a50..d882319 100644 > >> --- a/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb > >> +++ b/meta/recipes-devtools/valgrind/valgrind_3.14.0.bb > >> @@ -58,6 +58,9 @@ COMPATIBLE_HOST_linux-muslx32 = 'null' > >> COMPATIBLE_HOST_mipsarchr6 = 'null' > >> COMPATIBLE_HOST_linux-gnun32 = 'null' > >> > >> +# Disable for powerpc64 with musl > >> +COMPATIBLE_HOST_libc-musl_powerpc64 = 'null' > > > > lets do it for powerpc64el too > > I guess powerpc64le is GNU standard target, not *el. > > Support for powerpc64le is missing in OE. Before it is > added I'd prefer not to do this for powerpc64le. IIRC there were some posts for EL in past, but OK lets not do it here > > >> + > >> inherit autotools ptest multilib_header > >> > >> EXTRA_OECONF = "--enable-tls --without-mpicc" > >> -- > >> 2.7.4 > >> > >> -- > >> _______________________________________________ > >> Openembedded-core mailing list > >> Openembedded-core@lists.openembedded.org > >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-01-12 18:30 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-01-12 9:22 [PATCH 0/4] ppc/musl: Improve support Serhey Popovych 2019-01-12 9:22 ` [PATCH 1/4] systemd: Correctly check ENABLE_GSHADOW with if/endif Serhey Popovych 2019-01-12 9:22 ` [PATCH 2/4] systemd: Use arch overrides instead of machine Serhey Popovych 2019-01-12 15:35 ` Khem Raj 2019-01-12 9:22 ` [PATCH 3/4] mpfr: Disable float128 when building with musl as libc Serhey Popovych 2019-01-12 9:22 ` [PATCH 4/4] valgrind: Mark powerpc64 with musl as incompatible Serhey Popovych 2019-01-12 15:29 ` Khem Raj 2019-01-12 16:53 ` Serhey Popovych 2019-01-12 18:30 ` Khem Raj
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox