Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] timezone: refactor to simplify maint
@ 2019-02-03 21:13 Armin Kuster
  2019-02-04  9:04 ` Peter Kjellerstedt
  0 siblings, 1 reply; 3+ messages in thread
From: Armin Kuster @ 2019-02-03 21:13 UTC (permalink / raw)
  To: akuster808, openembedded-core

move tzcode and tzdata-native into new dir

Updates are now limited to the common include file.

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 .../timezone.inc}                                   | 21 +++++----------------
 meta/recipes-extended/timezone/tzcode-native.bb     | 17 +++++++++++++++++
 .../{tzdata/tzdata_2018i.bb => timezone/tzdata.bb}  | 12 +-----------
 3 files changed, 23 insertions(+), 27 deletions(-)
 rename meta/recipes-extended/{tzcode/tzcode-native_2018i.bb => timezone/timezone.inc} (63%)
 create mode 100644 meta/recipes-extended/timezone/tzcode-native.bb
 rename meta/recipes-extended/{tzdata/tzdata_2018i.bb => timezone/tzdata.bb} (94%)

diff --git a/meta/recipes-extended/tzcode/tzcode-native_2018i.bb b/meta/recipes-extended/timezone/timezone.inc
similarity index 63%
rename from meta/recipes-extended/tzcode/tzcode-native_2018i.bb
rename to meta/recipes-extended/timezone/timezone.inc
index f056370..38dadac 100644
--- a/meta/recipes-extended/tzcode/tzcode-native_2018i.bb
+++ b/meta/recipes-extended/timezone/timezone.inc
@@ -1,10 +1,11 @@
-# note that we allow for us to use data later than our code version
-#
-SUMMARY = "tzcode, timezone zoneinfo utils -- zic, zdump, tzselect"
+UMMARY = "Timezone data"
+HOMEPAGE = "http://www.iana.org/time-zones"
+SECTION = "base"
 LICENSE = "PD & BSD & BSD-3-Clause"
-
 LIC_FILES_CHKSUM = "file://LICENSE;md5=c679c9d6b02bc2757b3eaf8f53c43fba"
 
+PV = "2018i"
+
 SRC_URI =" http://www.iana.org/time-zones/repository/releases/tzcode${PV}.tar.gz;name=tzcode \
            http://www.iana.org/time-zones/repository/releases/tzdata${PV}.tar.gz;name=tzdata \
            "
@@ -16,15 +17,3 @@ SRC_URI[tzcode.sha256sum] = "aaacdb876ca6fb9d58e244b462cbc7578a496b1b10994381b4b
 SRC_URI[tzdata.md5sum] = "b3f0a1a789480a036e58466cd0702477"
 SRC_URI[tzdata.sha256sum] = "82c45ef84ca3bc01d0a4a397ba8adeb8f7f199c6550740587c6ac5a7108c00d9"
 
-S = "${WORKDIR}"
-
-inherit native
-
-EXTRA_OEMAKE += "cc='${CC}'"
-
-do_install () {
-        install -d ${D}${bindir}/
-        install -m 755 zic ${D}${bindir}/
-        install -m 755 zdump ${D}${bindir}/
-        install -m 755 tzselect ${D}${bindir}/
-}
diff --git a/meta/recipes-extended/timezone/tzcode-native.bb b/meta/recipes-extended/timezone/tzcode-native.bb
new file mode 100644
index 0000000..e3582ba
--- /dev/null
+++ b/meta/recipes-extended/timezone/tzcode-native.bb
@@ -0,0 +1,17 @@
+require timezone.inc
+
+#
+SUMMARY = "tzcode, timezone zoneinfo utils -- zic, zdump, tzselect"
+
+S = "${WORKDIR}"
+
+inherit native
+
+EXTRA_OEMAKE += "cc='${CC}'"
+
+do_install () {
+        install -d ${D}${bindir}/
+        install -m 755 zic ${D}${bindir}/
+        install -m 755 zdump ${D}${bindir}/
+        install -m 755 tzselect ${D}${bindir}/
+}
diff --git a/meta/recipes-extended/tzdata/tzdata_2018i.bb b/meta/recipes-extended/timezone/tzdata.bb
similarity index 94%
rename from meta/recipes-extended/tzdata/tzdata_2018i.bb
rename to meta/recipes-extended/timezone/tzdata.bb
index 4482e89..7542ce5 100644
--- a/meta/recipes-extended/tzdata/tzdata_2018i.bb
+++ b/meta/recipes-extended/timezone/tzdata.bb
@@ -1,17 +1,7 @@
-SUMMARY = "Timezone data"
-HOMEPAGE = "http://www.iana.org/time-zones"
-SECTION = "base"
-LICENSE = "PD & BSD & BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=c679c9d6b02bc2757b3eaf8f53c43fba"
+require timezone.inc
 
 DEPENDS = "tzcode-native"
 
-SRC_URI = "http://www.iana.org/time-zones/repository/releases/tzdata${PV}.tar.gz;name=tzdata"
-UPSTREAM_CHECK_URI = "http://www.iana.org/time-zones"
-
-SRC_URI[tzdata.md5sum] = "b3f0a1a789480a036e58466cd0702477"
-SRC_URI[tzdata.sha256sum] = "82c45ef84ca3bc01d0a4a397ba8adeb8f7f199c6550740587c6ac5a7108c00d9"
-
 inherit allarch
 
 RCONFLICTS_${PN} = "timezones timezone-africa timezone-america timezone-antarctica \
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] timezone: refactor to simplify maint
  2019-02-03 21:13 [PATCH] timezone: refactor to simplify maint Armin Kuster
@ 2019-02-04  9:04 ` Peter Kjellerstedt
  2019-02-04 17:04   ` akuster808
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Kjellerstedt @ 2019-02-04  9:04 UTC (permalink / raw)
  To: Armin Kuster, openembedded-core@lists.openembedded.org

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-bounces@lists.openembedded.org> On Behalf Of Armin Kuster
> Sent: den 3 februari 2019 22:13
> To: akuster808@gmail.com; openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] timezone: refactor to simplify maint
> 
> move tzcode and tzdata-native into new dir
> 
> Updates are now limited to the common include file.
> 
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  .../timezone.inc}                                   | 21 +++++----------------
>  meta/recipes-extended/timezone/tzcode-native.bb     | 17 +++++++++++++++++
>  .../{tzdata/tzdata_2018i.bb => timezone/tzdata.bb}  | 12 +-----------
>  3 files changed, 23 insertions(+), 27 deletions(-)
>  rename meta/recipes-extended/{tzcode/tzcode-native_2018i.bb => timezone/timezone.inc} (63%)
>  create mode 100644 meta/recipes-extended/timezone/tzcode-native.bb
>  rename meta/recipes-extended/{tzdata/tzdata_2018i.bb => timezone/tzdata.bb} (94%)
> 
> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2018i.bb b/meta/recipes-extended/timezone/timezone.inc
> similarity index 63%
> rename from meta/recipes-extended/tzcode/tzcode-native_2018i.bb
> rename to meta/recipes-extended/timezone/timezone.inc
> index f056370..38dadac 100644
> --- a/meta/recipes-extended/tzcode/tzcode-native_2018i.bb
> +++ b/meta/recipes-extended/timezone/timezone.inc
> @@ -1,10 +1,11 @@
> -# note that we allow for us to use data later than our code version
> -#
> -SUMMARY = "tzcode, timezone zoneinfo utils -- zic, zdump, tzselect"
> +UMMARY = "Timezone data"

SUMMARY? ;)

> +HOMEPAGE = "http://www.iana.org/time-zones"
> +SECTION = "base"
>  LICENSE = "PD & BSD & BSD-3-Clause"
> -
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=c679c9d6b02bc2757b3eaf8f53c43fba"
> 
> +PV = "2018i"
> +
>  SRC_URI =" http://www.iana.org/time-zones/repository/releases/tzcode${PV}.tar.gz;name=tzcode \
>             http://www.iana.org/time-zones/repository/releases/tzdata${PV}.tar.gz;name=tzdata \
>             "
> @@ -16,15 +17,3 @@ SRC_URI[tzcode.sha256sum] = "aaacdb876ca6fb9d58e244b462cbc7578a496b1b10994381b4b
>  SRC_URI[tzdata.md5sum] = "b3f0a1a789480a036e58466cd0702477"
>  SRC_URI[tzdata.sha256sum] = "82c45ef84ca3bc01d0a4a397ba8adeb8f7f199c6550740587c6ac5a7108c00d9"
> 
> -S = "${WORKDIR}"
> -
> -inherit native
> -
> -EXTRA_OEMAKE += "cc='${CC}'"
> -
> -do_install () {
> -        install -d ${D}${bindir}/
> -        install -m 755 zic ${D}${bindir}/
> -        install -m 755 zdump ${D}${bindir}/
> -        install -m 755 tzselect ${D}${bindir}/
> -}

//Peter



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] timezone: refactor to simplify maint
  2019-02-04  9:04 ` Peter Kjellerstedt
@ 2019-02-04 17:04   ` akuster808
  0 siblings, 0 replies; 3+ messages in thread
From: akuster808 @ 2019-02-04 17:04 UTC (permalink / raw)
  To: Peter Kjellerstedt, openembedded-core@lists.openembedded.org



On 2/4/19 1:04 AM, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
>> core-bounces@lists.openembedded.org> On Behalf Of Armin Kuster
>> Sent: den 3 februari 2019 22:13
>> To: akuster808@gmail.com; openembedded-core@lists.openembedded.org
>> Subject: [OE-core] [PATCH] timezone: refactor to simplify maint
>>
>> move tzcode and tzdata-native into new dir
>>
>> Updates are now limited to the common include file.
>>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>  .../timezone.inc}                                   | 21 +++++----------------
>>  meta/recipes-extended/timezone/tzcode-native.bb     | 17 +++++++++++++++++
>>  .../{tzdata/tzdata_2018i.bb => timezone/tzdata.bb}  | 12 +-----------
>>  3 files changed, 23 insertions(+), 27 deletions(-)
>>  rename meta/recipes-extended/{tzcode/tzcode-native_2018i.bb => timezone/timezone.inc} (63%)
>>  create mode 100644 meta/recipes-extended/timezone/tzcode-native.bb
>>  rename meta/recipes-extended/{tzdata/tzdata_2018i.bb => timezone/tzdata.bb} (94%)
>>
>> diff --git a/meta/recipes-extended/tzcode/tzcode-native_2018i.bb b/meta/recipes-extended/timezone/timezone.inc
>> similarity index 63%
>> rename from meta/recipes-extended/tzcode/tzcode-native_2018i.bb
>> rename to meta/recipes-extended/timezone/timezone.inc
>> index f056370..38dadac 100644
>> --- a/meta/recipes-extended/tzcode/tzcode-native_2018i.bb
>> +++ b/meta/recipes-extended/timezone/timezone.inc
>> @@ -1,10 +1,11 @@
>> -# note that we allow for us to use data later than our code version
>> -#
>> -SUMMARY = "tzcode, timezone zoneinfo utils -- zic, zdump, tzselect"
>> +UMMARY = "Timezone data"
> SUMMARY? ;)
There was a letter tarif ; )

will send v2. thanks for the review.

- armin

>
>> +HOMEPAGE = "http://www.iana.org/time-zones"
>> +SECTION = "base"
>>  LICENSE = "PD & BSD & BSD-3-Clause"
>> -
>>  LIC_FILES_CHKSUM = "file://LICENSE;md5=c679c9d6b02bc2757b3eaf8f53c43fba"
>>
>> +PV = "2018i"
>> +
>>  SRC_URI =" http://www.iana.org/time-zones/repository/releases/tzcode${PV}.tar.gz;name=tzcode \
>>             http://www.iana.org/time-zones/repository/releases/tzdata${PV}.tar.gz;name=tzdata \
>>             "
>> @@ -16,15 +17,3 @@ SRC_URI[tzcode.sha256sum] = "aaacdb876ca6fb9d58e244b462cbc7578a496b1b10994381b4b
>>  SRC_URI[tzdata.md5sum] = "b3f0a1a789480a036e58466cd0702477"
>>  SRC_URI[tzdata.sha256sum] = "82c45ef84ca3bc01d0a4a397ba8adeb8f7f199c6550740587c6ac5a7108c00d9"
>>
>> -S = "${WORKDIR}"
>> -
>> -inherit native
>> -
>> -EXTRA_OEMAKE += "cc='${CC}'"
>> -
>> -do_install () {
>> -        install -d ${D}${bindir}/
>> -        install -m 755 zic ${D}${bindir}/
>> -        install -m 755 zdump ${D}${bindir}/
>> -        install -m 755 tzselect ${D}${bindir}/
>> -}
> //Peter
>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-04 17:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-03 21:13 [PATCH] timezone: refactor to simplify maint Armin Kuster
2019-02-04  9:04 ` Peter Kjellerstedt
2019-02-04 17:04   ` akuster808

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox