[PATCH] oeqa/runtime: add test for matchbox-terminal

[PATCH] oeqa/runtime: add test for matchbox-terminal

[jay.shen.teoh]

From: TeohJayShen <jay.shen.teoh@intel.com>

This test is checking that the terminal application is able to run. The click_terminal_icon_on_X_desktop manual test case from oeqa/manual/bsp-hw can be replace by this runtime test.

Signed-off-by: TeohJayShen <jay.shen.teoh@intel.com>
---
 meta/lib/oeqa/runtime/cases/terminal.py | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta/lib/oeqa/runtime/cases/terminal.py

diff --git a/meta/lib/oeqa/runtime/cases/terminal.py b/meta/lib/oeqa/runtime/cases/terminal.py
new file mode 100644
index 0000000..a268f26
--- /dev/null
+++ b/meta/lib/oeqa/runtime/cases/terminal.py
@@ -0,0 +1,18 @@
+from oeqa.runtime.case import OERuntimeTestCase
+from oeqa.core.decorator.depends import OETestDepends
+from oeqa.runtime.decorator.package import OEHasPackage
+
+import threading
+import time
+
+class TerminalTest(OERuntimeTestCase):
+
+    @OEHasPackage(['matchbox-terminal'])
+    @OETestDepends(['ssh.SSHTest.test_ssh'])
+    def test_terminal_running(self):
+        t_thread = threading.Thread(target=self.target.run, args=('export DISPLAY=:0 && matchbox-terminal',))
+        t_thread.start()
+        time.sleep(2)
+        status, output = self.target.run('pidof matchbox-terminal')
+        self.target.run('kill -9 %s' % output)
+        self.assertEqual(status, 0, msg='Not able to find process that runs terminal.')   
-- 
2.7.4

Re: [OE-core] [PATCH] oeqa/runtime: add test for matchbox-terminal

[Ross Burton]

On Mon, 14 Sep 2020 at 05:27, <jay.shen.teoh@intel.com> wrote:
> This test is checking that the terminal application is able to run. The click_terminal_icon_on_X_desktop manual test case from oeqa/manual/bsp-hw can be replace by this runtime test.

This does not test that the terminal actually started.  If it hung,
this test would pass.  The manual test case is "does the terminal
work", which this test does not replicate.

Ross

Re: [OE-core] [PATCH] oeqa/runtime: add test for matchbox-terminal

[Teoh, Jay Shen]

Hi Ross,

Thank you for the clarification. I will rework on the terminal.py test case.

Thanks,
Jay

-----Original Message-----
From: Ross Burton <ross@burtonini.com> 
Sent: Wednesday, 28 October, 2020 8:40 PM
To: Teoh, Jay Shen <jay.shen.teoh@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] oeqa/runtime: add test for matchbox-terminal

On Mon, 14 Sep 2020 at 05:27, <jay.shen.teoh@intel.com> wrote:
> This test is checking that the terminal application is able to run. The click_terminal_icon_on_X_desktop manual test case from oeqa/manual/bsp-hw can be replace by this runtime test.

This does not test that the terminal actually started.  If it hung, this test would pass.  The manual test case is "does the terminal work", which this test does not replicate.

Ross