Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] usbutils: avoid dependency on bash
Date: Thu, 26 Jul 2012 11:46:13 +0100	[thread overview]
Message-ID: <1753997.KifeUqhHux@helios> (raw)
In-Reply-To: <AC7B240E-2E23-4103-AE46-DF04C92CCFA9@dominion.thruhere.net>

On Thursday 26 July 2012 12:42:47 Koen Kooi wrote:
> Op 26 jul. 2012, om 12:38 heeft Paul Eggleton het volgende geschreven:
> > On Thursday 26 July 2012 12:24:44 Koen Kooi wrote:
> >> Op 26 jul. 2012, om 12:04 heeft Paul Eggleton het volgende geschreven:
> >>> By virtue of having #!/bin/bash, the usb-devices script declared that it
> >>> requires bash, however manual examinasion, checkbashisms and tests with
> >>> dash and busybox show that it doesn't contain any bashisms, so change
> >>> the script's header and remove the RDEPENDS on bash.
> >> 
> >> Is the update-usbids ash/dash safe as well nowadays?
> > 
> > Manual examination shows no bashisms, checkbashisms reports nothing, and
> > it
> > works fine with ash here.
> 
> Awesome! Thanks for checking!

Since I also made a spelling mistake in the original commit message let me 
make a v2 also noting that this has been checked as well.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



      reply	other threads:[~2012-07-26 10:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 10:04 [PATCH] usbutils: avoid dependency on bash Paul Eggleton
2012-07-26 10:24 ` Koen Kooi
2012-07-26 10:38   ` Paul Eggleton
2012-07-26 10:42     ` Koen Kooi
2012-07-26 10:46       ` Paul Eggleton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1753997.KifeUqhHux@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox