From: Louis Rannou <lrannou@baylibre.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: openembedded-core@lists.openembedded.org, khilman@baylibre.com
Subject: Re: [OE-core] [PATCH v4 1/2] oeqa/utils/qemurunner: change the serial runner
Date: Tue, 18 Apr 2023 09:31:17 +0200 [thread overview]
Message-ID: <18563bee-f233-6dd4-8d7b-a4e8940fbf28@baylibre.com> (raw)
In-Reply-To: <20230412095722.79b78b4e@booty>
Hello Luca,
You are correct, thanks !
Louis
On 12/04/2023 09:57, Luca Ceresoli wrote:
> Hello Louis,
>
> On Tue, 11 Apr 2023 17:05:02 +0200
> "Louis Rannou" <lrannou@baylibre.com> wrote:
>
>> [YOCTO #15021]
>>
>> Create a new runner run_serial_socket which usage matches the traditional ssh
>
> Nit: I'm not a native English speaker, but I think "whose usage" is the
> correct form.
>
>> runner. Its return status is 0 when the command succeeded or 0 when it
>> failed. If an error is encountered, it raises an Exception.
>
> Should be "or a negative error when it fails"?
>
> I'm taking the patch for testing with these two changes, let me know if
> I should do otherwise.
>
> Luca
>
next prev parent reply other threads:[~2023-04-18 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 15:05 [PATCH v4 0/2] oeqa: Change the serial runner Louis Rannou
2023-04-11 15:05 ` [PATCH v4 1/2] oeqa/utils/qemurunner: change " Louis Rannou
2023-04-12 7:57 ` [OE-core] " Luca Ceresoli
2023-04-18 7:31 ` Louis Rannou [this message]
2023-05-05 10:32 ` Ross Burton
2023-05-05 10:36 ` Ross Burton
2023-05-05 10:50 ` Richard Purdie
2023-05-09 12:22 ` Louis Rannou
2023-04-11 15:05 ` [PATCH v4 2/2] oeqa/selftest: change deprecated usage of run_serial Louis Rannou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18563bee-f233-6dd4-8d7b-a4e8940fbf28@baylibre.com \
--to=lrannou@baylibre.com \
--cc=khilman@baylibre.com \
--cc=luca.ceresoli@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox