From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ross Burton <ross.burton@arm.com>,
"lrannou@baylibre.com" <lrannou@baylibre.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
"khilman@baylibre.com" <khilman@baylibre.com>
Subject: Re: [OE-core] [PATCH v4 1/2] oeqa/utils/qemurunner: change the serial runner
Date: Fri, 05 May 2023 11:50:34 +0100 [thread overview]
Message-ID: <1b54d3066cc49b1598ebfc9e2ae287fe9558f869.camel@linuxfoundation.org> (raw)
In-Reply-To: <F625F79E-BD48-4A70-BA5F-D5BC13ED39D3@arm.com>
On Fri, 2023-05-05 at 10:32 +0000, Ross Burton wrote:
> On 11 Apr 2023, at 16:05, Louis Rannou via lists.openembedded.org <lrannou=baylibre.com@lists.openembedded.org> wrote:
> > Create a new runner run_serial_socket which usage matches the traditional ssh
> > runner. Its return status is 0 when the command succeeded or 0 when it
> > failed. If an error is encountered, it raises an Exception.
> >
> > The previous serial runner is maintained and marked as deprecated.
>
> I absolutely love this because the existing run_serial has the most
> confusing behaviour. However, we’re now duplicating a large chunk of
> code: can the old function be implemented such that it calls the new
> function and adapts the return values?
This has hovered in the patch queue for that reason. I also love the
idea of it, it just doesn't feel quite ready.
I've been hoping we could convert the existing users and be able to
drop the old function but I'm not managed to see how much work is left
for that.
Cheers,
Richard
next prev parent reply other threads:[~2023-05-05 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 15:05 [PATCH v4 0/2] oeqa: Change the serial runner Louis Rannou
2023-04-11 15:05 ` [PATCH v4 1/2] oeqa/utils/qemurunner: change " Louis Rannou
2023-04-12 7:57 ` [OE-core] " Luca Ceresoli
2023-04-18 7:31 ` Louis Rannou
2023-05-05 10:32 ` Ross Burton
2023-05-05 10:36 ` Ross Burton
2023-05-05 10:50 ` Richard Purdie [this message]
2023-05-09 12:22 ` Louis Rannou
2023-04-11 15:05 ` [PATCH v4 2/2] oeqa/selftest: change deprecated usage of run_serial Louis Rannou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b54d3066cc49b1598ebfc9e2ae287fe9558f869.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=lrannou@baylibre.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox