Re: [RFC PATCH 1/4] qt4: fix compile error in Qt 4.8.0 with gcc 4.6

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Friday 10 February 2012 13:56:44 Paul Eggleton wrote:
> On Thursday 09 February 2012 13:19:22 Khem Raj wrote:
> > since there is a namespace conflict that should be fixed IMO removing
> > Wrror is not quite the right thing to do here IMO.
> 
> So removing -Werror is somewhat heavy-handed, yes; perhaps we can simply
> add -Wno-error=c++0x-compat and mark this patch as inappropriate for
> upstreaming instead?

So, I dug further into this, and I discovered that the reason for this 
breaking was that the Qt configure script thought we were not using g++ as the 
C++ compiler (!) thus it did not detect the gcc version, and therefore when it 
came to the check to see if gcc 4.6+ was being used in order to add the -Wno-
c++0x-compat option to CXXFLAGS (which it already has code to do), the version 
was not set and the option was not added.

I've updated the contrib branch to fix this as well as reformat the other patch 
as Koen requested.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre