* [PATCH] btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder
@ 2019-02-22 18:31 Ivan Efimov
2019-02-25 11:24 ` Burton, Ross
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Efimov @ 2019-02-22 18:31 UTC (permalink / raw)
To: OE-core
[-- Attachment #1: Type: text/plain, Size: 2323 bytes --]
Command line for target "libbtrfsutil/%.o" contained
double usage of '-o $@' option and causes compilation error:
cc1: error: too many filenames given
Signed-off-by: Ivan Efimov <i.efimov@inango-systems.com>
---
...01-Makefile-fix-double-o-compiler-option-using.patch | 17 +++++++++++++++++
meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb | 1 +
2 files changed, 18 insertions(+)
create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch
diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-dou$
le-o-compiler-option-using.patch
new file mode 100644
index 0000000000..335067bc1f
--- /dev/null
+++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch
@@ -0,0 +1,17 @@
+Command line for target "libbtrfsutil/%.o" contained double usage
+ of '-o $@' option and caused error:
+ cc1: error: too many filenames given
+
+Index: git/Makefile
+===================================================================
+--- git.orig/Makefile
++++ git/Makefile
+@@ -414,7 +414,7 @@ libbtrfs.so.0 libbtrfs.so: libbtrfs.so.0
+
+ libbtrfsutil/%.o: libbtrfsutil/%.c
+ @echo " [CC] $@"
+- $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -o $@ -c $< -o $@
++ $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -c $< -o $@
+
+ libbtrfsutil.so.$(libbtrfsutil_version): $(libbtrfsutil_objects)
+ @echo " [LD] $@"
diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
index 1b4f515cb6..f1c4691313 100644
--- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
+++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
@@ -19,6 +19,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \
file://0001-Makefile-build-mktables-using-native-gcc.patch \
file://0001-Add-LDFLAGS-when-building-libbtrfsutil.so.patch \
file://0001-Add-a-possibility-to-specify-where-python-modules-ar.patch \
+ file://0001-Makefile-fix-double-o-compiler-option-using.patch \
"
inherit autotools-brokensep pkgconfig manpages distutils3-base
--
2.14.1
[-- Attachment #2: Type: text/html, Size: 3160 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder
2019-02-22 18:31 [PATCH] btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder Ivan Efimov
@ 2019-02-25 11:24 ` Burton, Ross
2019-02-25 13:23 ` Ivan Efimov
0 siblings, 1 reply; 3+ messages in thread
From: Burton, Ross @ 2019-02-25 11:24 UTC (permalink / raw)
To: Ivan Efimov; +Cc: OE-core
Please don't send patches in HTML [1]. The patch you add is also
missing a Signed-off-by and Upstream-Status [2] For such a trivial
build issue, we encourage submitting the patch upstream too so we
don't have to carry it forever.
[1] https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
[2] https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
On Fri, 22 Feb 2019 at 18:32, Ivan Efimov <i.efimov@inango-systems.com> wrote:
>
> Command line for target "libbtrfsutil/%.o" contained
> double usage of '-o $@' option and causes compilation error:
>
> cc1: error: too many filenames given
>
> Signed-off-by: Ivan Efimov <i.efimov@inango-systems.com>
> ---
> ...01-Makefile-fix-double-o-compiler-option-using.patch | 17 +++++++++++++++++
> meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb | 1 +
> 2 files changed, 18 insertions(+)
> create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch
>
> diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-dou$
> le-o-compiler-option-using.patch
> new file mode 100644
> index 0000000000..335067bc1f
> --- /dev/null
> +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch
> @@ -0,0 +1,17 @@
> +Command line for target "libbtrfsutil/%.o" contained double usage
> + of '-o $@' option and caused error:
> + cc1: error: too many filenames given
> +
> +Index: git/Makefile
> +===================================================================
> +--- git.orig/Makefile
> ++++ git/Makefile
> +@@ -414,7 +414,7 @@ libbtrfs.so.0 libbtrfs.so: libbtrfs.so.0
> +
> + libbtrfsutil/%.o: libbtrfsutil/%.c
> + @echo " [CC] $@"
> +- $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -o $@ -c $< -o $@
> ++ $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -c $< -o $@
> +
> + libbtrfsutil.so.$(libbtrfsutil_version): $(libbtrfsutil_objects)
> + @echo " [LD] $@"
> diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
> index 1b4f515cb6..f1c4691313 100644
> --- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
> +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
> @@ -19,6 +19,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \
> file://0001-Makefile-build-mktables-using-native-gcc.patch \
> file://0001-Add-LDFLAGS-when-building-libbtrfsutil.so.patch \
> file://0001-Add-a-possibility-to-specify-where-python-modules-ar.patch \
> + file://0001-Makefile-fix-double-o-compiler-option-using.patch \
> "
>
> inherit autotools-brokensep pkgconfig manpages distutils3-base
> --
> 2.14.1
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder
2019-02-25 11:24 ` Burton, Ross
@ 2019-02-25 13:23 ` Ivan Efimov
0 siblings, 0 replies; 3+ messages in thread
From: Ivan Efimov @ 2019-02-25 13:23 UTC (permalink / raw)
To: Ross Burton; +Cc: OE-core
Thank you for info about https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
I mistakenly followed guide https://wiki.yoctoproject.org/wiki/Poky_Contributions.
Best regards,
Ivan
----- Original Message -----
From: "Ross Burton" <ross.burton@intel.com>
To: "Ivan Efimov" <i.efimov@inango-systems.com>
Cc: "OE-core" <openembedded-core@lists.openembedded.org>
Sent: Monday, February 25, 2019 4:24:24 PM
Subject: Re: [OE-core] [PATCH] btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder
Please don't send patches in HTML [1]. The patch you add is also
missing a Signed-off-by and Upstream-Status [2] For such a trivial
build issue, we encourage submitting the patch upstream too so we
don't have to carry it forever.
[1] https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
[2] https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
On Fri, 22 Feb 2019 at 18:32, Ivan Efimov <i.efimov@inango-systems.com> wrote:
>
> Command line for target "libbtrfsutil/%.o" contained
> double usage of '-o $@' option and causes compilation error:
>
> cc1: error: too many filenames given
>
> Signed-off-by: Ivan Efimov <i.efimov@inango-systems.com>
> ---
> ...01-Makefile-fix-double-o-compiler-option-using.patch | 17 +++++++++++++++++
> meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb | 1 +
> 2 files changed, 18 insertions(+)
> create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch
>
> diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-dou$
> le-o-compiler-option-using.patch
> new file mode 100644
> index 0000000000..335067bc1f
> --- /dev/null
> +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch
> @@ -0,0 +1,17 @@
> +Command line for target "libbtrfsutil/%.o" contained double usage
> + of '-o $@' option and caused error:
> + cc1: error: too many filenames given
> +
> +Index: git/Makefile
> +===================================================================
> +--- git.orig/Makefile
> ++++ git/Makefile
> +@@ -414,7 +414,7 @@ libbtrfs.so.0 libbtrfs.so: libbtrfs.so.0
> +
> + libbtrfsutil/%.o: libbtrfsutil/%.c
> + @echo " [CC] $@"
> +- $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -o $@ -c $< -o $@
> ++ $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -c $< -o $@
> +
> + libbtrfsutil.so.$(libbtrfsutil_version): $(libbtrfsutil_objects)
> + @echo " [LD] $@"
> diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
> index 1b4f515cb6..f1c4691313 100644
> --- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
> +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb
> @@ -19,6 +19,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \
> file://0001-Makefile-build-mktables-using-native-gcc.patch \
> file://0001-Add-LDFLAGS-when-building-libbtrfsutil.so.patch \
> file://0001-Add-a-possibility-to-specify-where-python-modules-ar.patch \
> + file://0001-Makefile-fix-double-o-compiler-option-using.patch \
> "
>
> inherit autotools-brokensep pkgconfig manpages distutils3-base
> --
> 2.14.1
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
[ https://inango.com/ | ]
Ivan Efimov
Architect, Arch Group
i.efimov@inango-systems.com
T +7 343 298 0147 C +7 904 9 888 350
[ https://inango.com/ | inango.com ] [ https://www.linkedin.com/company/inango ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-25 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-22 18:31 [PATCH] btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder Ivan Efimov
2019-02-25 11:24 ` Burton, Ross
2019-02-25 13:23 ` Ivan Efimov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox