[PATCH] gdb: add PACKAGECONFIG for xz (lzma) compression support

[PATCH] gdb: add PACKAGECONFIG for xz (lzma) compression support

[Dan Callaghan]

Similar to elfutils, when xz support is built into gdb it will be able
to read xz-compressed ELF sections containing debuginfo. This is used by
the "mini debuginfo" format:

https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
---
 meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
index 08f615addf..5d670561b0 100644
--- a/meta/recipes-devtools/gdb/gdb-common.inc
+++ b/meta/recipes-devtools/gdb/gdb-common.inc
@@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
 
 EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
                 --with-curses --disable-multilib --disable-sim \
-                --without-lzma --without-guile \
+                --without-guile \
                 ${GDBPROPREFIX} ${EXPAT} \
                 ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
                 --disable-rpath \
@@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
 PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
 # ncurses is already a hard DEPENDS, but would be added here if it weren't
 PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
+PACKAGECONFIG[xz] = "--with-lzma,--without-lzma"
 
 GDBPROPREFIX = "--program-prefix=''"
 
-- 
2.21.0

✗ patchtest: failure for gdb: add PACKAGECONFIG for xz (lzma) compression support

[Patchwork]

== Series Details ==

Series: gdb: add PACKAGECONFIG for xz (lzma) compression support
Revision: 1
URL   : https://patchwork.openembedded.org/series/22174/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            gdb: add PACKAGECONFIG for xz (lzma) compression support
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] gdb: add PACKAGECONFIG for xz (lzma) compression support

[Richard Purdie]

On Tue, 2020-01-21 at 09:48 +1000, Dan Callaghan wrote:
> Similar to elfutils, when xz support is built into gdb it will be able
> to read xz-compressed ELF sections containing debuginfo. This is used by
> the "mini debuginfo" format:
> 
> https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
> ---
>  meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> index 08f615addf..5d670561b0 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
>  
>  EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
>                  --with-curses --disable-multilib --disable-sim \
> -                --without-lzma --without-guile \
> +                --without-guile \
>                  ${GDBPROPREFIX} ${EXPAT} \
>                  ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
>                  --disable-rpath \
> @@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
>  PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
>  # ncurses is already a hard DEPENDS, but would be added here if it weren't
>  PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
> +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma"
>  
>  GDBPROPREFIX = "--program-prefix=''"

Is there an extra DEPENDS needed when enabling this?

Cheers,

Richard

Re: [PATCH] gdb: add PACKAGECONFIG for xz (lzma) compression support

[Dan Callaghan]

Excerpts from Richard Purdie's message of 2020-01-21 00:04:53 +00:00:
> Is there an extra DEPENDS needed when enabling this?

Oops, yes it should really pull in xz. I missed this because xz is 
already a transitive dependency through something else. Will post a new 
patch.

-- 
Dan Callaghan <dan.callaghan@opengear.com>
Software Engineer
Opengear <https://opengear.com/>

[PATCH v2] gdb: add PACKAGECONFIG for xz (lzma) compression support

[Dan Callaghan]

Similar to elfutils, when xz support is built into gdb it will be able
to read xz-compressed ELF sections containing debuginfo. This is used by
the "mini debuginfo" format:
https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html

Signed-off-by: Dan Callaghan <dan.callaghan@opengear.com>
---
 meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
index 08f615addf..878a03715c 100644
--- a/meta/recipes-devtools/gdb/gdb-common.inc
+++ b/meta/recipes-devtools/gdb/gdb-common.inc
@@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
 
 EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
                 --with-curses --disable-multilib --disable-sim \
-                --without-lzma --without-guile \
+                --without-guile \
                 ${GDBPROPREFIX} ${EXPAT} \
                 ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
                 --disable-rpath \
@@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
 PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
 # ncurses is already a hard DEPENDS, but would be added here if it weren't
 PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
+PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz"
 
 GDBPROPREFIX = "--program-prefix=''"
 
-- 
2.21.0

Re: [PATCH v2] gdb: add PACKAGECONFIG for xz (lzma) compression support

[Dan Callaghan]

Bump... I just noticed this patch was never applied. I have been 
carrying it locally all year and it still applies cleanly. Any issues 
preventing it from being applied?

Excerpts from Dan Callaghan's message of 2020-01-21 11:24:12 +10:00:
> Similar to elfutils, when xz support is built into gdb it will be able
> to read xz-compressed ELF sections containing debuginfo. This is used by
> the "mini debuginfo" format:
> https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
> 
> Signed-off-by: Dan Callaghan <dan.callaghan@opengear.com>
> ---
>  meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> index 08f615addf..878a03715c 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
>  
>  EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
>                  --with-curses --disable-multilib --disable-sim \
> -                --without-lzma --without-guile \
> +                --without-guile \
>                  ${GDBPROPREFIX} ${EXPAT} \
>                  ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
>                  --disable-rpath \
> @@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
>  PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
>  # ncurses is already a hard DEPENDS, but would be added here if it weren't
>  PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
> +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz"
>  
>  GDBPROPREFIX = "--program-prefix=''"
>  

-- 
Dan Callaghan <dan.callaghan@digi.com>
Software Engineer
Opengear <https://opengear.com/>

Re: [OE-core] [PATCH v2] gdb: add PACKAGECONFIG for xz (lzma) compression support

[Khem Raj]

On Wed, Nov 11, 2020 at 11:40 PM Dan Callaghan via
lists.openembedded.org
<dan.callaghan=opengear.com@lists.openembedded.org> wrote:
>
> Bump... I just noticed this patch was never applied. I have been
> carrying it locally all year and it still applies cleanly. Any issues
> preventing it from being applied?
>

thanks, I think this patch is fine.

> Excerpts from Dan Callaghan's message of 2020-01-21 11:24:12 +10:00:
> > Similar to elfutils, when xz support is built into gdb it will be able
> > to read xz-compressed ELF sections containing debuginfo. This is used by
> > the "mini debuginfo" format:
> > https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
> >
> > Signed-off-by: Dan Callaghan <dan.callaghan@opengear.com>
> > ---
> >  meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> > index 08f615addf..878a03715c 100644
> > --- a/meta/recipes-devtools/gdb/gdb-common.inc
> > +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> > @@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
> >
> >  EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
> >                  --with-curses --disable-multilib --disable-sim \
> > -                --without-lzma --without-guile \
> > +                --without-guile \
> >                  ${GDBPROPREFIX} ${EXPAT} \
> >                  ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
> >                  --disable-rpath \
> > @@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
> >  PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
> >  # ncurses is already a hard DEPENDS, but would be added here if it weren't
> >  PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
> > +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz"
> >
> >  GDBPROPREFIX = "--program-prefix=''"
> >
>
> --
> Dan Callaghan <dan.callaghan@digi.com>
> Software Engineer
> Opengear <https://opengear.com/>
>
> 
>