* any current standard on avoiding use of both "_append" and "+="?
@ 2012-07-22 19:12 Robert P. J. Day
2012-07-23 9:15 ` Paul Eggleton
0 siblings, 1 reply; 5+ messages in thread
From: Robert P. J. Day @ 2012-07-22 19:12 UTC (permalink / raw)
To: OE Core mailing list
quick check shows this:
recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
recipes-sato/webkit/webkit-gtk_1.8.1.bb:EXTRA_OECONF_append_powerpc += "--with-unicode-backend=glib"
recipes-sato/webkit/webkit-gtk_1.8.1.bb:CPPFLAGS_append_powerpc += "-I${STAGING_INCDIR}/pango-1.0 \
was there going to be any effort to avoid combining "_append" with
"+=" in recipe files, simply for the sake of clarity?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: any current standard on avoiding use of both "_append" and "+="?
2012-07-22 19:12 any current standard on avoiding use of both "_append" and "+="? Robert P. J. Day
@ 2012-07-23 9:15 ` Paul Eggleton
2012-07-23 10:07 ` Robert P. J. Day
0 siblings, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2012-07-23 9:15 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: openembedded-core
On Sunday 22 July 2012 15:12:51 Robert P. J. Day wrote:
> quick check shows this:
>
> recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I
> ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> recipes-sato/webkit/webkit-gtk_1.8.1.bb:EXTRA_OECONF_append_powerpc +=
> "--with-unicode-backend=glib"
> recipes-sato/webkit/webkit-gtk_1.8.1.bb:CPPFLAGS_append_powerpc +=
> "-I${STAGING_INCDIR}/pango-1.0 \
>
> was there going to be any effort to avoid combining "_append" with
> "+=" in recipe files, simply for the sake of clarity?
It's fine for these to be cleaned up as long as a leading space is added for
the second and third (since += will be doing this at the moment).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: any current standard on avoiding use of both "_append" and "+="?
2012-07-23 9:15 ` Paul Eggleton
@ 2012-07-23 10:07 ` Robert P. J. Day
2012-07-23 10:12 ` Paul Eggleton
0 siblings, 1 reply; 5+ messages in thread
From: Robert P. J. Day @ 2012-07-23 10:07 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On Mon, 23 Jul 2012, Paul Eggleton wrote:
> On Sunday 22 July 2012 15:12:51 Robert P. J. Day wrote:
> > quick check shows this:
> >
> > recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I
> > ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> > recipes-sato/webkit/webkit-gtk_1.8.1.bb:EXTRA_OECONF_append_powerpc +=
> > "--with-unicode-backend=glib"
> > recipes-sato/webkit/webkit-gtk_1.8.1.bb:CPPFLAGS_append_powerpc +=
> > "-I${STAGING_INCDIR}/pango-1.0 \
> >
> > was there going to be any effort to avoid combining "_append" with
> > "+=" in recipe files, simply for the sake of clarity?
>
> It's fine for these to be cleaned up as long as a leading space is added for
> the second and third (since += will be doing this at the moment).
is this valid?
meta/classes/rootfs_rpm.bbclass:IMAGE_ROOTFS_EXTRA_SPACE_append = "${@base_contains("PACKAGE_INSTALL", "zypper", " + 51200", "" ,d)}"
does one not need the leading space in this context?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: any current standard on avoiding use of both "_append" and "+="?
2012-07-23 10:07 ` Robert P. J. Day
@ 2012-07-23 10:12 ` Paul Eggleton
2012-07-23 10:15 ` Robert P. J. Day
0 siblings, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2012-07-23 10:12 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: openembedded-core
On Monday 23 July 2012 06:07:58 Robert P. J. Day wrote:
> is this valid?
>
> meta/classes/rootfs_rpm.bbclass:IMAGE_ROOTFS_EXTRA_SPACE_append =
> "${@base_contains("PACKAGE_INSTALL", "zypper", " + 51200", "" ,d)}"
>
> does one not need the leading space in this context?
We're not adding to something that is space-separated in this instance. In any
case, if we are adding anything with this statement (i.e. if PACKAGE_INSTALL
contains "zypper") then " + 51200" is being added which does contain a leading
space.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: any current standard on avoiding use of both "_append" and "+="?
2012-07-23 10:12 ` Paul Eggleton
@ 2012-07-23 10:15 ` Robert P. J. Day
0 siblings, 0 replies; 5+ messages in thread
From: Robert P. J. Day @ 2012-07-23 10:15 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On Mon, 23 Jul 2012, Paul Eggleton wrote:
> On Monday 23 July 2012 06:07:58 Robert P. J. Day wrote:
> > is this valid?
> >
> > meta/classes/rootfs_rpm.bbclass:IMAGE_ROOTFS_EXTRA_SPACE_append =
> > "${@base_contains("PACKAGE_INSTALL", "zypper", " + 51200", "" ,d)}"
> >
> > does one not need the leading space in this context?
>
> We're not adding to something that is space-separated in this
> instance. In any case, if we are adding anything with this statement
> (i.e. if PACKAGE_INSTALL contains "zypper") then " + 51200" is being
> added which does contain a leading space.
ah, quite so, i failed to notice that.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-23 10:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-22 19:12 any current standard on avoiding use of both "_append" and "+="? Robert P. J. Day
2012-07-23 9:15 ` Paul Eggleton
2012-07-23 10:07 ` Robert P. J. Day
2012-07-23 10:12 ` Paul Eggleton
2012-07-23 10:15 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox