Re: [PATCH v2 5/8] gstreamer1.0-plugins-good: 1.12.4 -> 1.14.0

[Anuj Mittal <anuj.mittal@intel.com>]

On 04/25/2018 03:23 PM, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> Upgrade gstreamer1.0-plugins-good from 1.12.4 to 1.14.0.
> 
> * add packageconfig 'gtk' and configure option '--disable-qt' from -bad
> * add packageconfig 'lame', 'mpg123' and configure option
>   '--disable-twolame' from -ugly
> * remove configure option '--disable-sunaudio' since plugin sunaudio has
>   been removed
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  .../gstreamer/gstreamer1.0-plugins-good.inc               | 15 +++++++++++++--
>  ...good_1.12.4.bb => gstreamer1.0-plugins-good_1.14.0.bb} |  4 ++--
>  2 files changed, 15 insertions(+), 4 deletions(-)
>  rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-plugins-good_1.12.4.bb => gstreamer1.0-plugins-good_1.14.0.bb} (85%)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> index 14c3d61848..ed14ed56c2 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
> @@ -6,10 +6,12 @@ DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"
>  
>  inherit gettext
>  
> +# gtk is not in the PACKAGECONFIG variable by default until
> +# the transition to gtk+3 is finished
>  PACKAGECONFIG ??= " \
>      ${GSTREAMER_ORC} \
>      ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11', d)} \
> -    cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 \
> +    cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex taglib v4l2 \
>  "
>  
>  X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
> @@ -18,11 +20,14 @@ PACKAGECONFIG[cairo]      = "--enable-cairo,--disable-cairo,cairo"
>  PACKAGECONFIG[dv1394]     = "--enable-dv1394,--disable-dv1394,libiec61883 libavc1394 libraw1394"
>  PACKAGECONFIG[flac]       = "--enable-flac,--disable-flac,flac"
>  PACKAGECONFIG[gdk-pixbuf] = "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
> +PACKAGECONFIG[gtk]             = "--enable-gtk3,--disable-gtk3,gtk+3"
>  PACKAGECONFIG[gudev]      = "--with-gudev,--without-gudev,libgudev"
>  PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
>  PACKAGECONFIG[jpeg]       = "--enable-jpeg,--disable-jpeg,jpeg"
> +PACKAGECONFIG[lame]       = "--enable-lame,--disable-lame,lame"
>  PACKAGECONFIG[libpng]     = "--enable-libpng,--disable-libpng,libpng"
>  PACKAGECONFIG[libv4l2]    = "--with-libv4l2,--without-libv4l2,v4l-utils"
> +PACKAGECONFIG[mpg123]     = "--enable-mpg123,--disable-mpg123,mpg123"
>  PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
>  PACKAGECONFIG[soup]       = "--enable-soup,--disable-soup,libsoup-2.4"
>  PACKAGECONFIG[speex]      = "--enable-speex,--disable-speex,speex"
> @@ -32,6 +37,11 @@ PACKAGECONFIG[vpx]        = "--enable-vpx,--disable-vpx,libvpx"
>  PACKAGECONFIG[wavpack]    = "--enable-wavpack,--disable-wavpack,wavpack"
>  PACKAGECONFIG[x11]        = "--enable-x,--disable-x,${X11DEPENDS}"
>  
> +# qt5 support is disabled, because it is not present in OE core, and requires more work than
> +# just adding a packageconfig (it requires access to moc, uic, rcc, and qmake paths).
> +# This is better done in a separate qt5 layer (which then should add a "qt5" packageconfig
> +# in a gstreamer1.0-plugins-bad bbappend).
> +
>  EXTRA_OECONF += " \
>      --enable-bz2 \

bz2 and zlib are optional and perhaps should be moved to PACKAGECONFIG
instead.

I had done a similar upgrade but was waiting for the release before
submitting:

https://github.com/anujm1/poky/commit/83204baaa9023e1514132534acbb4ec3968c1a15