Re: [PATCH v2 2/8] gstreamer1.0-plugins-base: 1.12.4 -> 1.14.0

[Anuj Mittal <anuj.mittal@intel.com>]

On 04/25/2018 03:23 PM, kai.kang@windriver.com wrote:
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-subparse-set-need_segment-after-sink-pad-received-GS.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-subparse-set-need_segment-after-sink-pad-received-GS.patch
> index b924e38824..438f4ebbf2 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-subparse-set-need_segment-after-sink-pad-received-GS.patch
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-subparse-set-need_segment-after-sink-pad-received-GS.patch
> @@ -20,7 +20,7 @@ new mode 100755
>  index b565e93..7741ccc
>  --- a/gst/subparse/gstsubparse.c
>  +++ b/gst/subparse/gstsubparse.c
> -@@ -266,22 +266,20 @@ gst_sub_parse_src_event (GstPad * pad, GstObject * parent, GstEvent * event)
> +@@ -270,24 +270,20 @@ gst_sub_parse_src_event (GstPad * pad, GstObject * parent, GstEvent * event)
>           goto beach;
>         }
>   
> @@ -45,13 +45,15 @@ index b565e93..7741ccc
>  -        GST_DEBUG_OBJECT (self, "segment after seek: %" GST_SEGMENT_FORMAT,
>  -            &self->segment);
>  -
> --        self->need_segment = TRUE;
> +-        /* will mark need_segment when receiving segment from upstream,
> +-         * after FLUSH and all that has happened,
> +-         * rather than racing with chain */
>  -      } else {
>  +      if (!ret) {

This probably should be checked if it's still required.

Please consider adding a PACKAGECONFIG to have jpeg enabled too ..