Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Yi Zhao <yi.zhao@windriver.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/2] sassc: fix runtime version
Date: Thu, 24 Apr 2025 12:29:22 +0800	[thread overview]
Message-ID: <1ff938bc-cd01-4fa8-9da1-b5481d86f405@windriver.com> (raw)
In-Reply-To: <CANNYZj9EC2=+XLtNRuwNHWNCqkKYfnCoCFm+1BNzwfsTTTGvmw@mail.gmail.com>


On 4/23/25 22:59, Alexander Kanavin wrote:
> On Wed, 23 Apr 2025 at 14:50, Yi Zhao <yi.zhao@windriver.com> wrote:
>> There is already a sassc_version.h file with version number [NA] in the
>> source directory. When ${S} != ${B}, the generated sassc_version.h is
>> located in the build directory, and the same file in the source
>> directory is not overwritten. However, the latter is used during build,
>> resulting in version [NA]. Can it be fixed by inheriting
>> autotools-brokensep? Or copy the generated sassc_version.h from ${B} to
>> ${S}after do_configure?
> I think a better fix is to make a patch that deletes the bogus
> generated sassc_version.h from the source tree. Normally this patch
> would be offered upstream, but it looks like this upstream is
> inactive, so you can mark the patch as Inactive-Upstream [last commit
> X years ago].


Thanks. I will send v2.


//Yi

>
> Alex


  reply	other threads:[~2025-04-24  4:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21  9:06 [PATCH 1/2] libsass: fix runtime version Yi Zhao
2025-04-21  9:06 ` [PATCH 2/2] sassc: " Yi Zhao
2025-04-22 15:44   ` [OE-core] " Alexander Kanavin
2025-04-23 12:50     ` Yi Zhao
2025-04-23 14:59       ` Alexander Kanavin
2025-04-24  4:29         ` Yi Zhao [this message]
2025-04-22 15:45 ` [OE-core] [PATCH 1/2] libsass: " Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ff938bc-cd01-4fa8-9da1-b5481d86f405@windriver.com \
    --to=yi.zhao@windriver.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox