Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Yi Zhao <yi.zhao@windriver.com>
To: alex.kanavin@gmail.com, yi.zhao@eng.windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/2] sassc: fix runtime version
Date: Wed, 23 Apr 2025 20:50:41 +0800	[thread overview]
Message-ID: <4e3faf82-60b7-4538-bc64-5c03d4ba99a5@windriver.com> (raw)
In-Reply-To: <CANNYZj_Zfs_eqK4GDdH_5yj5uGcttoHQ4uO1=uQ3u55--SV7Sw@mail.gmail.com>


On 4/22/25 23:44, Alexander Kanavin via lists.openembedded.org wrote:
> On Mon, 21 Apr 2025 at 11:06, Yi Zhao via lists.openembedded.org
> <yi.zhao=eng.windriver.com@lists.openembedded.org> wrote:
>
>> +do_configure:append() {
>> +    sed -i -e 's/\[NA\]/${PV}/g' ${S}/sassc_version.h
>> +}
> This is a generated file (from sassc_version.h.in), so why is it not
> generated correctly? Should we rather do that?

There is already a sassc_version.h file with version number [NA] in the 
source directory. When ${S} != ${B}, the generated sassc_version.h is 
located in the build directory, and the same file in the source 
directory is not overwritten. However, the latter is used during build, 
resulting in version [NA]. Can it be fixed by inheriting 
autotools-brokensep? Or copy the generated sassc_version.h from ${B} to 
${S}after do_configure?


//Yi


>
> Alex
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#215234): https://lists.openembedded.org/g/openembedded-core/message/215234
> Mute This Topic: https://lists.openembedded.org/mt/112372256/7283133
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [yi.zhao@eng.windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


  reply	other threads:[~2025-04-23 12:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21  9:06 [PATCH 1/2] libsass: fix runtime version Yi Zhao
2025-04-21  9:06 ` [PATCH 2/2] sassc: " Yi Zhao
2025-04-22 15:44   ` [OE-core] " Alexander Kanavin
2025-04-23 12:50     ` Yi Zhao [this message]
2025-04-23 14:59       ` Alexander Kanavin
2025-04-24  4:29         ` Yi Zhao
2025-04-22 15:45 ` [OE-core] [PATCH 1/2] libsass: " Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e3faf82-60b7-4538-bc64-5c03d4ba99a5@windriver.com \
    --to=yi.zhao@windriver.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=yi.zhao@eng.windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox