libtool-cross patch thread : follow up on do_install...

libtool-cross patch thread : follow up on do_install...

[Mike Williamson]

Hi,

I was investigating a build issue using a local recipe inheriting autotools
employing libtool (a compile of unixodbc, needed by the new php recipe)
and ran into an issue that appears to be solved by modifying the
do_install() method of libtool-cross according to comments made
in this patch thread:

http://patches.openembedded.org/patch/15065/

Basically, replace the do_install with "oe_runmake DESTDIR=${D} install"
suggested by Khem Raj.   Mike Crowe seemed to think that it cleaned
up issues he was having, but the thread seems to die at that point.

The current recipe for libtool-cross does not reflect the modification
mentioned, so I am wondering if this is not appropriate?
Am I doing more harm than good?

Thanks.

-Mike

Re: libtool-cross patch thread : follow up on do_install...

[Khem Raj]

On Sun, Mar 25, 2012 at 8:51 AM, Mike Williamson
<michael.williamson@criticallink.com> wrote:
> Hi,
>
> I was investigating a build issue using a local recipe inheriting autotools
> employing libtool (a compile of unixodbc, needed by the new php recipe)
> and ran into an issue that appears to be solved by modifying the
> do_install() method of libtool-cross according to comments made
> in this patch thread:
>
> http://patches.openembedded.org/patch/15065/
>
> Basically, replace the do_install with "oe_runmake DESTDIR=${D} install"
> suggested by Khem Raj.   Mike Crowe seemed to think that it cleaned
> up issues he was having, but the thread seems to die at that point.
>
> The current recipe for libtool-cross does not reflect the modification
> mentioned, so I am wondering if this is not appropriate?
> Am I doing more harm than good?

Mike Crowe did not report back so if he saw no issues we should have this patch
in with required alteration.

>
> Thanks.
>
> -Mike

Re: libtool-cross patch thread : follow up on do_install...

[Mike Crowe]

On Sun, Mar 25, 2012 at 10:07:17AM -0700, Khem Raj wrote:
> On Sun, Mar 25, 2012 at 8:51 AM, Mike Williamson
> <michael.williamson@criticallink.com> wrote:
> > Hi,
> >
> > I was investigating a build issue using a local recipe inheriting autotools
> > employing libtool (a compile of unixodbc, needed by the new php recipe)
> > and ran into an issue that appears to be solved by modifying the
> > do_install() method of libtool-cross according to comments made
> > in this patch thread:
> >
> > http://patches.openembedded.org/patch/15065/
> >
> > Basically, replace the do_install with "oe_runmake DESTDIR=${D} install"
> > suggested by Khem Raj.   Mike Crowe seemed to think that it cleaned
> > up issues he was having, but the thread seems to die at that point.
> >
> > The current recipe for libtool-cross does not reflect the modification
> > mentioned, so I am wondering if this is not appropriate?
> > Am I doing more harm than good?
> 
> Mike Crowe did not report back so if he saw no issues we should have this patch
> in with required alteration.

I did have some success but I ended up with various other problems
that I never got to the bottom of. I kept hoping I'd be able to
investigate further and solve the remaining problems but that has
turned out not to be the case. :(

I did find that I had to add back the parts from Richard's original
patch that installed stuff in ${bindir_crossscripts}.

But after that it seems that my variables are a mixture of full paths
and relative paths which causes problems when I run make install
whether I use ${MAKE} or oe_runmake and whether I specify DESTDIR or
not.

For example, during do_configure_prepend I have the following:

STAGING_DATADIR=/home/mac/src/oe/build/tmp-eglibc/sysroots/panther/home/mac/src/oe/build/tmp-eglibc/sysroots/panther/usr/share
STAGING_DIR=/home/mac/src/oe/build/tmp-eglibc/sysroots
datadir=/home/mac/src/oe/build/tmp-eglibc/sysroots/panther/usr/share
target_datadir=/usr/share
libdir=/lib

datadir makes its way into libtool's Makefile so I end up
with the /home/mac/... directories in my image. :(

I tried various things to fix the problem (mainly not making datadir
absolute) but I never got anything that completely worked from
clean. I think some of the remaining problems were due to me using
meta-micro's no /usr though.

I hope this is useful and I'm sorry it's not more so.

Thanks.

Mike.