Re: [PATCH 2/2] sanity.bbclass: Implement initial toolchain sanity checks

[Peter Seebach <peter.seebach@windriver.com>]

On Tue, 1 May 2012 11:47:14 +0100
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:

> > This patch also provides a whitelisting mechanism (which is
> > completely unused) to allow vendors providing prebuilt toolchain
> > components to restrict tunings to those based on or compatible with
> > a particular ABI.

^-- this will be referred back to later

> > +    if not tune or tune == "":
 
> "if not tune:"

Heh.  I do about 80% of my scripting work in Lua and Ruby these
days.  :)
 
> We'd usually have
> 
>    features = (data.getVar("TUNE_FEATURES_tune-%s" % tune, True) or
> "").split() if not features:
>        return "Tuning '%s' has no defined features, and cannot be
> used." % tune

Heh.  And here, again, I'm used to things in which "".split() would
have given me an array with a single empty string back, same as any
other string with no spaces in it.  :)

Looks like I have to do more experiments.
 
> > +    valid_tunes = data.getVarFlags('TUNEVALID') or ""
> > +    conflicts = data.getVarFlags('TUNECONFLICTS') or ""
 
> Hmm, shouldn't this be "or {}" ?

Yes.

> > +    whitelist = data.getVar("TUNEABI_WHITELIST", True) or ''
 
> So what is TUNEABI_WHITELIST?

See the last paragraph of the above.
 
> and what is TUNEABI_OVERRIDE? These should probably get the [doc] tags
> you add for other things.

Good catch.

> To be honest I'm really tempted to split this tuneabi stuff out into a
> different class. I appreciate the OSVs need something but it probably
> doesn't make sense with half an implementation sitting in the core
> like this, particularly when the code is near impenetrable like the
> above. I'm left wondering what TUNEABI is too...

The big reason I'd advocate for having it in the base stuff is that
otherwise, all the OSVs are going to do their own and do it
incompatibly.  The one thing worse than having one incomprehensible
thing is having many incomprehensible things with subtly different
semantics.
 
> > +                bb.warn("Got an unexpected '%s' in MULTILIBS." %
> > pairs[0])

> Shouldn't this get added to the errors list?

Good question!  I was unable to find anything definite on the topic.
My thought is, if everything has to be multilib:, there's no reason for
the leading multilib: because it adds no information, so presumably
there logically *could* be something else, but I haven't seen any and
don't know about them.

> > +            else:
> > +                if pairs[1] == 'lib':
> > +                    tune_error_set.append("The multilib 'lib' was
> > specified, but that causes parse errors.")

> Hmm, it does?

Yeah, that was the thing I ran into when I tried a default config
someone suggested; I thoughtfully corrected lib32 to lib, and libxcb
exploded with two pages of Python stack traces and diagnostics.  If
that's not intentional, I can drop this check and we can treat it as a
package bug.

> What we really want to check here is that each pair[1] value is
> unique.
> Again, I'd just add this to the error list. If someone really wants to
> do it, they can disable the checks. This should also happen if tune is
> used more than once.

Okay.  Good catch on that, hadn't thought of it.
 
> Just set these and skip "doc" in the above tests. Its ugly but I'd
> prefer to have them set than unset.

Okay.
 
> Can you split this patch into two so we can get the bits that were
> below in (they look fine) whilst we work on the above.

Yup.

-s
-- 
Listen, get this.  Nobody with a good compiler needs to be justified.