[PATCH 0/1] sanity.bbclass: Fix typo

[PATCH 0/1] sanity.bbclass: Fix typo

[Peter Seebach]

So, somehow in the the cleanup, I dropped the "% tune" following a
%s.  Re-added in this patch.  And because I know how typo-prone I am,
I tested that this really does produce the right results now.  :)

The following changes since commit 7163ebd92a799b8f000b2b6f303b20de468b5f90:
  Koen Kooi (1):
        Revert "kmod: Use base_libdir for installing libkmod"

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib seebs/toolchains
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/toolchains

Peter Seebach (1):
  sanity.bbclass:  Attach the missing value to a format string.

 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 1/1] sanity.bbclass: Attach the missing value to a format string.

[Peter Seebach]

The tuning changes to sanity.bbclass were almost right, but one of
the messages had a %s with no % operator.

Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
---
 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index ff3c413..2bb0266 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -47,7 +47,7 @@ def check_toolchain_tune(data, tune, multilib):
             tune_errors.append("Tuning '%s' (%s) cannot be used with any supported tuning/ABI." %
                 (tune, tuneabi))
     if tune_errors:
-        return "Tuning '%s' has the following errors:\n" + '\n'.join(tune_errors)
+        return "Tuning '%s' has the following errors:\n" % tune + '\n'.join(tune_errors)
 
 def check_toolchain(data):
     tune_error_set = []
-- 
1.7.0.4

Re: [PATCH 0/1] sanity.bbclass: Fix typo

[Richard Purdie]

On Thu, 2012-05-17 at 18:45 -0500, Peter Seebach wrote:
> So, somehow in the the cleanup, I dropped the "% tune" following a
> %s.  Re-added in this patch.  And because I know how typo-prone I am,
> I tested that this really does produce the right results now.  :)
> 
> The following changes since commit 7163ebd92a799b8f000b2b6f303b20de468b5f90:
>   Koen Kooi (1):
>         Revert "kmod: Use base_libdir for installing libkmod"
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib seebs/toolchains
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/toolchains
> 
> Peter Seebach (1):
>   sanity.bbclass:  Attach the missing value to a format string.

Merged to master, thanks.

Richard

Re: [PATCH 1/1] sanity.bbclass: Attach the missing value to a format string.

[Peter Seebach]

On Thu, 17 May 2012 18:45:58 -0500
Peter Seebach <peter.seebach@windriver.com> wrote:

> The tuning changes to sanity.bbclass were almost right, but one of
> the messages had a %s with no % operator.
> 
> Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
> ---
>  meta/classes/sanity.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index ff3c413..2bb0266 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -47,7 +47,7 @@ def check_toolchain_tune(data, tune, multilib):
>              tune_errors.append("Tuning '%s' (%s) cannot be used with
> any supported tuning/ABI." % (tune, tuneabi))
>      if tune_errors:
> -        return "Tuning '%s' has the following errors:\n" +
> '\n'.join(tune_errors)
> +        return "Tuning '%s' has the following errors:\n" % tune +
> '\n'.join(tune_errors) 
>  def check_toolchain(data):
>      tune_error_set = []

Just noticed that this seems to have never made it in, should I update
and resend?

-s
-- 
Listen, get this.  Nobody with a good compiler needs to be justified.