* Re: [oe-commits] Ross Burton : connman: ship the empty plugins directory in the connman package
[not found] <20120709160054.C9FA610219@opal>
@ 2012-07-09 20:03 ` Martin Jansa
2012-07-09 20:16 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2012-07-09 20:03 UTC (permalink / raw)
To: openembedded-core; +Cc: openembedded-commits
[-- Attachment #1: Type: text/plain, Size: 2768 bytes --]
On Mon, Jul 09, 2012 at 04:00:54PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 8a307af8253a5fdff51515fe01ef7b527fdad89f
> URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=8a307af8253a5fdff51515fe01ef7b527fdad89f
>
> Author: Ross Burton <ross.burton@intel.com>
> Date: Fri Jul 6 12:05:42 2012 +0100
>
> connman: ship the empty plugins directory in the connman package
>
> Otherwise we get a QA warning that /usr/lib/connman/packages isn't shipped.
both patches from Ross in this batch are missing SOB lines.
Ross: please make sure you add them in future patches
sgw: maybe you're using different flow then RP for merging patches, but
your SOB should be there too IMHO.
Cheers,
>
> ---
>
> meta/recipes-connectivity/connman/connman.inc | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 73e7818..12378e9 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -20,7 +20,7 @@ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \
> ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
> "
>
> -INC_PR = "r10"
> +INC_PR = "r11"
>
> TIST = "--enable-tist"
> TIST_powerpc = ""
> @@ -99,7 +99,7 @@ python populate_packages_prepend() {
> hook = lambda file,pkg,b,c,d:packages.append((file,pkg))
> plugin_dir = d.expand('${libdir}/connman/plugins/')
> plugin_name = d.expand('${PN}-plugin-%s')
> - do_split_packages(d, plugin_dir, '^(.*).so$', plugin_name, '${PN} plugin for %s', extra_depends='', hook=hook )
> + do_split_packages(d, plugin_dir, '^(.*).so$', plugin_name, '${PN} plugin for %s', extra_depends='', hook=hook, prepend=True )
> for (file, package) in packages:
> plugintype = package.split( '-' )[-1]
> if plugintype in depmap:
> @@ -116,6 +116,7 @@ FILES_${PN}-tests = "${bindir}/*-test ${libdir}/${BPN}/test/*"
> RDEPENDS_${PN}-tests = "python-dbus"
>
> FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*.so.* \
> + ${libdir}/connman/plugins \
> ${sysconfdir} ${sharedstatedir} ${localstatedir} \
> ${base_bindir}/* ${base_sbindir}/* ${base_libdir}/*.so* ${datadir}/${PN} \
> ${datadir}/dbus-1/system-services/*"
>
>
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe-commits] Ross Burton : connman: ship the empty plugins directory in the connman package
2012-07-09 20:03 ` [oe-commits] Ross Burton : connman: ship the empty plugins directory in the connman package Martin Jansa
@ 2012-07-09 20:16 ` Burton, Ross
2012-07-09 20:35 ` Martin Jansa
0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2012-07-09 20:16 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: openembedded-commits
On 9 July 2012 21:03, Martin Jansa <martin.jansa@gmail.com> wrote:
> Ross: please make sure you add them in future patches
> sgw: maybe you're using different flow then RP for merging patches, but
> your SOB should be there too IMHO.
I *always* forget, sorry. Is there a way to make git do it automatically?...
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe-commits] Ross Burton : connman: ship the empty plugins directory in the connman package
2012-07-09 20:16 ` Burton, Ross
@ 2012-07-09 20:35 ` Martin Jansa
2012-07-09 20:38 ` Burton, Ross
0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2012-07-09 20:35 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: openembedded-commits
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Mon, Jul 09, 2012 at 09:16:13PM +0100, Burton, Ross wrote:
> On 9 July 2012 21:03, Martin Jansa <martin.jansa@gmail.com> wrote:
> > Ross: please make sure you add them in future patches
> > sgw: maybe you're using different flow then RP for merging patches, but
> > your SOB should be there too IMHO.
>
> I *always* forget, sorry. Is there a way to make git do it automatically?...
Not sure if there is smarter way. I'm using aliases for commit and
cherry-pick to always add '-s'.
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe-commits] Ross Burton : connman: ship the empty plugins directory in the connman package
2012-07-09 20:35 ` Martin Jansa
@ 2012-07-09 20:38 ` Burton, Ross
0 siblings, 0 replies; 4+ messages in thread
From: Burton, Ross @ 2012-07-09 20:38 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 9 July 2012 21:35, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Mon, Jul 09, 2012 at 09:16:13PM +0100, Burton, Ross wrote:
>> On 9 July 2012 21:03, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > Ross: please make sure you add them in future patches
>> > sgw: maybe you're using different flow then RP for merging patches, but
>> > your SOB should be there too IMHO.
>>
>> I *always* forget, sorry. Is there a way to make git do it automatically?...
>
> Not sure if there is smarter way. I'm using aliases for commit and
> cherry-pick to always add '-s'.
The config option format.signoff will automatically sign-off when
using format-patch, which sounds rather useful to me.
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-09 20:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120709160054.C9FA610219@opal>
2012-07-09 20:03 ` [oe-commits] Ross Burton : connman: ship the empty plugins directory in the connman package Martin Jansa
2012-07-09 20:16 ` Burton, Ross
2012-07-09 20:35 ` Martin Jansa
2012-07-09 20:38 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox