Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 4/5] gtk-icon-cache: call postinst scriplet at do_rootfs time
Date: Sat, 4 Aug 2012 21:56:25 +0200	[thread overview]
Message-ID: <20120804195625.GA3267@jama.jama.net> (raw)
In-Reply-To: <CAMKF1spXi6PqV6ZLqLPMUE0oEF2Sou+Jst-QME-XhLoCANeaPQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Sat, Aug 04, 2012 at 12:51:47PM -0700, Khem Raj wrote:
> On Sat, Aug 4, 2012 at 12:37 PM, Andreas Müller
> <schnitzeltony@googlemail.com> wrote:
> > And less than 3min on overo with the patches we sent (and my xfce
> > image is full of gtk-icon-update). Don't misunderstand me: I agree on
> > doing things like this on host if possible. But for me the main time
> > waiting on a new image is do_rootfs and I just suggest to think about
> > having these tasks run only once - but we can do this later or never.
> > A bit off topic: As far as I can remember there were times when it was
> > a no-go having gtk-native in oe-core. I hope they are over...
> 
> I certainly agree with you that it should be run once. However what if
> you changed something in icons between towo do rootfs runs ?
> but I would like to know how much build time is it adding to do_rootfs ?
> sometimes over optimising is bad too.

I think Andreas patch does run it once *per* do_rootfs, so not for every
package which uses it if there is at least one installed in do_rootfs
then it's executed once.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2012-08-04 20:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 20:19 [PATCH 0/5] Run postinst scriptlets at do_rootfs time Laurentiu Palcu
2012-08-03 20:19 ` [PATCH 1/5] gtk+: enable gtk+-native Laurentiu Palcu
2012-08-03 20:19 ` [PATCH 2/5] sato-icon-theme: make postinst scriplet run at do_rootfs time Laurentiu Palcu
2012-08-06  9:28   ` Burton, Ross
2012-08-03 20:19 ` [PATCH 3/5] package_rpm: export the native directory to the postinst scriptlets Laurentiu Palcu
2012-08-03 20:25   ` Mark Hatle
2012-08-04  7:46     ` Laurentiu Palcu
2012-08-04  8:59       ` Laurentiu Palcu
2012-08-04 14:41         ` Mark Hatle
2012-08-03 20:19 ` [PATCH 4/5] gtk-icon-cache: call postinst scriplet at do_rootfs time Laurentiu Palcu
2012-08-03 23:22   ` Andreas Müller
2012-08-04  7:49     ` Laurentiu Palcu
2012-08-04  9:29       ` Andreas Müller
2012-08-04 14:01         ` Laurentiu Palcu
2012-08-04 17:14           ` Koen Kooi
2012-08-04 19:37             ` Andreas Müller
2012-08-04 19:51               ` Khem Raj
2012-08-04 19:56                 ` Martin Jansa [this message]
2012-08-04 20:25                   ` Andreas Müller
2012-08-05 16:58                 ` Laurentiu Palcu
2012-08-05 22:30                   ` Andreas Müller
2012-08-05 22:49                     ` Andreas Müller
2012-08-06  7:48                       ` Laurentiu Palcu
2012-08-06  8:10                         ` Andreas Müller
2012-08-06  9:18                           ` Laurentiu Palcu
2012-08-06  9:35                             ` Burton, Ross
2012-08-06  9:36                             ` Andreas Müller
2012-08-06 18:50                             ` Andreas Müller
2012-08-05 11:50               ` Koen Kooi
2012-08-04 10:24   ` Koen Kooi
2012-08-03 20:19 ` [PATCH 5/5] gdk-pixbuf: allow postinst scriplet to be called " Laurentiu Palcu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120804195625.GA3267@jama.jama.net \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox