Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: openembedded-commits@lists.openembedded.org
Subject: Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed
Date: Thu, 16 Aug 2012 12:33:08 +0200	[thread overview]
Message-ID: <20120816103308.GA32088@jama.jama.net> (raw)
In-Reply-To: <20120815133202.50B6D10218@opal>

[-- Attachment #1: Type: text/plain, Size: 5971 bytes --]

On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> 
> Author: Jackie Huang <jackie.huang@windriver.com>
> Date:   Thu Aug  9 10:30:30 2012 +0800
> 
> gdk-pixbuf: fix the postinstall script failure when no icon is installed
> 
> If gtk+ is added to core-image-minimal, postinstall script failed on boot:
> 
> Running postinst /etc/rpm-postinsts/104...
> gtk-update-icon-cache: No theme index file.
> ERROR: postinst /etc/rpm-postinsts/104 failed.
> 
> This patch fixed the postinstall script to check for the icon
> file first and not run the gtk-update-icon-cache if no icon
> is installed.
> 
> [YOCTO #2905]
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>


Even with this patch I get:
Configuring gdk-pixbuf-loader-png.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-jpeg.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-xpm.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-gif.
gtk-update-icon-cache: No theme index file.
Collected errors:
 * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.

And even worse on other device, where gtk-update-icon-cache failed with 
Illegal instruction when postinst was executed for first time.. (probably 
because of binutils-2.23)

SHR root@gjama ~ $ gtk-update-icon-cache -q /usr/share/icons/shr/
Illegal instruction

Configuring gdk-pixbuf-loader-png.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-jpeg.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-xpm.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-gif.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Collected errors:
 * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.


> 
> ---
> 
>  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> index 484fb12..159bdae 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> @@ -21,7 +21,7 @@ SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
>  SRC_URI[md5sum] = "72f39b34b20f68148c1609bd27415412"
>  SRC_URI[sha256sum] = "da7a3f00db360913716368e19e336402755cafa93769f3cfa28a969303e4bee1"
>  
> -PR = "r4"
> +PR = "r5"
>  
>  inherit autotools pkgconfig gettext
>  
> @@ -62,7 +62,13 @@ fi
>  
>  GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/${LIBV}/loaders gdk-pixbuf-query-loaders --update-cache
>  
> -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
> +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
> +    for icondir in /usr/share/icons/*; do
> +        if [ -d ${icondir} ]; then
> +            gtk-update-icon-cache -q ${icondir}
> +        fi
> +    done
> +fi
>  }
>  
>  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
> 
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

       reply	other threads:[~2012-08-16 10:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120815133202.50B6D10218@opal>
2012-08-16 10:33 ` Martin Jansa [this message]
2012-08-16 12:42   ` [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed Martin Jansa
2012-08-16 14:30     ` Huang, Jie (Jackie)
2012-08-16 14:35       ` Martin Jansa
2012-08-16 15:06         ` Huang, Jie (Jackie)
2012-08-16 22:02           ` Martin Jansa
2012-08-17  1:48             ` jhuang0
2012-08-17  7:21               ` Burton, Ross
2012-08-17  9:29                 ` jhuang0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120816103308.GA32088@jama.jama.net \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox