Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3340 bytes --]

On Thu, Aug 16, 2012 at 12:33:08PM +0200, Martin Jansa wrote:
> On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> > 
> > Author: Jackie Huang <jackie.huang@windriver.com>
> > Date:   Thu Aug  9 10:30:30 2012 +0800
> > 
> > gdk-pixbuf: fix the postinstall script failure when no icon is installed
> > 
> > If gtk+ is added to core-image-minimal, postinstall script failed on boot:
> > 
> > Running postinst /etc/rpm-postinsts/104...
> > gtk-update-icon-cache: No theme index file.
> > ERROR: postinst /etc/rpm-postinsts/104 failed.
> > 
> > This patch fixed the postinstall script to check for the icon
> > file first and not run the gtk-update-icon-cache if no icon
> > is installed.
> > 
> > [YOCTO #2905]
> > 
> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> 
> 
> Even with this patch I get:
> Configuring gdk-pixbuf-loader-png.
> gtk-update-icon-cache: No theme index file.
> Configuring gdk-pixbuf-loader-jpeg.
> gtk-update-icon-cache: No theme index file.
> Configuring gdk-pixbuf-loader-xpm.
> gtk-update-icon-cache: No theme index file.
> Configuring gdk-pixbuf-loader-gif.
> gtk-update-icon-cache: No theme index file.
> Collected errors:
>  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
>  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
>  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
>  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.

This problem is caused by 
openembedded-core/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
which does not provide index.theme file

and commit message of this change should be something like
gdk-pixbuf: call gtk-update-icon-cache for each subdir of ${datadir}/icons
not
gdk-pixbuf: fix the postinstall script failure when no icon is installed

Cheers,

> > -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
> > +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
> > +    for icondir in /usr/share/icons/*; do
> > +        if [ -d ${icondir} ]; then
> > +            gtk-update-icon-cache -q ${icondir}
> > +        fi
> > +    done
> > +fi
> >  }
> >  
> >  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
> > 
> > 
> > _______________________________________________
> > Openembedded-commits mailing list
> > Openembedded-commits@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com



-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]