Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 5971 bytes --]

On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> 
> Author: Jackie Huang <jackie.huang@windriver.com>
> Date:   Thu Aug  9 10:30:30 2012 +0800
> 
> gdk-pixbuf: fix the postinstall script failure when no icon is installed
> 
> If gtk+ is added to core-image-minimal, postinstall script failed on boot:
> 
> Running postinst /etc/rpm-postinsts/104...
> gtk-update-icon-cache: No theme index file.
> ERROR: postinst /etc/rpm-postinsts/104 failed.
> 
> This patch fixed the postinstall script to check for the icon
> file first and not run the gtk-update-icon-cache if no icon
> is installed.
> 
> [YOCTO #2905]
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>


Even with this patch I get:
Configuring gdk-pixbuf-loader-png.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-jpeg.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-xpm.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-gif.
gtk-update-icon-cache: No theme index file.
Collected errors:
 * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.

And even worse on other device, where gtk-update-icon-cache failed with 
Illegal instruction when postinst was executed for first time.. (probably 
because of binutils-2.23)

SHR root@gjama ~ $ gtk-update-icon-cache -q /usr/share/icons/shr/
Illegal instruction

Configuring gdk-pixbuf-loader-png.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-jpeg.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-xpm.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-gif.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Collected errors:
 * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.


> 
> ---
> 
>  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> index 484fb12..159bdae 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> @@ -21,7 +21,7 @@ SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
>  SRC_URI[md5sum] = "72f39b34b20f68148c1609bd27415412"
>  SRC_URI[sha256sum] = "da7a3f00db360913716368e19e336402755cafa93769f3cfa28a969303e4bee1"
>  
> -PR = "r4"
> +PR = "r5"
>  
>  inherit autotools pkgconfig gettext
>  
> @@ -62,7 +62,13 @@ fi
>  
>  GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/${LIBV}/loaders gdk-pixbuf-query-loaders --update-cache
>  
> -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
> +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
> +    for icondir in /usr/share/icons/*; do
> +        if [ -d ${icondir} ]; then
> +            gtk-update-icon-cache -q ${icondir}
> +        fi
> +    done
> +fi
>  }
>  
>  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
> 
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3340 bytes --]

On Thu, Aug 16, 2012 at 12:33:08PM +0200, Martin Jansa wrote:
> On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> > 
> > Author: Jackie Huang <jackie.huang@windriver.com>
> > Date:   Thu Aug  9 10:30:30 2012 +0800
> > 
> > gdk-pixbuf: fix the postinstall script failure when no icon is installed
> > 
> > If gtk+ is added to core-image-minimal, postinstall script failed on boot:
> > 
> > Running postinst /etc/rpm-postinsts/104...
> > gtk-update-icon-cache: No theme index file.
> > ERROR: postinst /etc/rpm-postinsts/104 failed.
> > 
> > This patch fixed the postinstall script to check for the icon
> > file first and not run the gtk-update-icon-cache if no icon
> > is installed.
> > 
> > [YOCTO #2905]
> > 
> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> 
> 
> Even with this patch I get:
> Configuring gdk-pixbuf-loader-png.
> gtk-update-icon-cache: No theme index file.
> Configuring gdk-pixbuf-loader-jpeg.
> gtk-update-icon-cache: No theme index file.
> Configuring gdk-pixbuf-loader-xpm.
> gtk-update-icon-cache: No theme index file.
> Configuring gdk-pixbuf-loader-gif.
> gtk-update-icon-cache: No theme index file.
> Collected errors:
>  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
>  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
>  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
>  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
>  * returned status 1.
>  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.

This problem is caused by 
openembedded-core/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
which does not provide index.theme file

and commit message of this change should be something like
gdk-pixbuf: call gtk-update-icon-cache for each subdir of ${datadir}/icons
not
gdk-pixbuf: fix the postinstall script failure when no icon is installed

Cheers,

> > -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
> > +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
> > +    for icondir in /usr/share/icons/*; do
> > +        if [ -d ${icondir} ]; then
> > +            gtk-update-icon-cache -q ${icondir}
> > +        fi
> > +    done
> > +fi
> >  }
> >  
> >  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
> > 
> > 
> > _______________________________________________
> > Openembedded-commits mailing list
> > Openembedded-commits@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com



-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Huang, Jie (Jackie)]

>
>On Thu, Aug 16, 2012 at 12:33:08PM +0200, Martin Jansa wrote:
>> On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
>> > Module: openembedded-core.git
>> > Branch: master
>> > Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
>> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
>> >
>> > Author: Jackie Huang <jackie.huang@windriver.com>
>> > Date:   Thu Aug  9 10:30:30 2012 +0800
>> >
>> > gdk-pixbuf: fix the postinstall script failure when no icon is installed
>> >
>> > If gtk+ is added to core-image-minimal, postinstall script failed on boot:
>> >
>> > Running postinst /etc/rpm-postinsts/104...
>> > gtk-update-icon-cache: No theme index file.
>> > ERROR: postinst /etc/rpm-postinsts/104 failed.
>> >
>> > This patch fixed the postinstall script to check for the icon
>> > file first and not run the gtk-update-icon-cache if no icon
>> > is installed.
>> >
>> > [YOCTO #2905]
>> >
>> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>
>>
>> Even with this patch I get:
>> Configuring gdk-pixbuf-loader-png.
>> gtk-update-icon-cache: No theme index file.
>> Configuring gdk-pixbuf-loader-jpeg.
>> gtk-update-icon-cache: No theme index file.
>> Configuring gdk-pixbuf-loader-xpm.
>> gtk-update-icon-cache: No theme index file.
>> Configuring gdk-pixbuf-loader-gif.
>> gtk-update-icon-cache: No theme index file.
>> Collected errors:
>>  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
>>  * returned status 1.
>>  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
>>  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
>>  * returned status 1.
>>  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
>>  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
>>  * returned status 1.
>>  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
>>  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
>>  * returned status 1.
>>  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
>
>This problem is caused by
>openembedded-core/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
>which does not provide index.theme file
>

Well, in my case, there is no icon installed so there is on ${datadir}/icons at all.

Thanks,
Jackie

>and commit message of this change should be something like
>gdk-pixbuf: call gtk-update-icon-cache for each subdir of ${datadir}/icons
>not
>gdk-pixbuf: fix the postinstall script failure when no icon is installed
>
>Cheers,
>
>> > -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
>> > +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
>> > +    for icondir in /usr/share/icons/*; do
>> > +        if [ -d ${icondir} ]; then
>> > +            gtk-update-icon-cache -q ${icondir}
>> > +        fi
>> > +    done
>> > +fi
>> >  }
>> >
>> >  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
>> >
>> >
>> > _______________________________________________
>> > Openembedded-commits mailing list
>> > Openembedded-commits@lists.openembedded.org
>> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
>>
>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
>
>
>--
>Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3978 bytes --]

On Thu, Aug 16, 2012 at 02:30:51PM +0000, Huang, Jie (Jackie) wrote:
> >
> >On Thu, Aug 16, 2012 at 12:33:08PM +0200, Martin Jansa wrote:
> >> On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
> >> > Module: openembedded-core.git
> >> > Branch: master
> >> > Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> >> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> >> >
> >> > Author: Jackie Huang <jackie.huang@windriver.com>
> >> > Date:   Thu Aug  9 10:30:30 2012 +0800
> >> >
> >> > gdk-pixbuf: fix the postinstall script failure when no icon is installed
> >> >
> >> > If gtk+ is added to core-image-minimal, postinstall script failed on boot:
> >> >
> >> > Running postinst /etc/rpm-postinsts/104...
> >> > gtk-update-icon-cache: No theme index file.
> >> > ERROR: postinst /etc/rpm-postinsts/104 failed.
> >> >
> >> > This patch fixed the postinstall script to check for the icon
> >> > file first and not run the gtk-update-icon-cache if no icon
> >> > is installed.
> >> >
> >> > [YOCTO #2905]
> >> >
> >> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> >> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> >>
> >>
> >> Even with this patch I get:
> >> Configuring gdk-pixbuf-loader-png.
> >> gtk-update-icon-cache: No theme index file.
> >> Configuring gdk-pixbuf-loader-jpeg.
> >> gtk-update-icon-cache: No theme index file.
> >> Configuring gdk-pixbuf-loader-xpm.
> >> gtk-update-icon-cache: No theme index file.
> >> Configuring gdk-pixbuf-loader-gif.
> >> gtk-update-icon-cache: No theme index file.
> >> Collected errors:
> >>  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
> >>  * returned status 1.
> >>  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
> >>  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
> >>  * returned status 1.
> >>  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
> >>  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
> >>  * returned status 1.
> >>  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
> >>  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
> >>  * returned status 1.
> >>  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
> >
> >This problem is caused by
> >openembedded-core/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
> >which does not provide index.theme file
> >
> 
> Well, in my case, there is no icon installed so there is on ${datadir}/icons at all.

So it's fine to break postinst for everyone else who has
xcursor-transparent-theme or are you going to fix that?

Thanks,

> 
> Thanks,
> Jackie
> 
> >and commit message of this change should be something like
> >gdk-pixbuf: call gtk-update-icon-cache for each subdir of ${datadir}/icons
> >not
> >gdk-pixbuf: fix the postinstall script failure when no icon is installed
> >
> >Cheers,
> >
> >> > -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
> >> > +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
> >> > +    for icondir in /usr/share/icons/*; do
> >> > +        if [ -d ${icondir} ]; then
> >> > +            gtk-update-icon-cache -q ${icondir}
> >> > +        fi
> >> > +    done
> >> > +fi
> >> >  }
> >> >
> >> >  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
> >> >
> >> >
> >> > _______________________________________________
> >> > Openembedded-commits mailing list
> >> > Openembedded-commits@lists.openembedded.org
> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
> >>
> >> --
> >> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >
> >
> >
> >--
> >Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Huang, Jie (Jackie)]

>
>On Thu, Aug 16, 2012 at 02:30:51PM +0000, Huang, Jie (Jackie) wrote:
>> >
>> >On Thu, Aug 16, 2012 at 12:33:08PM +0200, Martin Jansa wrote:
>> >> On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
>> >> > Module: openembedded-core.git
>> >> > Branch: master
>> >> > Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
>> >> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
>> >> >
>> >> > Author: Jackie Huang <jackie.huang@windriver.com>
>> >> > Date:   Thu Aug  9 10:30:30 2012 +0800
>> >> >
>> >> > gdk-pixbuf: fix the postinstall script failure when no icon is installed
>> >> >
>> >> > If gtk+ is added to core-image-minimal, postinstall script failed on boot:
>> >> >
>> >> > Running postinst /etc/rpm-postinsts/104...
>> >> > gtk-update-icon-cache: No theme index file.
>> >> > ERROR: postinst /etc/rpm-postinsts/104 failed.
>> >> >
>> >> > This patch fixed the postinstall script to check for the icon
>> >> > file first and not run the gtk-update-icon-cache if no icon
>> >> > is installed.
>> >> >
>> >> > [YOCTO #2905]
>> >> >
>> >> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> >> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> >>
>> >>
>> >> Even with this patch I get:
>> >> Configuring gdk-pixbuf-loader-png.
>> >> gtk-update-icon-cache: No theme index file.
>> >> Configuring gdk-pixbuf-loader-jpeg.
>> >> gtk-update-icon-cache: No theme index file.
>> >> Configuring gdk-pixbuf-loader-xpm.
>> >> gtk-update-icon-cache: No theme index file.
>> >> Configuring gdk-pixbuf-loader-gif.
>> >> gtk-update-icon-cache: No theme index file.
>> >> Collected errors:
>> >>  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
>> >>  * returned status 1.
>> >>  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
>> >>  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
>> >>  * returned status 1.
>> >>  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
>> >>  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
>> >>  * returned status 1.
>> >>  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
>> >>  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
>> >>  * returned status 1.
>> >>  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
>> >
>> >This problem is caused by
>> >openembedded-core/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
>> >which does not provide index.theme file
>> >
>>
>> Well, in my case, there is no icon installed so there is on ${datadir}/icons at all.
>
>So it's fine to break postinst for everyone else who has

This fix is for the case when there is no icon/theme installed. When we found the bug,
the postinst was calling the gtk-update-icon-cache for the hicolor theme which is not installed.

>xcursor-transparent-theme or are you going to fix that?

For xcursor-transparent-theme not providing the index.theme file, yeah it's really a problem,
I can fix that, but maybe we should open another bug for it?

Thanks,
Jackie

>
>Thanks,
>
>>
>> Thanks,
>> Jackie
>>
>> >and commit message of this change should be something like
>> >gdk-pixbuf: call gtk-update-icon-cache for each subdir of ${datadir}/icons
>> >not
>> >gdk-pixbuf: fix the postinstall script failure when no icon is installed
>> >
>> >Cheers,
>> >
>> >> > -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
>> >> > +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
>> >> > +    for icondir in /usr/share/icons/*; do
>> >> > +        if [ -d ${icondir} ]; then
>> >> > +            gtk-update-icon-cache -q ${icondir}
>> >> > +        fi
>> >> > +    done
>> >> > +fi
>> >> >  }
>> >> >
>> >> >  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
>> >> >
>> >> >
>> >> > _______________________________________________
>> >> > Openembedded-commits mailing list
>> >> > Openembedded-commits@lists.openembedded.org
>> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
>> >>
>> >> --
>> >> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>> >
>> >
>> >
>> >--
>> >Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>> >
>
>--
>Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 5226 bytes --]

On Thu, Aug 16, 2012 at 03:06:35PM +0000, Huang, Jie (Jackie) wrote:
> >
> >On Thu, Aug 16, 2012 at 02:30:51PM +0000, Huang, Jie (Jackie) wrote:
> >> >
> >> >On Thu, Aug 16, 2012 at 12:33:08PM +0200, Martin Jansa wrote:
> >> >> On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
> >> >> > Module: openembedded-core.git
> >> >> > Branch: master
> >> >> > Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> >> >> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> >> >> >
> >> >> > Author: Jackie Huang <jackie.huang@windriver.com>
> >> >> > Date:   Thu Aug  9 10:30:30 2012 +0800
> >> >> >
> >> >> > gdk-pixbuf: fix the postinstall script failure when no icon is installed
> >> >> >
> >> >> > If gtk+ is added to core-image-minimal, postinstall script failed on boot:
> >> >> >
> >> >> > Running postinst /etc/rpm-postinsts/104...
> >> >> > gtk-update-icon-cache: No theme index file.
> >> >> > ERROR: postinst /etc/rpm-postinsts/104 failed.
> >> >> >
> >> >> > This patch fixed the postinstall script to check for the icon
> >> >> > file first and not run the gtk-update-icon-cache if no icon
> >> >> > is installed.
> >> >> >
> >> >> > [YOCTO #2905]
> >> >> >
> >> >> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> >> >> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> >> >>
> >> >>
> >> >> Even with this patch I get:
> >> >> Configuring gdk-pixbuf-loader-png.
> >> >> gtk-update-icon-cache: No theme index file.
> >> >> Configuring gdk-pixbuf-loader-jpeg.
> >> >> gtk-update-icon-cache: No theme index file.
> >> >> Configuring gdk-pixbuf-loader-xpm.
> >> >> gtk-update-icon-cache: No theme index file.
> >> >> Configuring gdk-pixbuf-loader-gif.
> >> >> gtk-update-icon-cache: No theme index file.
> >> >> Collected errors:
> >> >>  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
> >> >>  * returned status 1.
> >> >>  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
> >> >>  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
> >> >>  * returned status 1.
> >> >>  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
> >> >>  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
> >> >>  * returned status 1.
> >> >>  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
> >> >>  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
> >> >>  * returned status 1.
> >> >>  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
> >> >
> >> >This problem is caused by
> >> >openembedded-core/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
> >> >which does not provide index.theme file
> >> >
> >>
> >> Well, in my case, there is no icon installed so there is on ${datadir}/icons at all.
> >
> >So it's fine to break postinst for everyone else who has
> 
> This fix is for the case when there is no icon/theme installed. When we found the bug,
> the postinst was calling the gtk-update-icon-cache for the hicolor theme which is not installed.

Yes, but you could also execute it only if hicolor exists or add
hicolor-icon-theme to RDEPENDS, executing gtk-update-icon-cache for each
subdirectory is not what I would expect from that commit message.

> >xcursor-transparent-theme or are you going to fix that?
> 
> For xcursor-transparent-theme not providing the index.theme file, yeah it's really a problem,
> I can fix that, but maybe we should open another bug for it?

And do we need to call gtk-update-icon-cache in
xcursor-transparent-theme or in any other directory which happens to be
in ${datadir}/icons? Why not call it only for subdirs with index.theme?

> Thanks,
> Jackie
> 
> >
> >Thanks,
> >
> >>
> >> Thanks,
> >> Jackie
> >>
> >> >and commit message of this change should be something like
> >> >gdk-pixbuf: call gtk-update-icon-cache for each subdir of ${datadir}/icons
> >> >not
> >> >gdk-pixbuf: fix the postinstall script failure when no icon is installed
> >> >
> >> >Cheers,
> >> >
> >> >> > -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
> >> >> > +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
> >> >> > +    for icondir in /usr/share/icons/*; do
> >> >> > +        if [ -d ${icondir} ]; then
> >> >> > +            gtk-update-icon-cache -q ${icondir}
> >> >> > +        fi
> >> >> > +    done
> >> >> > +fi
> >> >> >  }
> >> >> >
> >> >> >  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
> >> >> >
> >> >> >
> >> >> > _______________________________________________
> >> >> > Openembedded-commits mailing list
> >> >> > Openembedded-commits@lists.openembedded.org
> >> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
> >> >>
> >> >> --
> >> >> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >> >
> >> >
> >> >
> >> >--
> >> >Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >> >
> >
> >--
> >Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[jhuang0]

On 8/17/2012 6:02 AM, Martin Jansa wrote:
> On Thu, Aug 16, 2012 at 03:06:35PM +0000, Huang, Jie (Jackie) wrote:
>>>
>>> On Thu, Aug 16, 2012 at 02:30:51PM +0000, Huang, Jie (Jackie) wrote:
>>>>>
>>>>> On Thu, Aug 16, 2012 at 12:33:08PM +0200, Martin Jansa wrote:
>>>>>> On Wed, Aug 15, 2012 at 01:32:02PM +0000, git@git.openembedded.org wrote:
>>>>>>> Module: openembedded-core.git
>>>>>>> Branch: master
>>>>>>> Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
>>>>>>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
>>>>>>>
>>>>>>> Author: Jackie Huang <jackie.huang@windriver.com>
>>>>>>> Date:   Thu Aug  9 10:30:30 2012 +0800
>>>>>>>
>>>>>>> gdk-pixbuf: fix the postinstall script failure when no icon is installed
>>>>>>>
>>>>>>> If gtk+ is added to core-image-minimal, postinstall script failed on boot:
>>>>>>>
>>>>>>> Running postinst /etc/rpm-postinsts/104...
>>>>>>> gtk-update-icon-cache: No theme index file.
>>>>>>> ERROR: postinst /etc/rpm-postinsts/104 failed.
>>>>>>>
>>>>>>> This patch fixed the postinstall script to check for the icon
>>>>>>> file first and not run the gtk-update-icon-cache if no icon
>>>>>>> is installed.
>>>>>>>
>>>>>>> [YOCTO #2905]
>>>>>>>
>>>>>>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>>>>>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>>>>>
>>>>>>
>>>>>> Even with this patch I get:
>>>>>> Configuring gdk-pixbuf-loader-png.
>>>>>> gtk-update-icon-cache: No theme index file.
>>>>>> Configuring gdk-pixbuf-loader-jpeg.
>>>>>> gtk-update-icon-cache: No theme index file.
>>>>>> Configuring gdk-pixbuf-loader-xpm.
>>>>>> gtk-update-icon-cache: No theme index file.
>>>>>> Configuring gdk-pixbuf-loader-gif.
>>>>>> gtk-update-icon-cache: No theme index file.
>>>>>> Collected errors:
>>>>>>   * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
>>>>>>   * returned status 1.
>>>>>>   * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
>>>>>>   * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
>>>>>>   * returned status 1.
>>>>>>   * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
>>>>>>   * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
>>>>>>   * returned status 1.
>>>>>>   * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
>>>>>>   * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
>>>>>>   * returned status 1.
>>>>>>   * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
>>>>>
>>>>> This problem is caused by
>>>>> openembedded-core/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
>>>>> which does not provide index.theme file
>>>>>
>>>>
>>>> Well, in my case, there is no icon installed so there is on ${datadir}/icons at all.
>>>
>>> So it's fine to break postinst for everyone else who has
>>
>> This fix is for the case when there is no icon/theme installed. When we found the bug,
>> the postinst was calling the gtk-update-icon-cache for the hicolor theme which is not installed.
>
> Yes, but you could also execute it only if hicolor exists or add
> hicolor-icon-theme to RDEPENDS, executing gtk-update-icon-cache for each

I had considered to add RDEPENDS, it's simple and it works but we had 
another consider that in some cases we may not need any theme. So we 
decided to change the postinst, while doing that, I thought it may not 
be a good idea to only executing gtk-update-icon-cache for hicolor since 
there maybe othere themes installed.

> subdirectory is not what I would expect from that commit message.

If it is the case, I'm fine to change it back to executing it only for 
hicolor if it exists.

>
>>> xcursor-transparent-theme or are you going to fix that?
>>
>> For xcursor-transparent-theme not providing the index.theme file, yeah it's really a problem,
>> I can fix that, but maybe we should open another bug for it?
>
> And do we need to call gtk-update-icon-cache in
> xcursor-transparent-theme or in any other directory which happens to be
> in ${datadir}/icons? Why not call it only for subdirs with index.theme?

Yeah, it would be better for the postinstall script, but for 
xcursor-transparent-theme without index.theme file, is it still a problem?

Mark, what do think about this?

Thanks,
Jackie

>
>> Thanks,
>> Jackie
>>
>>>
>>> Thanks,
>>>
>>>>
>>>> Thanks,
>>>> Jackie
>>>>
>>>>> and commit message of this change should be something like
>>>>> gdk-pixbuf: call gtk-update-icon-cache for each subdir of ${datadir}/icons
>>>>> not
>>>>> gdk-pixbuf: fix the postinstall script failure when no icon is installed
>>>>>
>>>>> Cheers,
>>>>>
>>>>>>> -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
>>>>>>> +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
>>>>>>> +    for icondir in /usr/share/icons/*; do
>>>>>>> +        if [ -d ${icondir} ]; then
>>>>>>> +            gtk-update-icon-cache -q ${icondir}
>>>>>>> +        fi
>>>>>>> +    done
>>>>>>> +fi
>>>>>>>   }
>>>>>>>
>>>>>>>   PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Openembedded-commits mailing list
>>>>>>> Openembedded-commits@lists.openembedded.org
>>>>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
>>>>>>
>>>>>> --
>>>>>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>>>>
>>>
>>> --
>>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>>
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Burton, Ross]

On 17 August 2012 02:48, jhuang0 <jackie.huang@windriver.com> wrote:
> Yeah, it would be better for the postinstall script, but for
> xcursor-transparent-theme without index.theme file, is it still a problem?

Running gtk-update-icon-cache doesn't make sense on themes without an
index.theme, because without an index.theme there are not any icons to
cache (xcursor themes are different).  From the man page:

"It expects to be given the path to a icon theme directory containing
an index.theme, e.g.  /usr/share/icons/hicolor, and writes a
icon-theme.cache containing cached information about the icons in the
directory tree below the given directory."

Use -t to gtk-update-icon-cache, or filter the list of directories to
only include ones with index.theme files.  Either is appropriate.

Ross

Re: [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[jhuang0]

On 8/17/2012 3:21 PM, Burton, Ross wrote:
> On 17 August 2012 02:48, jhuang0 <jackie.huang@windriver.com> wrote:
>> Yeah, it would be better for the postinstall script, but for
>> xcursor-transparent-theme without index.theme file, is it still a problem?
>
> Running gtk-update-icon-cache doesn't make sense on themes without an
> index.theme, because without an index.theme there are not any icons to

I see, so themes without an index.theme is not an issue, postinstall 
script should handle this case, I will change to call 
gtk-update-icon-cache only for themes with index.theme just as Martin's 
suggestion.

Thanks,
Jackie

> cache (xcursor themes are different).  From the man page:
>
> "It expects to be given the path to a icon theme directory containing
> an index.theme, e.g.  /usr/share/icons/hicolor, and writes a
> icon-theme.cache containing cached information about the icons in the
> directory tree below the given directory."
>
> Use -t to gtk-update-icon-cache, or filter the list of directories to
> only include ones with index.theme files.  Either is appropriate.
>
> Ross
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745