[PATCH 0/2] Add more tunes for new ARM processors Cortex-A15 and Cortex-A7

[PATCH 0/2] Add more tunes for new ARM processors Cortex-A15 and Cortex-A7

[Denys Dmytriyenko]

From: Denys Dmytriyenko <denys@ti.com>

The patchset adds 2 more standard tune files for the new ARM MPCore (multicore)
processors Cortex-A15 and Cortex-A7, as per:

http://www.arm.com/products/processors/cortex-a/cortex-a15.php
http://www.arm.com/products/processors/cortex-a/cortex-a7.php

Denys Dmytriyenko (2):
  tune-cortexa15: add tunes for ARM Cortex-A15
  tune-cortexa7: add tunes for ARM Cortex-A7

 meta/conf/machine/include/tune-cortexa15.inc | 24 ++++++++++++++++++++++++
 meta/conf/machine/include/tune-cortexa7.inc  | 24 ++++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa15.inc
 create mode 100644 meta/conf/machine/include/tune-cortexa7.inc

-- 
1.7.12.3

[PATCH 1/2] tune-cortexa15: add tunes for ARM Cortex-A15

[Denys Dmytriyenko]

From: Denys Dmytriyenko <denys@ti.com>

http://www.arm.com/products/processors/cortex-a/cortex-a15.php

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta/conf/machine/include/tune-cortexa15.inc | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa15.inc

diff --git a/meta/conf/machine/include/tune-cortexa15.inc b/meta/conf/machine/include/tune-cortexa15.inc
new file mode 100644
index 0000000..690e934
--- /dev/null
+++ b/meta/conf/machine/include/tune-cortexa15.inc
@@ -0,0 +1,24 @@
+DEFAULTTUNE ?= "cortexa15-neon"
+
+require conf/machine/include/arm/arch-armv7a.inc
+
+TUNEVALID[cortexa15] = "Enable Cortex-A15 specific processor optimizations"
+TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa15", "-mtune=cortex-a15", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa15 cortexa15t cortexa15-neon"
+TUNE_FEATURES_tune-cortexa15 = "${TUNE_FEATURES_tune-armv7a} cortexa15"
+TUNE_FEATURES_tune-cortexa15t = "${TUNE_FEATURES_tune-armv7at} cortexa15"
+TUNE_FEATURES_tune-cortexa15-neon = "${TUNE_FEATURES_tune-armv7a-neon} cortexa15"
+PACKAGE_EXTRA_ARCHS_tune-cortexa15 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa15t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa15-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
+
+# VFP Tunes
+AVAILTUNES += "cortexa15hf cortexa15thf cortexa15hf-neon"
+TUNE_FEATURES_tune-cortexa15hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa15"
+TUNE_FEATURES_tune-cortexa15thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa15"
+TUNE_FEATURES_tune-cortexa15hf-neon ?= "${TUNE_FEATURES_tune-armv7ahf-neon} cortexa15"
+PACKAGE_EXTRA_ARCHS_tune-cortexa15hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa15thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa15hf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf-neon}"
-- 
1.7.12.3

[PATCH 2/2] tune-cortexa7: add tunes for ARM Cortex-A7

[Denys Dmytriyenko]

From: Denys Dmytriyenko <denys@ti.com>

http://www.arm.com/products/processors/cortex-a/cortex-a7.php

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta/conf/machine/include/tune-cortexa7.inc | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa7.inc

diff --git a/meta/conf/machine/include/tune-cortexa7.inc b/meta/conf/machine/include/tune-cortexa7.inc
new file mode 100644
index 0000000..8e41139
--- /dev/null
+++ b/meta/conf/machine/include/tune-cortexa7.inc
@@ -0,0 +1,24 @@
+DEFAULTTUNE ?= "cortexa7-neon"
+
+require conf/machine/include/arm/arch-armv7a.inc
+
+TUNEVALID[cortexa7] = "Enable Cortex-A7 specific processor optimizations"
+TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa7", "-mtune=cortex-a7", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa7 cortexa7t cortexa7-neon"
+TUNE_FEATURES_tune-cortexa7 = "${TUNE_FEATURES_tune-armv7a} cortexa7"
+TUNE_FEATURES_tune-cortexa7t = "${TUNE_FEATURES_tune-armv7at} cortexa7"
+TUNE_FEATURES_tune-cortexa7-neon = "${TUNE_FEATURES_tune-armv7a-neon} cortexa7"
+PACKAGE_EXTRA_ARCHS_tune-cortexa7 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa7t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa7-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon}"
+
+# VFP Tunes
+AVAILTUNES += "cortexa7hf cortexa7thf cortexa7hf-neon"
+TUNE_FEATURES_tune-cortexa7hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa7"
+TUNE_FEATURES_tune-cortexa7thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa7"
+TUNE_FEATURES_tune-cortexa7hf-neon ?= "${TUNE_FEATURES_tune-armv7ahf-neon} cortexa7"
+PACKAGE_EXTRA_ARCHS_tune-cortexa7hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa7thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa7hf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf-neon}"
-- 
1.7.12.3

Re: [PATCH 0/2] Add more tunes for new ARM processors Cortex-A15 and Cortex-A7

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

On Thu, Oct 18, 2012 at 06:51:56PM -0400, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@ti.com>
> 
> The patchset adds 2 more standard tune files for the new ARM MPCore (multicore)
> processors Cortex-A15 and Cortex-A7, as per:
> 
> http://www.arm.com/products/processors/cortex-a/cortex-a15.php
> http://www.arm.com/products/processors/cortex-a/cortex-a7.php

Please check this patchset 
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-October/030759.html

> 
> Denys Dmytriyenko (2):
>   tune-cortexa15: add tunes for ARM Cortex-A15
>   tune-cortexa7: add tunes for ARM Cortex-A7
> 
>  meta/conf/machine/include/tune-cortexa15.inc | 24 ++++++++++++++++++++++++
>  meta/conf/machine/include/tune-cortexa7.inc  | 24 ++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-cortexa15.inc
>  create mode 100644 meta/conf/machine/include/tune-cortexa7.inc
> 
> -- 
> 1.7.12.3
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 0/2] Add more tunes for new ARM processors Cortex-A15 and Cortex-A7

[Denys Dmytriyenko]

On Fri, Oct 19, 2012 at 10:44:32AM +0200, Martin Jansa wrote:
> On Thu, Oct 18, 2012 at 06:51:56PM -0400, Denys Dmytriyenko wrote:
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > The patchset adds 2 more standard tune files for the new ARM MPCore (multicore)
> > processors Cortex-A15 and Cortex-A7, as per:
> > 
> > http://www.arm.com/products/processors/cortex-a/cortex-a15.php
> > http://www.arm.com/products/processors/cortex-a/cortex-a7.php
> 
> Please check this patchset 
> http://lists.linuxtogo.org/pipermail/openembedded-core/2012-October/030759.html

Yes, I've seen that patchset. Unfortunately it's still in the queue and is 
going through implementation iterations. Once it gets into OE-Core, I'd be 
happy to update my tune files with the corresponding ARMPKGARCH and 
DEFAULTTUNE changes. But I don't think that tune rework patchset should block 
new tune files, as they don't break anything and adhere to the existing 
framework. Thanks.

-- 
Denys


> > Denys Dmytriyenko (2):
> >   tune-cortexa15: add tunes for ARM Cortex-A15
> >   tune-cortexa7: add tunes for ARM Cortex-A7
> > 
> >  meta/conf/machine/include/tune-cortexa15.inc | 24 ++++++++++++++++++++++++
> >  meta/conf/machine/include/tune-cortexa7.inc  | 24 ++++++++++++++++++++++++
> >  2 files changed, 48 insertions(+)
> >  create mode 100644 meta/conf/machine/include/tune-cortexa15.inc
> >  create mode 100644 meta/conf/machine/include/tune-cortexa7.inc
> > 
> > -- 
> > 1.7.12.3
> > 
> > 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: [PATCH 0/2] Add more tunes for new ARM processors Cortex-A15 and Cortex-A7

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]

On Fri, Oct 19, 2012 at 12:56:16PM -0400, Denys Dmytriyenko wrote:
> On Fri, Oct 19, 2012 at 10:44:32AM +0200, Martin Jansa wrote:
> > On Thu, Oct 18, 2012 at 06:51:56PM -0400, Denys Dmytriyenko wrote:
> > > From: Denys Dmytriyenko <denys@ti.com>
> > > 
> > > The patchset adds 2 more standard tune files for the new ARM MPCore (multicore)
> > > processors Cortex-A15 and Cortex-A7, as per:
> > > 
> > > http://www.arm.com/products/processors/cortex-a/cortex-a15.php
> > > http://www.arm.com/products/processors/cortex-a/cortex-a7.php
> > 
> > Please check this patchset 
> > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-October/030759.html
> 
> Yes, I've seen that patchset. Unfortunately it's still in the queue and is 
> going through implementation iterations. Once it gets into OE-Core, I'd be 

Nobody commented on last iteration (except of acks from khem). So I
don't plan to send another one.


> happy to update my tune files with the corresponding ARMPKGARCH and 
> DEFAULTTUNE changes. But I don't think that tune rework patchset should block 
> new tune files, as they don't break anything and adhere to the existing 
> framework. Thanks.

Your new tune files wont work if that patchset is applied, that's why I
commented on them.

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 0/2] Add more tunes for new ARM processors Cortex-A15 and Cortex-A7

[Richard Purdie]

On Fri, 2012-10-19 at 21:38 +0200, Martin Jansa wrote:
> On Fri, Oct 19, 2012 at 12:56:16PM -0400, Denys Dmytriyenko wrote:
> > On Fri, Oct 19, 2012 at 10:44:32AM +0200, Martin Jansa wrote:
> > > On Thu, Oct 18, 2012 at 06:51:56PM -0400, Denys Dmytriyenko wrote:
> > > > From: Denys Dmytriyenko <denys@ti.com>
> > > > 
> > > > The patchset adds 2 more standard tune files for the new ARM MPCore (multicore)
> > > > processors Cortex-A15 and Cortex-A7, as per:
> > > > 
> > > > http://www.arm.com/products/processors/cortex-a/cortex-a15.php
> > > > http://www.arm.com/products/processors/cortex-a/cortex-a7.php
> > > 
> > > Please check this patchset 
> > > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-October/030759.html
> > 
> > Yes, I've seen that patchset. Unfortunately it's still in the queue and is 
> > going through implementation iterations. Once it gets into OE-Core, I'd be 
> 
> Nobody commented on last iteration (except of acks from khem). So I
> don't plan to send another one.

It was made clear that we were concentrating on the release and these
were something we'd come back to afterwards. I also made it very clear
that I'm opposed to something that is repeatedly getting proposed here.
Lets just say it is unlikely I will simply change my mind if people keep
sending it.

I'm trying to get to the point of reviewing the patches that need
attention and give more constructive feedback having cleared the less
problematic ones out the way and shortened the backlog but I'm not there
yet. Ideally I'd like to take a break entirely but sadly that simply
isn't going to happen :(. I'll try and get to these as soon as I can but
there is a substantial queue. 

I'd also point out I'm getting considerable "feedback" as soon as
anything goes into master that destabilises the build so when anything
does merge, fixing fallout is taking priority too.

Cheers,

Richard

Re: [PATCH 0/2] Add more tunes for new ARM processors Cortex-A15 and Cortex-A7

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2761 bytes --]

On Fri, Oct 19, 2012 at 11:36:58PM +0100, Richard Purdie wrote:
> On Fri, 2012-10-19 at 21:38 +0200, Martin Jansa wrote:
> > On Fri, Oct 19, 2012 at 12:56:16PM -0400, Denys Dmytriyenko wrote:
> > > On Fri, Oct 19, 2012 at 10:44:32AM +0200, Martin Jansa wrote:
> > > > On Thu, Oct 18, 2012 at 06:51:56PM -0400, Denys Dmytriyenko wrote:
> > > > > From: Denys Dmytriyenko <denys@ti.com>
> > > > > 
> > > > > The patchset adds 2 more standard tune files for the new ARM MPCore (multicore)
> > > > > processors Cortex-A15 and Cortex-A7, as per:
> > > > > 
> > > > > http://www.arm.com/products/processors/cortex-a/cortex-a15.php
> > > > > http://www.arm.com/products/processors/cortex-a/cortex-a7.php
> > > > 
> > > > Please check this patchset 
> > > > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-October/030759.html
> > > 
> > > Yes, I've seen that patchset. Unfortunately it's still in the queue and is 
> > > going through implementation iterations. Once it gets into OE-Core, I'd be 
> > 
> > Nobody commented on last iteration (except of acks from khem). So I
> > don't plan to send another one.
> 
> It was made clear that we were concentrating on the release and these
> were something we'd come back to afterwards. I also made it very clear

I'm not complaining that it wasn't merged yet, just saying that it
should be considered for merging before adding more tune files to fix.

> that I'm opposed to something that is repeatedly getting proposed here.
> Lets just say it is unlikely I will simply change my mind if people keep
> sending it.

AFAIK You were against OPTDEFAULTTUNE and that's not used in last
iteration. Last iteration just defines different PKGARCH for different 
CCARGS as you said:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=1916#c6

> I'm trying to get to the point of reviewing the patches that need
> attention and give more constructive feedback having cleared the less
> problematic ones out the way and shortened the backlog but I'm not there
> yet. Ideally I'd like to take a break entirely but sadly that simply
> isn't going to happen :(. I'll try and get to these as soon as I can but
> there is a substantial queue. 
> 
> I'd also point out I'm getting considerable "feedback" as soon as
> anything goes into master that destabilises the build so when anything
> does merge, fixing fallout is taking priority too.

Yes that's why I'm reporting that fallout as soon as it's merged when
it's something I haven't noticed when patch was on ML. And I know that
you're often the one who fixes it in the end when commiter does not even
reply on those reports, thanks for doing that.

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]