Re: [oe-commits] Kang Kai : perl: update dependency creating script

Re: [oe-commits] Kang Kai : perl: update dependency creating script

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2400 bytes --]

On Mon, Jan 07, 2013 at 11:36:03AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 35291c97edc05756788d206457c56dcc41edb637
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=35291c97edc05756788d206457c56dcc41edb637
> 
> Author: Kang Kai <kai.kang@windriver.com>
> Date:   Mon Nov  5 10:42:00 2012 +0800
> 
> perl: update dependency creating script
> 
> Base on dependency create script provided by Saul, I update it with:
> 1 remove document strings in perl module files that may import fake
>   dependencies.
> 
> 2 not all the 'use' or 'require' clauses start at the begin of line, and
>   some of them don't end with ';', such as:
> 
> use vars qw(
>             $AUTOLOAD
> 	    ...
> 
> 3 filter some strings that they are not real dependencies: some of them
>   are wrong result of script, some are conditional use/require, and some
>   are cpan extra modules that we don't need.
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>

This breaks parsing when 
http://patchwork.openembedded.org/patch/40997/
is used.

Parsing recipes...ERROR: There is a confusing multiline, partially commented expression on line 10 of file /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc (| sed "s/\/.*\.pm: */ += /g;s/[\"\']//g;s/;.*/\"/g;s/+= .*\(require\|use\)\> */+= \"perl-module-/g;s/CPANPLUS::.*/cpanplus/g;s/CPAN::.*/cpan/g;s/::/-/g;s/ [^+\"].*//g;s/_/-/g;s/\.pl\"$/\"/;s/\"\?\$/\"/;s/(//;" | tr [:upper:] [:lower:] \).
Please clarify whether this is all a comment or should be parsed.
ERROR: Unable to parse /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl_5.14.2.bb: Exited with "1"
ERROR: Command execution failed: Exited with 1

> 
> ---
> 
>  .../recipes-devtools/perl/perl-rdepends_5.14.2.inc | 2336 +++++++++++++++++++-
>  1 files changed, 2287 insertions(+), 49 deletions(-)
> 
> Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=35291c97edc05756788d206457c56dcc41edb637
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Kang Kai : perl: update dependency creating script

[Kang Kai]

On 2013年01月07日 20:29, Martin Jansa wrote:
> On Mon, Jan 07, 2013 at 11:36:03AM +0000, git@git.openembedded.org wrote:
>> Module: openembedded-core.git
>> Branch: master
>> Commit: 35291c97edc05756788d206457c56dcc41edb637
>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=35291c97edc05756788d206457c56dcc41edb637
>>
>> Author: Kang Kai<kai.kang@windriver.com>
>> Date:   Mon Nov  5 10:42:00 2012 +0800
>>
>> perl: update dependency creating script
>>
>> Base on dependency create script provided by Saul, I update it with:
>> 1 remove document strings in perl module files that may import fake
>>    dependencies.
>>
>> 2 not all the 'use' or 'require' clauses start at the begin of line, and
>>    some of them don't end with ';', such as:
>>
>> use vars qw(
>>              $AUTOLOAD
>> 	    ...
>>
>> 3 filter some strings that they are not real dependencies: some of them
>>    are wrong result of script, some are conditional use/require, and some
>>    are cpan extra modules that we don't need.
>>
>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
> This breaks parsing when
> http://patchwork.openembedded.org/patch/40997/
> is used.
>
> Parsing recipes...ERROR: There is a confusing multiline, partially commented expression on line 10 of file /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc (| sed "s/\/.*\.pm: */ += /g;s/[\"\']//g;s/;.*/\"/g;s/+= .*\(require\|use\)\>  */+= \"perl-module-/g;s/CPANPLUS::.*/cpanplus/g;s/CPAN::.*/cpan/g;s/::/-/g;s/ [^+\"].*//g;s/_/-/g;s/\.pl\"$/\"/;s/\"\?\$/\"/;s/(//;" | tr [:upper:] [:lower:] \).
> Please clarify whether this is all a comment or should be parsed.
> ERROR: Unable to parse /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl_5.14.2.bb: Exited with "1"
> ERROR: Command execution failed: Exited with 1

Hi Jansa,

Because my boy was born, I have been leaving office and missed this message.
Thanks for you fix.

Regards,
Kai

>
>> ---
>>
>>   .../recipes-devtools/perl/perl-rdepends_5.14.2.inc | 2336 +++++++++++++++++++-
>>   1 files changed, 2287 insertions(+), 49 deletions(-)
>>
>> Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=35291c97edc05756788d206457c56dcc41edb637
>>
>> _______________________________________________
>> Openembedded-commits mailing list
>> Openembedded-commits@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

Re: [oe-commits] Kang Kai : perl: update dependency creating script

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2785 bytes --]

On Mon, Jan 14, 2013 at 11:02:45AM +0800, Kang Kai wrote:
> On 2013年01月07日 20:29, Martin Jansa wrote:
> > On Mon, Jan 07, 2013 at 11:36:03AM +0000, git@git.openembedded.org wrote:
> >> Module: openembedded-core.git
> >> Branch: master
> >> Commit: 35291c97edc05756788d206457c56dcc41edb637
> >> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=35291c97edc05756788d206457c56dcc41edb637
> >>
> >> Author: Kang Kai<kai.kang@windriver.com>
> >> Date:   Mon Nov  5 10:42:00 2012 +0800
> >>
> >> perl: update dependency creating script
> >>
> >> Base on dependency create script provided by Saul, I update it with:
> >> 1 remove document strings in perl module files that may import fake
> >>    dependencies.
> >>
> >> 2 not all the 'use' or 'require' clauses start at the begin of line, and
> >>    some of them don't end with ';', such as:
> >>
> >> use vars qw(
> >>              $AUTOLOAD
> >> 	    ...
> >>
> >> 3 filter some strings that they are not real dependencies: some of them
> >>    are wrong result of script, some are conditional use/require, and some
> >>    are cpan extra modules that we don't need.
> >>
> >> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> >> Signed-off-by: Saul Wold<sgw@linux.intel.com>
> > This breaks parsing when
> > http://patchwork.openembedded.org/patch/40997/
> > is used.
> >
> > Parsing recipes...ERROR: There is a confusing multiline, partially commented expression on line 10 of file /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc (| sed "s/\/.*\.pm: */ += /g;s/[\"\']//g;s/;.*/\"/g;s/+= .*\(require\|use\)\>  */+= \"perl-module-/g;s/CPANPLUS::.*/cpanplus/g;s/CPAN::.*/cpan/g;s/::/-/g;s/ [^+\"].*//g;s/_/-/g;s/\.pl\"$/\"/;s/\"\?\$/\"/;s/(//;" | tr [:upper:] [:lower:] \).
> > Please clarify whether this is all a comment or should be parsed.
> > ERROR: Unable to parse /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl_5.14.2.bb: Exited with "1"
> > ERROR: Command execution failed: Exited with 1
> 
> Hi Jansa,
> 
> Because my boy was born, I have been leaving office and missed this message.

np, congratz!

Cheers,

> >
> >> ---
> >>
> >>   .../recipes-devtools/perl/perl-rdepends_5.14.2.inc | 2336 +++++++++++++++++++-
> >>   1 files changed, 2287 insertions(+), 49 deletions(-)
> >>
> >> Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=35291c97edc05756788d206457c56dcc41edb637
> >>
> >> _______________________________________________
> >> Openembedded-commits mailing list
> >> Openembedded-commits@lists.openembedded.org
> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Kang Kai : perl: update dependency creating script

[Kang Kai]

On 2013年01月14日 16:14, Martin Jansa wrote:
> On Mon, Jan 14, 2013 at 11:02:45AM +0800, Kang Kai wrote:
>> On 2013年01月07日 20:29, Martin Jansa wrote:
>>> On Mon, Jan 07, 2013 at 11:36:03AM +0000, git@git.openembedded.org wrote:
>>>> Module: openembedded-core.git
>>>> Branch: master
>>>> Commit: 35291c97edc05756788d206457c56dcc41edb637
>>>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=35291c97edc05756788d206457c56dcc41edb637
>>>>
>>>> Author: Kang Kai<kai.kang@windriver.com>
>>>> Date:   Mon Nov  5 10:42:00 2012 +0800
>>>>
>>>> perl: update dependency creating script
>>>>
>>>> Base on dependency create script provided by Saul, I update it with:
>>>> 1 remove document strings in perl module files that may import fake
>>>>     dependencies.
>>>>
>>>> 2 not all the 'use' or 'require' clauses start at the begin of line, and
>>>>     some of them don't end with ';', such as:
>>>>
>>>> use vars qw(
>>>>               $AUTOLOAD
>>>> 	    ...
>>>>
>>>> 3 filter some strings that they are not real dependencies: some of them
>>>>     are wrong result of script, some are conditional use/require, and some
>>>>     are cpan extra modules that we don't need.
>>>>
>>>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
>>>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>>> This breaks parsing when
>>> http://patchwork.openembedded.org/patch/40997/
>>> is used.
>>>
>>> Parsing recipes...ERROR: There is a confusing multiline, partially commented expression on line 10 of file /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc (| sed "s/\/.*\.pm: */ += /g;s/[\"\']//g;s/;.*/\"/g;s/+= .*\(require\|use\)\>   */+= \"perl-module-/g;s/CPANPLUS::.*/cpanplus/g;s/CPAN::.*/cpan/g;s/::/-/g;s/ [^+\"].*//g;s/_/-/g;s/\.pl\"$/\"/;s/\"\?\$/\"/;s/(//;" | tr [:upper:] [:lower:] \).
>>> Please clarify whether this is all a comment or should be parsed.
>>> ERROR: Unable to parse /OE/shr-core/openembedded-core/meta/recipes-devtools/perl/perl_5.14.2.bb: Exited with "1"
>>> ERROR: Command execution failed: Exited with 1
>> Hi Jansa,
>>
>> Because my boy was born, I have been leaving office and missed this message.
> np, congratz!

Thank you!

Regards,
Kai

>
> Cheers,
>
>>>> ---
>>>>
>>>>    .../recipes-devtools/perl/perl-rdepends_5.14.2.inc | 2336 +++++++++++++++++++-
>>>>    1 files changed, 2287 insertions(+), 49 deletions(-)
>>>>
>>>> Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=35291c97edc05756788d206457c56dcc41edb637
>>>>
>>>> _______________________________________________
>>>> Openembedded-commits mailing list
>>>> Openembedded-commits@lists.openembedded.org
>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits