From: Peter Seebach <peter.seebach@windriver.com>
To: Constantin Musca <constantinx.musca@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] pseudo: fix sqlite path and package missing files
Date: Tue, 5 Feb 2013 13:15:55 -0600 [thread overview]
Message-ID: <20130205131555.46c685fb@e6410-2> (raw)
In-Reply-To: <5110B6CE.1050504@intel.com>
On Tue, 5 Feb 2013 09:37:50 +0200
Constantin Musca <constantinx.musca@intel.com> wrote:
> On 02/05/2013 01:50 AM, Peter Seebach wrote:
> > On Mon, 4 Feb 2013 23:37:59 +0000
> > Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> >
> >> Agreed. Can someone send me a patch which makes it all work
> >> please? :)
> > I probably can. I think the 1.4.3 patch I sent out recently (sgw was
> > looking at it, but the binaries weren't up on the downloads server
> > yet) probably covers most of it, but not the case where
> > sqlite-libdir isn't lib, which is probably (??) a target-only case.
> >
> > Can someone show me a test case where it fails, so I can add that
> > to my pile of pseudo test cases, and then stare at it for a while?
> >
> > -s
> Here's a test case:
> 1. local.conf:
> MACHINE = "qemux86-64"
> require conf/multilib.conf
> MULTILIBS = "multilib:lib32"
> DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
>
> 2. build pseudo
*pulls off mask, revealing he was the pseudo maintainer all along*
And I would have gotten away with it, too, if it hadn't been for you
meddling multilibs!
Okay, got a tentative fix for this in my tree, will probably resend my
pseudo 1.4.3 patch with this changed, once it makes it through my
ever-growing collection of pseudo tests.
The guts of the change:
[...]
+SQLITE_LIB = "${baselib}"
+SQLITE_LIB_native = "lib"
+
# Compile for the local machine arch...
do_compile () {
if [ "${SITEINFO_BITS}" = "64" ]; then
- ${S}/configure --prefix=${prefix} --libdir=${prefix}/lib/pseudo/lib${SITEINFO_BITS} --with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}" --bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath
+ ${S}/configure --prefix=${prefix} --libdir=${prefix}/lib/pseudo/lib${SITEINFO_BITS} --with-sqlite-lib=${SQLITE_LIB} --with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}" --bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath
else
This appears to be working for all the cases I've tried.
-s
--
Listen, get this. Nobody with a good compiler needs to be justified.
next prev parent reply other threads:[~2013-02-05 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 11:33 [PATCH] pseudo: fix sqlite path and package missing files Constantin Musca
2013-02-04 18:23 ` Peter Seebach
2013-02-04 23:21 ` Richard Purdie
2013-02-04 23:27 ` Peter Seebach
2013-02-04 23:37 ` Richard Purdie
2013-02-04 23:50 ` Peter Seebach
2013-02-05 7:37 ` Constantin Musca
2013-02-05 19:15 ` Peter Seebach [this message]
2013-02-05 19:37 ` Saul Wold
2013-02-05 19:46 ` Peter Seebach
2013-02-05 20:09 ` Peter Seebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205131555.46c685fb@e6410-2 \
--to=peter.seebach@windriver.com \
--cc=constantinx.musca@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox