wpa-supplicant postinsts failing without sysvinit in DISTRO_FEATURES

wpa-supplicant postinsts failing without sysvinit in DISTRO_FEATURES

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

oe-core/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc

defines pkg_postinst_wpa-supplicant
with:
        if [ "x$DBUSPID" != "x" ]; then
                /etc/init.d/dbus-1 reload || true
        fi

and /etc/init.d/dbus-1 is missing without sysvinit in DISTRO_FEATURES

Thanks to "true" it doesn't fail completely, but if the goal is no
warnings in images then errors should be fixed too :)

Configuring wpa-supplicant.
//var/lib/opkg/info/wpa-supplicant.postinst: line 9: /etc/init.d/dbus-1:
//No such file or directory

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: wpa-supplicant postinsts failing without sysvinit in DISTRO_FEATURES

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

On Fri, Apr 12, 2013 at 04:20:15PM +0200, Martin Jansa wrote:
> oe-core/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc

the same is in avahi.inc (pkg_postinst_avahi-daemon)

> 
> defines pkg_postinst_wpa-supplicant
> with:
>         if [ "x$DBUSPID" != "x" ]; then
>                 /etc/init.d/dbus-1 reload || true
>         fi
> 
> and /etc/init.d/dbus-1 is missing without sysvinit in DISTRO_FEATURES
> 
> Thanks to "true" it doesn't fail completely, but if the goal is no
> warnings in images then errors should be fixed too :)
> 
> Configuring wpa-supplicant.
> //var/lib/opkg/info/wpa-supplicant.postinst: line 9: /etc/init.d/dbus-1:
> //No such file or directory
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com



-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: wpa-supplicant postinsts failing without sysvinit in DISTRO_FEATURES

[Burton, Ross]

On 12 April 2013 15:20, Martin Jansa <martin.jansa@gmail.com> wrote:
> oe-core/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
>
> defines pkg_postinst_wpa-supplicant
> with:
>         if [ "x$DBUSPID" != "x" ]; then
>                 /etc/init.d/dbus-1 reload || true
>         fi
>
> and /etc/init.d/dbus-1 is missing without sysvinit in DISTRO_FEATURES
>
> Thanks to "true" it doesn't fail completely, but if the goal is no
> warnings in images then errors should be fixed too :)

We're going to see stuff like this a lot - clearly we need some
abstraction over this.  One-off for dbus, or a general-purpose small
abstraction over invoking systemctl or init scripts?

Ross

Re: wpa-supplicant postinsts failing without sysvinit in DISTRO_FEATURES

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Fri, Apr 12, 2013 at 03:24:57PM +0100, Burton, Ross wrote:
> On 12 April 2013 15:20, Martin Jansa <martin.jansa@gmail.com> wrote:
> > oe-core/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
> >
> > defines pkg_postinst_wpa-supplicant
> > with:
> >         if [ "x$DBUSPID" != "x" ]; then
> >                 /etc/init.d/dbus-1 reload || true
> >         fi
> >
> > and /etc/init.d/dbus-1 is missing without sysvinit in DISTRO_FEATURES
> >
> > Thanks to "true" it doesn't fail completely, but if the goal is no
> > warnings in images then errors should be fixed too :)
> 
> We're going to see stuff like this a lot - clearly we need some
> abstraction over this.  One-off for dbus, or a general-purpose small
> abstraction over invoking systemctl or init scripts?

I have noticed this when testing upgrade paths, but general-purpose
abstraction will became quite complicated in images which have both
sysvinit and systemd scripts (I guess that checking which init is
running will be needed to decide if /etc/init.d/foo or systemctl should be
called :/).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: wpa-supplicant postinsts failing without sysvinit in DISTRO_FEATURES

[Burton, Ross]

On 12 April 2013 15:43, Martin Jansa <martin.jansa@gmail.com> wrote:
> I have noticed this when testing upgrade paths, but general-purpose
> abstraction will became quite complicated in images which have both
> sysvinit and systemd scripts (I guess that checking which init is
> running will be needed to decide if /etc/init.d/foo or systemctl should be
> called :/).

Something along the lines of

  if which systemctl && test -d /run/systemd/system

should do the job.  Checking that directory exists is how
libsystemd-daemon determines if systemd is active or not, so if it's
good enough for them it's good enough for us.

Ross