Re: [oe-commits] Andy Voltz : tune-cortexa.inc: create a common include for cortex-a armv7a tuning

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2865 bytes --]

On Sat, Jun 08, 2013 at 11:10:20AM +0200, Martin Jansa wrote:
> On Fri, Jun 07, 2013 at 03:43:57PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 3e4f4a1cf07ff7cf4c71566492385f8fbf581789
> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=3e4f4a1cf07ff7cf4c71566492385f8fbf581789
> > 
> > Author: Andy Voltz <andy.voltz@timesys.com>
> > Date:   Wed Jun  5 11:52:29 2013 -0400
> > 
> > tune-cortexa.inc: create a common include for cortex-a armv7a tuning
> > 
> > The tuning files for the cortex-a* processors are mostly identical for
> > the A7,A8,A9,A15 processors. Rework these files to use a CORTEX_ID
> > variable to setup the tuning for each specific processor.
> > 
> > Signed-off-by: Andy Voltz <andy.voltz@timesys.com>
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> 
> Something is wrong with this one:
> 
> ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
>     Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
>     Following is the list of potential problems / advisories:
> 
>     Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH (${ARMPKGARCH_tune-cortexa8t-neon}).Toolchain tunings invalid:
> Tuning 'cortexa8t-neon' has no defined features, and cannot be used.
> 
> ERROR: Execution of event handler 'check_sanity_eventhandler' failed
> 
> Please use tests like
> http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
> to check that all tunes are still valid after such change.

Also it was using -mtune and documentation talks about -mtune, but
actual tune-cortexa.inc is using -mcpu, this change wasn't mentioned in
commit message and I don't think it's improvement.

> > 
> > ---
> > 
> >  meta/conf/machine/include/arm/README         |    3 ++
> >  meta/conf/machine/include/tune-cortexa.inc   |   35 ++++++++++++++++++++++++++
> >  meta/conf/machine/include/tune-cortexa15.inc |   35 +------------------------
> >  meta/conf/machine/include/tune-cortexa7.inc  |   35 +------------------------
> >  meta/conf/machine/include/tune-cortexa8.inc  |   35 +------------------------
> >  meta/conf/machine/include/tune-cortexa9.inc  |   35 +------------------------
> >  6 files changed, 46 insertions(+), 132 deletions(-)
> > 
> > Diff:   http://git.openembedded.org/?p=openembedded-core.git/?a=commitdiff;h=3e4f4a1cf07ff7cf4c71566492385f8fbf581789
> > _______________________________________________
> > Openembedded-commits mailing list
> > Openembedded-commits@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-commits
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com



-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]