Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andy Voltz <andy.voltz@timesys.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: "openembedded-commits@lists.openembedded.org"
	<openembedded-commits@lists.openembedded.org>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [oe-commits] Andy Voltz : tune-cortexa.inc: create a common include for cortex-a armv7a tuning
Date: Mon, 10 Jun 2013 11:50:44 -0400	[thread overview]
Message-ID: <20130610155044.GS17357@timesys.com> (raw)
In-Reply-To: <20130608091556.GP22710@jama>

Hi Martin,

> On Sat, Jun 08, 2013 at 11:10:20AM +0200, Martin Jansa wrote:

> > Something is wrong with this one:
> > 
> > ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
> >     Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
> >     Following is the list of potential problems / advisories:
> > 
> >     Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH (${ARMPKGARCH_tune-cortexa8t-neon}).Toolchain tunings invalid:
> > Tuning 'cortexa8t-neon' has no defined features, and cannot be used.
> > 
> > ERROR: Execution of event handler 'check_sanity_eventhandler' failed
> > 
> > Please use tests like
> > http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune2-test
> > to check that all tunes are still valid after such change.
> 

I was not aware of this test. I'll look into this.

> Also it was using -mtune and documentation talks about -mtune, but
> actual tune-cortexa.inc is using -mcpu, this change wasn't mentioned in
> commit message and I don't think it's improvement.
> 

*facepalm*

This is actually my mistake when I squashed my cortex-a5 file into a general
cortexa file. I meant to keep the -mtune in place. I started out using mcpu
before realizing mtune was also valid for cortex-a5.

I have a patch to revert that change / go back to -mtune. I will send it after
I rebuild for cortex-a5.

Sorry about that. It didn't come out because the build was happy with -mcpu=cortex-a5
-- 
Andy Voltz
Timesys Corporation


  reply	other threads:[~2013-06-10 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130607154357.606025038F@opal>
2013-06-08  9:10 ` [oe-commits] Andy Voltz : tune-cortexa.inc: create a common include for cortex-a armv7a tuning Martin Jansa
2013-06-08  9:15   ` Martin Jansa
2013-06-10 15:50     ` Andy Voltz [this message]
2013-06-11  4:12       ` Khem Raj
2013-06-11 13:45         ` Andy Voltz
2013-06-11 15:01           ` Khem Raj
2013-06-12 16:13             ` Andy Voltz
2013-06-12 16:17               ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130610155044.GS17357@timesys.com \
    --to=andy.voltz@timesys.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox