* [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools
@ 2013-07-31 21:15 ronunes
2013-08-01 1:16 ` Otavio Salvador
2013-08-01 9:50 ` Burton, Ross
0 siblings, 2 replies; 5+ messages in thread
From: ronunes @ 2013-07-31 21:15 UTC (permalink / raw)
To: openembedded-core; +Cc: Rogerio Nunes
From: Rogerio Nunes <rogerio.nunes@freescale.com>
This patch groups x11 dependent tools in a separete variable,
and when DISTRO_FEATURES does not contain x11, this group is
not included in the package RDEPENDS.
Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
---
.../packagegroup-core-tools-testapps.bb | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
index 343ae1c..1861ebe 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
@@ -24,24 +24,28 @@ KEXECTOOLS_powerpc ?= ""
KEXECTOOLS_e5500-64b ?= ""
KEXECTOOLS_aarch64 ?= ""
+X11TOOLS = "\
+ fstests \
+ owl-video \
+ mesa-demos \
+ x11perf \
+ xrestop \
+ xwininfo \
+ xprop \
+ xvideo-tests \
+ "
+
RDEPENDS_${PN} = "\
blktool \
- fstests \
tslib-calibrate \
tslib-tests \
lrzsz \
${KEXECTOOLS} \
alsa-utils-amixer \
alsa-utils-aplay \
- owl-video \
gst-meta-video \
gst-meta-audio \
- mesa-demos \
- x11perf \
- xrestop \
- xwininfo \
- xprop \
- xvideo-tests \
ltp \
connman-client \
+ ${@base_contains('DISTRO_FEATURES', 'x11', "${X11TOOLS}", "", d)} \
"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools
2013-07-31 21:15 [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools ronunes
@ 2013-08-01 1:16 ` Otavio Salvador
2013-08-01 9:50 ` Burton, Ross
1 sibling, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2013-08-01 1:16 UTC (permalink / raw)
To: Rogerio Nunes
Cc: Rogerio Nunes, Patches and discussions about the oe-core layer
On Wed, Jul 31, 2013 at 6:15 PM, <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> This patch groups x11 dependent tools in a separete variable,
> and when DISTRO_FEATURES does not contain x11, this group is
> not included in the package RDEPENDS.
>
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools
2013-07-31 21:15 [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools ronunes
2013-08-01 1:16 ` Otavio Salvador
@ 2013-08-01 9:50 ` Burton, Ross
2013-08-01 10:41 ` Martin Jansa
1 sibling, 1 reply; 5+ messages in thread
From: Burton, Ross @ 2013-08-01 9:50 UTC (permalink / raw)
To: ronunes; +Cc: Rogerio Nunes, openembedded-core
On 31 July 2013 22:15, <ronunes@gmail.com> wrote:
> + mesa-demos \
If no x11 distro feature then mesa shouldn't be linking against X, so
mesa-demos won't, so this should work, right?
Ross
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools
2013-08-01 9:50 ` Burton, Ross
@ 2013-08-01 10:41 ` Martin Jansa
2013-08-01 10:45 ` Burton, Ross
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2013-08-01 10:41 UTC (permalink / raw)
To: Burton, Ross; +Cc: Rogerio Nunes, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
On Thu, Aug 01, 2013 at 10:50:28AM +0100, Burton, Ross wrote:
> On 31 July 2013 22:15, <ronunes@gmail.com> wrote:
> > + mesa-demos \
>
> If no x11 distro feature then mesa shouldn't be linking against X, so
> mesa-demos won't, so this should work, right?
mesa-demos need glew and glew needs virtual/libx11
Unfortunately mesa-demos autoconf stuff doesn't allow to disable demos
which are depending on glew, we're using ugly hacks to remove glew
dependency and build mesa-demos only with few demos available without
x11 in DISTRO_FEATURES (only egl subdir).
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools
2013-08-01 10:41 ` Martin Jansa
@ 2013-08-01 10:45 ` Burton, Ross
0 siblings, 0 replies; 5+ messages in thread
From: Burton, Ross @ 2013-08-01 10:45 UTC (permalink / raw)
To: Martin Jansa; +Cc: Rogerio Nunes, openembedded-core
On 1 August 2013 11:41, Martin Jansa <martin.jansa@gmail.com> wrote:
>> If no x11 distro feature then mesa shouldn't be linking against X, so
>> mesa-demos won't, so this should work, right?
>
> mesa-demos need glew and glew needs virtual/libx11
>
> Unfortunately mesa-demos autoconf stuff doesn't allow to disable demos
> which are depending on glew, we're using ugly hacks to remove glew
> dependency and build mesa-demos only with few demos available without
> x11 in DISTRO_FEATURES (only egl subdir).
Damn, oh well. --without-glew is something to push upstream correctly
one day then.
Ross
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-01 10:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 21:15 [master, dylan][PATCH] packagegroup-core-tools-testapps: isolate x11 dependent tools ronunes
2013-08-01 1:16 ` Otavio Salvador
2013-08-01 9:50 ` Burton, Ross
2013-08-01 10:41 ` Martin Jansa
2013-08-01 10:45 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox