[PATCH 0/3] RFC: few commits for a new machine feature: v4l2

[PATCH 0/3] RFC: few commits for a new machine feature: v4l2

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

Here are few commits to add a new machine feature, v4l2. These commits
provide:

* A new recipe which provides tools to poke v4l2 config on the target
* a new machine feature: v4l2 which brings a set of related packages.
* modification to gst-meta-base recipe, to enable the v4l2 gstreamer
  plugins, when the v4l2 machine features is enabled.

With this, one can easily enable a v4l2 video device on any BSP. This
v4l2 support will also be used by the upcoming hardware accelerated
encoding support for BSPs.

I am sending these commits as "Request for comments" for now, but I also
see that these are complete enough to pull in the oecore layer.

Thanks,
Nitin


The following changes since commit f63e7f4323368c0d6fe7a1d44393a7e15652d4f2:

  subversion: Add patch to use neon 0.30 (2013-08-07 07:43:47 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib nitin/misc
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=nitin/misc

Nitin A Kamble (3):
  v4l-utils: a new recipe
  packagegroup-base.bb: add a new machine feature: v4l2
  gst-meta-base: bring in the v4l2 related gst plugin

 .../packagegroups/packagegroup-base.bb             |  8 +++++
 .../gstreamer/gst-meta-base_0.10.bb                |  4 ++-
 meta/recipes-multimedia/v4lapps/v4l-utils_1.0.0.bb | 35 ++++++++++++++++++++++
 3 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-multimedia/v4lapps/v4l-utils_1.0.0.bb

-- 
1.8.1.4

[PATCH 1/3] v4l-utils: a new recipe

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

The v4l-utils recipe provides v4l2-ctl and other tools, which help in
understanding the configuration needed by v4l2 devices like a camera.

This recipe is imported from meta-oe layer, and then updated
and modified to work with the newest version.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-multimedia/v4lapps/v4l-utils_1.0.0.bb | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 meta/recipes-multimedia/v4lapps/v4l-utils_1.0.0.bb

diff --git a/meta/recipes-multimedia/v4lapps/v4l-utils_1.0.0.bb b/meta/recipes-multimedia/v4lapps/v4l-utils_1.0.0.bb
new file mode 100644
index 0000000..738e3ca
--- /dev/null
+++ b/meta/recipes-multimedia/v4lapps/v4l-utils_1.0.0.bb
@@ -0,0 +1,35 @@
+DESCRIPTION = "v4l2 and IR applications"
+LICENSE = "GPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=48da9957849056017dc568bbc43d8975 \
+                    file://COPYING.libv4l;md5=d749e86a105281d7a44c2328acebc4b0"
+
+PR = "r0"
+
+DEPENDS = "jpeg"
+
+inherit autotools gettext
+
+# libv4l was absorbed into this, let OE know that
+PROVIDES = "libv4l"
+
+SRC_URI = "http://linuxtv.org/downloads/v4l-utils/v4l-utils-1.0.0.tar.bz2"
+
+SRC_URI[md5sum] = "2127f2d06be9162b0d346f7037a9e852"
+SRC_URI[sha256sum] = "1de3882099e04e89e354675ee408b82c8ac8afd3ca6ab27ea321771901285f30"
+
+EXTRA_OECONF = "--disable-qv4l2 --enable-shared"
+
+do_configure() {
+    # autotools_do_configure fails with:
+    # | configure.ac:139: error: required file 'build-aux/config.rpath' not found
+    autoreconf -vfi
+    oe_runconf
+}
+
+PACKAGES =+ "rc-keymaps libv4l-dbg libv4l libv4l-dev"
+
+FILES_rc-keymaps = "${sysconfdir}/rc* ${base_libdir}/udev/rc*"
+FILES_${PN} = "${bindir} ${sbindir} ${base_libdir}/udev/rules.d/70-infrared.rules"
+FILES_libv4l += "${libdir}/libv4l/* ${libdir}/*.so.*"
+FILES_libv4l-dbg += "${libdir}/libv4l/.debug ${libdir}/libv4l/plugins/.debug"
+FILES_libv4l-dev += "${libdir}/*.so ${includedir}/lib* ${libdir}/pkgconfig/lib*"
-- 
1.8.1.4

[PATCH 2/3] packagegroup-base.bb: add a new machine feature: v4l2

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

This new machine feature gives a choice to add the video for linux 2
drivers and related utilities to BSPs.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-core/packagegroups/packagegroup-base.bb | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 1c0c757..839c400 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -24,6 +24,7 @@ PACKAGES = ' \
             ${@base_contains("MACHINE_FEATURES", "serial", "packagegroup-base-serial", "", d)} \
             ${@base_contains("MACHINE_FEATURES", "usbgadget", "packagegroup-base-usbgadget", "", d)} \
             ${@base_contains("MACHINE_FEATURES", "usbhost", "packagegroup-base-usbhost", "", d)} \
+            ${@base_contains("MACHINE_FEATURES", "v4l2", "packagegroup-base-v4l2", "", d)} \
             \
             ${@base_contains("DISTRO_FEATURES", "bluetooth", "packagegroup-base-bluetooth", "", d)} \
             ${@base_contains("DISTRO_FEATURES", "wifi", "packagegroup-base-wifi", "", d)} \
@@ -60,6 +61,7 @@ RDEPENDS_packagegroup-base = "\
     ${@base_contains('MACHINE_FEATURES', 'acpi', 'packagegroup-base-acpi', '',d)} \
     ${@base_contains('MACHINE_FEATURES', 'keyboard', 'packagegroup-base-keyboard', '',d)} \
     ${@base_contains('MACHINE_FEATURES', 'phone', 'packagegroup-base-phone', '',d)} \
+    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'packagegroup-base-v4l2', '',d)} \
     \
     ${@base_contains('COMBINED_FEATURES', 'alsa', 'packagegroup-base-alsa', '',d)} \
     ${@base_contains('COMBINED_FEATURES', 'ext2', 'packagegroup-base-ext2', '',d)} \
@@ -355,6 +357,12 @@ SUMMARY_packagegroup-base-zeroconf = "Zeroconf support"
 RDEPENDS_packagegroup-base-zeroconf = "\
     avahi-daemon"
 
+SUMMARY_packagegroup-base-v4l2 = "Video for Linux 2 support"
+RDEPENDS_packagegroup-base-v4l2 = "\
+    kernel-module-v4l2-int-device \
+    kernel-module-v4l2-common \
+    v4l-utils"
+
 SUMMARY_packagegroup-base-ipv6 = "IPv6 support"
 RDEPENDS_packagegroup-base-ipv6 = "\
     "
-- 
1.8.1.4

[PATCH 3/3] gst-meta-base: bring in the v4l2 related gst plugin

[nitin.a.kamble]

From: Nitin A Kamble <nitin.a.kamble@intel.com>

If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
is also pulled in the gst-meta-base packages.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
index 210da37..c1139f4 100644
--- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
@@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
     gst-plugins-base-videoscale \
     gst-plugins-base-ffmpegcolorspace \
     gst-plugins-good-autodetect \
-    gst-plugins-good-souphttpsrc"
+    gst-plugins-good-souphttpsrc \
+    gst-plugins-base-videotestsrc \
+    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-video4linux2', '', d)}"
 
 RRECOMMENDS_gst-meta-x11-base = "\
     gst-plugins-base-ximagesink \
-- 
1.8.1.4

Re: [PATCH 3/3] gst-meta-base: bring in the v4l2 related gst plugin

[Otavio Salvador]

On Thu, Aug 8, 2013 at 6:34 PM,  <nitin.a.kamble@intel.com> wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> is also pulled in the gst-meta-base packages.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> index 210da37..c1139f4 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
>      gst-plugins-base-videoscale \
>      gst-plugins-base-ffmpegcolorspace \
>      gst-plugins-good-autodetect \
> -    gst-plugins-good-souphttpsrc"
> +    gst-plugins-good-souphttpsrc \
> +    gst-plugins-base-videotestsrc \

videotestsrc is not related to this change.

> +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-video4linux2', '', d)}"
>
>  RRECOMMENDS_gst-meta-x11-base = "\
>      gst-plugins-base-ximagesink \
> --
> 1.8.1.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH 3/3] gst-meta-base: bring in the v4l2 related gst plugin

[Kamble, Nitin A]

> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Thursday, August 08, 2013 2:57 PM
> To: Kamble, Nitin A
> Cc: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 3/3] gst-meta-base: bring in the v4l2 related
> gst plugin
> 
> On Thu, Aug 8, 2013 at 6:34 PM,  <nitin.a.kamble@intel.com> wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> > is also pulled in the gst-meta-base packages.
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > index 210da37..c1139f4 100644
> > --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
> >      gst-plugins-base-videoscale \
> >      gst-plugins-base-ffmpegcolorspace \
> >      gst-plugins-good-autodetect \
> > -    gst-plugins-good-souphttpsrc"
> > +    gst-plugins-good-souphttpsrc \
> > +    gst-plugins-base-videotestsrc \
> 
> videotestsrc is not related to this change.
> 


Thanks for the feedback Otavio. I need it for the encoding support. So I will move it in a separate commit instead.

Nitin

> > +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-
> video4linux2', '', d)}"
> >
> >  RRECOMMENDS_gst-meta-x11-base = "\
> >      gst-plugins-base-ximagesink \
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH 3/3] gst-meta-base: bring in the v4l2 related gst plugin

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

On Thu, Aug 08, 2013 at 09:34:29PM +0000, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> is also pulled in the gst-meta-base packages.
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> index 210da37..c1139f4 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
>      gst-plugins-base-videoscale \
>      gst-plugins-base-ffmpegcolorspace \
>      gst-plugins-good-autodetect \
> -    gst-plugins-good-souphttpsrc"
> +    gst-plugins-good-souphttpsrc \
> +    gst-plugins-base-videotestsrc \
> +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-video4linux2', '', d)}"

I was expecting to see PACKAGECONFIG somewhere, is v4l2 autodetected?

Why not keep v4l2-utils in meta-multimedia?

>  
>  RRECOMMENDS_gst-meta-x11-base = "\
>      gst-plugins-base-ximagesink \
> -- 
> 1.8.1.4
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 3/3] gst-meta-base: bring in the v4l2 related gst plugin

[Kamble, Nitin A]

> -----Original Message-----
> From: Martin Jansa [mailto:martin.jansa@gmail.com]
> Sent: Thursday, August 08, 2013 3:37 PM
> To: Kamble, Nitin A
> Cc: Openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 3/3] gst-meta-base: bring in the v4l2 related
> gst plugin
> 
> On Thu, Aug 08, 2013 at 09:34:29PM +0000, nitin.a.kamble@intel.com wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> > is also pulled in the gst-meta-base packages.
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > index 210da37..c1139f4 100644
> > --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
> >      gst-plugins-base-videoscale \
> >      gst-plugins-base-ffmpegcolorspace \
> >      gst-plugins-good-autodetect \
> > -    gst-plugins-good-souphttpsrc"
> > +    gst-plugins-good-souphttpsrc \
> > +    gst-plugins-base-videotestsrc \
> > +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-
> video4linux2', '', d)}"
> 
> I was expecting to see PACKAGECONFIG somewhere, is v4l2 autodetected?

There are PACKAGECONFIG definitions for v4l in meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc & meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb in oecore, which controls building of the v4l2 plugin. And I see it is built even when v4l is not listed in PACKAGECONFIG var, so looks like it is autodetected.

But the above change is to make sure that the v4l2 plugins gets pulled in the image.
> 
> Why not keep v4l2-utils in meta-multimedia?
Because of the general availability of accelerated encoding in processors, many BSPs can include the accelerated encoding support. Also because the gstreamers plugin for v4l2 is in oecore, so oecore will be ideal location for v4l-utils.

Thanks,
Nitin


> 
> >
> >  RRECOMMENDS_gst-meta-x11-base = "\
> >      gst-plugins-base-ximagesink \
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com