* [PATCH/RFC] autotools: handle dependency on intltool-native
@ 2013-09-23 8:06 Eric Bénard
2013-09-23 11:24 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Eric Bénard @ 2013-09-23 8:06 UTC (permalink / raw)
To: openembedded-core
autotools' class can use intltoolize but has no dependency on it
which can leads to :
/test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found
This patch fix this problem by adding the dependency on
intltool-native which can be tricky as it triggers
circular dependencies very easily.
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
meta/classes/autotools.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index 883eb06..eb988cb 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
and not bb.data.inherits_class('cross', d) \
and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
deps += 'libtool-cross '
+ deps += 'intltool-native '
return deps + 'gnu-config-native '
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] autotools: handle dependency on intltool-native
2013-09-23 8:06 [PATCH/RFC] autotools: handle dependency on intltool-native Eric Bénard
@ 2013-09-23 11:24 ` Richard Purdie
2013-09-23 11:53 ` Eric Bénard
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2013-09-23 11:24 UTC (permalink / raw)
To: Eric Bénard; +Cc: openembedded-core
On Mon, 2013-09-23 at 10:06 +0200, Eric Bénard wrote:
> autotools' class can use intltoolize but has no dependency on it
> which can leads to :
> /test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found
>
> This patch fix this problem by adding the dependency on
> intltool-native which can be tricky as it triggers
> circular dependencies very easily.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> meta/classes/autotools.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> index 883eb06..eb988cb 100644
> --- a/meta/classes/autotools.bbclass
> +++ b/meta/classes/autotools.bbclass
> @@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
> and not bb.data.inherits_class('cross', d) \
> and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
> deps += 'libtool-cross '
> + deps += 'intltool-native '
>
> return deps + 'gnu-config-native '
Its expected that recipes using that add to DEPENDS. Please lets not add
in the dependency for everyone since it isn't actually used in that many
places. Its small details like this which end up causing significant
performance issues :/.
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] autotools: handle dependency on intltool-native
2013-09-23 11:24 ` Richard Purdie
@ 2013-09-23 11:53 ` Eric Bénard
2013-09-23 14:34 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Eric Bénard @ 2013-09-23 11:53 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
Le Mon, 23 Sep 2013 12:24:17 +0100,
Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :
> On Mon, 2013-09-23 at 10:06 +0200, Eric Bénard wrote:
> > autotools' class can use intltoolize but has no dependency on it
> > which can leads to :
> > /test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found
> >
> > This patch fix this problem by adding the dependency on
> > intltool-native which can be tricky as it triggers
> > circular dependencies very easily.
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > ---
> > meta/classes/autotools.bbclass | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> > index 883eb06..eb988cb 100644
> > --- a/meta/classes/autotools.bbclass
> > +++ b/meta/classes/autotools.bbclass
> > @@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
> > and not bb.data.inherits_class('cross', d) \
> > and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
> > deps += 'libtool-cross '
> > + deps += 'intltool-native '
> >
> > return deps + 'gnu-config-native '
>
> Its expected that recipes using that add to DEPENDS. Please lets not add
> in the dependency for everyone since it isn't actually used in that many
> places. Its small details like this which end up causing significant
> performance issues :/.
>
OK agreed. Would you accept a patch to add this in comment in
autotools.bbclass so that this gets documented somewhere ?
Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] autotools: handle dependency on intltool-native
2013-09-23 11:53 ` Eric Bénard
@ 2013-09-23 14:34 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2013-09-23 14:34 UTC (permalink / raw)
To: Eric Bénard; +Cc: openembedded-core
On Mon, 2013-09-23 at 13:53 +0200, Eric Bénard wrote:
> Le Mon, 23 Sep 2013 12:24:17 +0100,
> Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :
>
> > On Mon, 2013-09-23 at 10:06 +0200, Eric Bénard wrote:
> > > autotools' class can use intltoolize but has no dependency on it
> > > which can leads to :
> > > /test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found
> > >
> > > This patch fix this problem by adding the dependency on
> > > intltool-native which can be tricky as it triggers
> > > circular dependencies very easily.
> > >
> > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > ---
> > > meta/classes/autotools.bbclass | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> > > index 883eb06..eb988cb 100644
> > > --- a/meta/classes/autotools.bbclass
> > > +++ b/meta/classes/autotools.bbclass
> > > @@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
> > > and not bb.data.inherits_class('cross', d) \
> > > and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
> > > deps += 'libtool-cross '
> > > + deps += 'intltool-native '
> > >
> > > return deps + 'gnu-config-native '
> >
> > Its expected that recipes using that add to DEPENDS. Please lets not add
> > in the dependency for everyone since it isn't actually used in that many
> > places. Its small details like this which end up causing significant
> > performance issues :/.
> >
> OK agreed. Would you accept a patch to add this in comment in
> autotools.bbclass so that this gets documented somewhere ?
Yes.
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-23 14:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 8:06 [PATCH/RFC] autotools: handle dependency on intltool-native Eric Bénard
2013-09-23 11:24 ` Richard Purdie
2013-09-23 11:53 ` Eric Bénard
2013-09-23 14:34 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox