Re: [oe-commits] Richard Purdie : gcc: Fix strange C++ repo issues

Re: [oe-commits] Richard Purdie : gcc: Fix strange C++ repo issues

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

On Mon, Oct 14, 2013 at 03:45:35PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
> 
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> Date:   Wed Oct  9 20:37:49 2013 +0000
> 
> gcc: Fix strange C++ repo issues
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> ---
> 
>  meta/recipes-devtools/gcc/gcc-4.8.inc              |    1 +
>  .../gcc/gcc-4.8/0047-repomembug.patch              |   53 ++++++++++++++++++++
>  2 files changed, 54 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-4.8.inc b/meta/recipes-devtools/gcc/gcc-4.8.inc
> index 4af98f8..8d50bf7 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.8.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.8.inc
> @@ -76,6 +76,7 @@ SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \
>  	   file://0044-gengtypes.patch \
>  	   file://0045-gcc-4.8-PR57717-PowerPC-E500v2.patch \
>  	   file://0046-libatomic-deptracking.patch \
> +	   file://0047-repomembug.patch \
>  	  "

Don't mix tabs and spaces in multiline variables.

All tabs in meta/recipes-devtools/gcc/gcc-4.8.inc are used incorrectly.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Richard Purdie : gcc: Fix strange C++ repo issues

[Richard Purdie]

On Mon, 2013-11-04 at 14:02 +0100, Martin Jansa wrote:
> On Mon, Oct 14, 2013 at 03:45:35PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
> > 
> > Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Date:   Wed Oct  9 20:37:49 2013 +0000
> > 
> > gcc: Fix strange C++ repo issues
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > 
> > ---
> > 
> >  meta/recipes-devtools/gcc/gcc-4.8.inc              |    1 +
> >  .../gcc/gcc-4.8/0047-repomembug.patch              |   53 ++++++++++++++++++++
> >  2 files changed, 54 insertions(+), 0 deletions(-)
> > 
> > diff --git a/meta/recipes-devtools/gcc/gcc-4.8.inc b/meta/recipes-devtools/gcc/gcc-4.8.inc
> > index 4af98f8..8d50bf7 100644
> > --- a/meta/recipes-devtools/gcc/gcc-4.8.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-4.8.inc
> > @@ -76,6 +76,7 @@ SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \
> >  	   file://0044-gengtypes.patch \
> >  	   file://0045-gcc-4.8-PR57717-PowerPC-E500v2.patch \
> >  	   file://0046-libatomic-deptracking.patch \
> > +	   file://0047-repomembug.patch \
> >  	  "
> 
> Don't mix tabs and spaces in multiline variables.
> 
> All tabs in meta/recipes-devtools/gcc/gcc-4.8.inc are used incorrectly.

Agreed, however I just copied the existing style which was better than
the alternatives. Whitespace changes need to be in a separate patch.

Cheers,

Richard