* [PATCH 0/1] Make sanity check failures nonfatal for bitbake -e
@ 2013-11-20 0:31 Peter Seebach
2013-11-20 0:31 ` [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment Peter Seebach
0 siblings, 1 reply; 6+ messages in thread
From: Peter Seebach @ 2013-11-20 0:31 UTC (permalink / raw)
To: openembedded-core
This patch depends on a separate patch to bitbake providing an
isTracking() in DataSmart. The goal here is that if you run "bitbake -e",
you can get variable values and include history even if something is
horribly wrong, because "something is horribly wrong" is precisely when
"bitbake -e" is most useful.
The following changes since commit 0eb947454e1c92467283e6f1adeca67c7c57698b:
python: Fix ptest not working problems (2013-11-18 13:04:13 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/nonfatal_insanity
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/nonfatal_insanity
Peter Seebach (1):
sanity.bbclass: Don't fatal() when trying to dump environment.
meta/classes/sanity.bbclass | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment.
2013-11-20 0:31 [PATCH 0/1] Make sanity check failures nonfatal for bitbake -e Peter Seebach
@ 2013-11-20 0:31 ` Peter Seebach
2013-11-20 0:35 ` Martin Jansa
2013-11-20 10:19 ` Richard Purdie
0 siblings, 2 replies; 6+ messages in thread
From: Peter Seebach @ 2013-11-20 0:31 UTC (permalink / raw)
To: openembedded-core
It is distressing when bitbake -e can't run due to sanity check
failures, because the solution often involves figuring out what
configuration file are being read and what values they are setting.
Solution: Don't do that. If the datasmart object reports that
tracking is enabled, emit an error() but not a fatal(), and also
warn the user that things may be badly broken.
This depends on a change to bitbake (adding the isTracking() method).
Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
---
meta/classes/sanity.bbclass | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 6807a23..1ef811d 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -82,11 +82,17 @@ def raise_sanity_error(msg, d, network_error=False):
bb.event.fire(bb.event.SanityCheckFailed(msg), d)
return
- bb.fatal(""" OE-core's config sanity checker detected a potential misconfiguration.
+ msg = (""" OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
Following is the list of potential problems / advisories:
%s""" % msg)
+ if d.isTracking():
+ bb.warn("Environment tracking enabled: NOT exiting on sanity check failures.")
+ bb.warn("Results may be inconsistent or meaningless; proceed at your own risk.")
+ bb.error(msg)
+ else:
+ bb.fatal(msg)
# Check a single tune for validity.
def check_toolchain_tune(data, tune, multilib):
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment.
2013-11-20 0:31 ` [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment Peter Seebach
@ 2013-11-20 0:35 ` Martin Jansa
2013-11-20 0:42 ` Peter Seebach
2013-11-20 10:19 ` Richard Purdie
1 sibling, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2013-11-20 0:35 UTC (permalink / raw)
To: Peter Seebach; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]
On Tue, Nov 19, 2013 at 06:31:57PM -0600, Peter Seebach wrote:
> It is distressing when bitbake -e can't run due to sanity check
> failures, because the solution often involves figuring out what
> configuration file are being read and what values they are setting.
> Solution: Don't do that. If the datasmart object reports that
> tracking is enabled, emit an error() but not a fatal(), and also
> warn the user that things may be badly broken.
>
> This depends on a change to bitbake (adding the isTracking() method).
>
> Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
> ---
> meta/classes/sanity.bbclass | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 6807a23..1ef811d 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -82,11 +82,17 @@ def raise_sanity_error(msg, d, network_error=False):
> bb.event.fire(bb.event.SanityCheckFailed(msg), d)
> return
>
> - bb.fatal(""" OE-core's config sanity checker detected a potential misconfiguration.
> + msg = (""" OE-core's config sanity checker detected a potential misconfiguration.
> Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
> Following is the list of potential problems / advisories:
>
> %s""" % msg)
> + if d.isTracking():
> + bb.warn("Environment tracking enabled: NOT exiting on sanity check failures.")
> + bb.warn("Results may be inconsistent or meaningless; proceed at your own risk.")
Inconsistent whitespace
> + bb.error(msg)
> + else:
> + bb.fatal(msg)
>
> # Check a single tune for validity.
> def check_toolchain_tune(data, tune, multilib):
> --
> 1.7.1
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment.
2013-11-20 0:31 ` [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment Peter Seebach
2013-11-20 0:35 ` Martin Jansa
@ 2013-11-20 10:19 ` Richard Purdie
2013-11-20 15:16 ` Peter Seebach
1 sibling, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2013-11-20 10:19 UTC (permalink / raw)
To: Peter Seebach; +Cc: openembedded-core
On Tue, 2013-11-19 at 18:31 -0600, Peter Seebach wrote:
> It is distressing when bitbake -e can't run due to sanity check
> failures, because the solution often involves figuring out what
> configuration file are being read and what values they are setting.
> Solution: Don't do that. If the datasmart object reports that
> tracking is enabled, emit an error() but not a fatal(), and also
> warn the user that things may be badly broken.
>
> This depends on a change to bitbake (adding the isTracking() method).
>
> Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
> ---
> meta/classes/sanity.bbclass | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 6807a23..1ef811d 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -82,11 +82,17 @@ def raise_sanity_error(msg, d, network_error=False):
> bb.event.fire(bb.event.SanityCheckFailed(msg), d)
> return
>
> - bb.fatal(""" OE-core's config sanity checker detected a potential misconfiguration.
> + msg = (""" OE-core's config sanity checker detected a potential misconfiguration.
> Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
> Following is the list of potential problems / advisories:
>
> %s""" % msg)
> + if d.isTracking():
> + bb.warn("Environment tracking enabled: NOT exiting on sanity check failures.")
> + bb.warn("Results may be inconsistent or meaningless; proceed at your own risk.")
> + bb.error(msg)
> + else:
> + bb.fatal(msg)
This is creative but you just disabled the sanity tests in the graphical
UIs like hob.
isTracking() does not mean -e is being used, we use the tracking in
other places now too.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment.
2013-11-20 10:19 ` Richard Purdie
@ 2013-11-20 15:16 ` Peter Seebach
0 siblings, 0 replies; 6+ messages in thread
From: Peter Seebach @ 2013-11-20 15:16 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Wed, 20 Nov 2013 10:19:04 +0000
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> This is creative but you just disabled the sanity tests in the graphical
> UIs like hob.
>
> isTracking() does not mean -e is being used, we use the tracking in
> other places now too.
Drat.
Perhaps an alternative would be to have -e set a specific variable, like
BB_SHOW_ENV_ONLY?
-s
--
Listen, get this. Nobody with a good compiler needs to be justified.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-20 15:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-20 0:31 [PATCH 0/1] Make sanity check failures nonfatal for bitbake -e Peter Seebach
2013-11-20 0:31 ` [PATCH 1/1] sanity.bbclass: Don't fatal() when trying to dump environment Peter Seebach
2013-11-20 0:35 ` Martin Jansa
2013-11-20 0:42 ` Peter Seebach
2013-11-20 10:19 ` Richard Purdie
2013-11-20 15:16 ` Peter Seebach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox