Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] wpa-supplicant-2.0: don't exit in pkg_postinst
@ 2014-01-16 13:34 Alexandre Belloni
  2014-01-29 13:06 ` Alexandre Belloni
  0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2014-01-16 13:34 UTC (permalink / raw)
  To: Cristian Iorga; +Cc: openembedded-core

Exiting explicitly in pkg_postinst makes it impossible to use the
update-rc.d class in a .bbappend because the link creation is appended
to the pkg_postinst script.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc b/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
index ce669a1ffa4f..ba28c6bd4528 100644
--- a/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
+++ b/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
@@ -82,9 +82,8 @@ do_install () {
 
 pkg_postinst_wpa-supplicant () {
 	# If we're offline, we don't need to do this.
-	if [ "x$D" != "x" ]; then
-		exit 0
+	if [ "x$D" = "x" ]; then
+		killall -q -HUP dbus-daemon || true
 	fi
 
-	killall -q -HUP dbus-daemon || true
 }
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] wpa-supplicant-2.0: don't exit in pkg_postinst
  2014-01-16 13:34 [PATCH] wpa-supplicant-2.0: don't exit in pkg_postinst Alexandre Belloni
@ 2014-01-29 13:06 ` Alexandre Belloni
  2014-01-29 17:41   ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2014-01-29 13:06 UTC (permalink / raw)
  To: Cristian Iorga; +Cc: openembedded-core

Ping ?

On Thu, Jan 16, 2014 at 14:34:39 +0100, Alexandre Belloni wrote :
> Exiting explicitly in pkg_postinst makes it impossible to use the
> update-rc.d class in a .bbappend because the link creation is appended
> to the pkg_postinst script.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc b/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
> index ce669a1ffa4f..ba28c6bd4528 100644
> --- a/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
> +++ b/meta/recipes-connectivity/wpa-supplicant/wpa-supplicant-2.0.inc
> @@ -82,9 +82,8 @@ do_install () {
>  
>  pkg_postinst_wpa-supplicant () {
>  	# If we're offline, we don't need to do this.
> -	if [ "x$D" != "x" ]; then
> -		exit 0
> +	if [ "x$D" = "x" ]; then
> +		killall -q -HUP dbus-daemon || true
>  	fi
>  
> -	killall -q -HUP dbus-daemon || true
>  }
> -- 
> 1.8.3.2
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] wpa-supplicant-2.0: don't exit in pkg_postinst
  2014-01-29 13:06 ` Alexandre Belloni
@ 2014-01-29 17:41   ` Richard Purdie
  2014-01-29 18:46     ` Alexandre Belloni
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2014-01-29 17:41 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: openembedded-core

On Wed, 2014-01-29 at 14:06 +0100, Alexandre Belloni wrote:
> Ping ?

Merged 10 days ago:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=cac6f8148a88d072636bc1f9d54fed6de80dcb6d

Cheers,

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] wpa-supplicant-2.0: don't exit in pkg_postinst
  2014-01-29 17:41   ` Richard Purdie
@ 2014-01-29 18:46     ` Alexandre Belloni
  0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2014-01-29 18:46 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Oh right, I didn't get any notifications so I assumed nobody had a look
at it.

Thanks !

On 29/01/2014 at 17:41:42 +0000, Richard Purdie wrote :
> On Wed, 2014-01-29 at 14:06 +0100, Alexandre Belloni wrote:
> > Ping ?
> 
> Merged 10 days ago:
> 
> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=cac6f8148a88d072636bc1f9d54fed6de80dcb6d
> 
> Cheers,
> 
> Richard
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-01-29 18:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-16 13:34 [PATCH] wpa-supplicant-2.0: don't exit in pkg_postinst Alexandre Belloni
2014-01-29 13:06 ` Alexandre Belloni
2014-01-29 17:41   ` Richard Purdie
2014-01-29 18:46     ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox