[PATCH] update-rc.d: Allow to use different initscripts provider

[PATCH] update-rc.d: Allow to use different initscripts provider

[Martin Jansa]

* until now all recipes were respecting VIRTUAL-RUNTIME_initscripts
  variable but commit bba835fed88c3bd5bb5bd58962034aef57c408d8
  hardcoded "initscripts" runtime dependency

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/update-rc.d.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update-rc.d.bbclass
index ca9486b..19b081d 100644
--- a/meta/classes/update-rc.d.bbclass
+++ b/meta/classes/update-rc.d.bbclass
@@ -1,7 +1,8 @@
 UPDATERCPN ?= "${PN}"
 
 DEPENDS_append = " update-rc.d-native"
-DEPENDS_append_class-target = " initscripts"
+VIRTUAL-RUNTIME_initscripts ?= "initscripts"
+DEPENDS_append_class-target = " ${VIRTUAL-RUNTIME_initscripts}"
 UPDATERCD = "update-rc.d"
 UPDATERCD_class-cross = ""
 UPDATERCD_class-native = ""
-- 
2.0.0

Re: [PATCH] update-rc.d: Allow to use different initscripts provider

[Paul Eggleton]

Hi Martin,

On Friday 06 June 2014 18:57:34 Martin Jansa wrote:
> * until now all recipes were respecting VIRTUAL-RUNTIME_initscripts
>   variable but commit bba835fed88c3bd5bb5bd58962034aef57c408d8
>   hardcoded "initscripts" runtime dependency
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/classes/update-rc.d.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/update-rc.d.bbclass
> b/meta/classes/update-rc.d.bbclass index ca9486b..19b081d 100644
> --- a/meta/classes/update-rc.d.bbclass
> +++ b/meta/classes/update-rc.d.bbclass
> @@ -1,7 +1,8 @@
>  UPDATERCPN ?= "${PN}"
> 
>  DEPENDS_append = " update-rc.d-native"
> -DEPENDS_append_class-target = " initscripts"
> +VIRTUAL-RUNTIME_initscripts ?= "initscripts"
> +DEPENDS_append_class-target = " ${VIRTUAL-RUNTIME_initscripts}"
>  UPDATERCD = "update-rc.d"
>  UPDATERCD_class-cross = ""
>  UPDATERCD_class-native = ""

Technically this isn't right either though - VIRTUAL-RUNTIME_initscripts is 
for the runtime package name not the recipe as is being added here. It just so 
happens that they are the same thing for initscripts.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] update-rc.d: Allow to use different initscripts provider

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

On Tue, Jun 17, 2014 at 01:33:17PM +0100, Paul Eggleton wrote:
> Hi Martin,
> 
> On Friday 06 June 2014 18:57:34 Martin Jansa wrote:
> > * until now all recipes were respecting VIRTUAL-RUNTIME_initscripts
> >   variable but commit bba835fed88c3bd5bb5bd58962034aef57c408d8
> >   hardcoded "initscripts" runtime dependency
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/classes/update-rc.d.bbclass | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/update-rc.d.bbclass
> > b/meta/classes/update-rc.d.bbclass index ca9486b..19b081d 100644
> > --- a/meta/classes/update-rc.d.bbclass
> > +++ b/meta/classes/update-rc.d.bbclass
> > @@ -1,7 +1,8 @@
> >  UPDATERCPN ?= "${PN}"
> > 
> >  DEPENDS_append = " update-rc.d-native"
> > -DEPENDS_append_class-target = " initscripts"
> > +VIRTUAL-RUNTIME_initscripts ?= "initscripts"
> > +DEPENDS_append_class-target = " ${VIRTUAL-RUNTIME_initscripts}"
> >  UPDATERCD = "update-rc.d"
> >  UPDATERCD_class-cross = ""
> >  UPDATERCD_class-native = ""
> 
> Technically this isn't right either though - VIRTUAL-RUNTIME_initscripts is 
> for the runtime package name not the recipe as is being added here. It just so 
> happens that they are the same thing for initscripts.

Ah, you're right, I was blind when reading DEPENDS (I've even mentioned
runtime dependency in commit message :/), sorry.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]