Re: [PATCH 6/8] lttng-modules: re-enable ARM builds

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2817 bytes --]

On Thu, Jul 24, 2014 at 11:10:50PM -0400, Bruce Ashfield wrote:
> On Thu, Jul 24, 2014 at 6:02 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Thu, Jul 24, 2014 at 04:41:52PM -0400, Bruce Ashfield wrote:
> >> With lttng 2.4.2 and gcc 4.9, we can now enable lttng-modules for ARM.
> >>
> >> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> >> ---
> >>  meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb b/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
> >> index 5a99a5adae8b..d87374163556 100644
> >> --- a/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
> >> +++ b/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
> >> @@ -12,8 +12,7 @@ inherit module
> >>
> >>  SRCREV = "789fd1d06d07aeb9a403bdce1b3318560cfc6eca"
> >>
> >> -# lttng currently blacklists arm with gcc-4.8
> >> -COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips).*-linux'
> >> +COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips|arm).*-linux'
> >
> > Please squash this to 2/8 otherwise there is no arm version between 2/8
> > and 6/8.
> 
> I'd rather not, since they are separate activities. I updated to 2.5,
> and then enable
> ARM. One isolated change per commit. Bisectability in a small series is one
> thing, but also is the isolation of changes.

2/8 commit message says:

We also drop the older 2.3.3 lttng-modules, since it is no longer
required to support ARM builds.

Which isn't true at that time and it means that these changes aren't
separate activities.

To keep them separate, remove 2.3.3 in this commit, not in upgrade to
2.5.0. (or with more work involved, enable arm in 2.4* together with
2.3.3 removal as someone reported arm+2.4* also working now).

> Richard can squash on merge is he wants, but I'm going to leave it as is.
> 
> Bruce
> 
> >
> >>  SRC_URI = "git://git.lttng.org/lttng-modules.git;branch=stable-2.5 \
> >>             file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch \
> >> --
> >> 1.8.1.2
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> 
> 
> 
> -- 
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]