Re: [PATCH 2/8] lttng-modules: update to 2.5.0

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 5078 bytes --]

On Fri, Jul 25, 2014 at 09:36:12AM -0400, Bruce Ashfield wrote:
> On Fri, Jul 25, 2014 at 9:23 AM, Bruce Ashfield
> <bruce.ashfield@gmail.com> wrote:
> > On Fri, Jul 25, 2014 at 9:21 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> On Thu, Jul 24, 2014 at 04:41:48PM -0400, Bruce Ashfield wrote:
> >>> During the uprev of the yocto kernel to 3.16, lttng-modules failed to build.
> >>> To grab the latest stable content, we update to 2.5.0, and add two patches
> >>> to also make it build against 3.16+.
> >>>
> >>> We also drop the older 2.3.3 lttng-modules, since it is no longer required
> >>> to support ARM builds.
> >>>
> >>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> >>> ---
> >>>  ...compaction-instrumentation-to-3.16-kernel.patch | 83 ++++++++++++++++++++++
> >>>  ...ate-vmscan-instrumentation-to-3.16-kernel.patch | 70 ++++++++++++++++++
> >>>  meta/recipes-kernel/lttng/lttng-modules_2.3.3.bb   | 36 ----------
> >>>  ...tng-modules_2.4.1.bb => lttng-modules_2.5.0.bb} |  7 +-
> >>>  4 files changed, 157 insertions(+), 39 deletions(-)
> >>>  create mode 100644 meta/recipes-kernel/lttng/lttng-modules/Update-compaction-instrumentation-to-3.16-kernel.patch
> >>>  create mode 100644 meta/recipes-kernel/lttng/lttng-modules/Update-vmscan-instrumentation-to-3.16-kernel.patch
> >>>  delete mode 100644 meta/recipes-kernel/lttng/lttng-modules_2.3.3.bb
> >>>  rename meta/recipes-kernel/lttng/{lttng-modules_2.4.1.bb => lttng-modules_2.5.0.bb} (85%)
> >>>
> >>
> >> ...
> >>
> >>> diff --git a/meta/recipes-kernel/lttng/lttng-modules_2.4.1.bb b/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
> >>> similarity index 85%
> >>> rename from meta/recipes-kernel/lttng/lttng-modules_2.4.1.bb
> >>> rename to meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
> >>> index 5e05ffc69853..5a99a5adae8b 100644
> >>> --- a/meta/recipes-kernel/lttng/lttng-modules_2.4.1.bb
> >>> +++ b/meta/recipes-kernel/lttng/lttng-modules_2.5.0.bb
> >>> @@ -10,14 +10,15 @@ DEPENDS = "virtual/kernel"
> >>
> >> Is the LICENSE = "LGPLv2.1 & GPLv2" correct?
> >
> > Let me double check. I was doing an update and test, and didn't notice if
> > this had changed.
> >
> > Even if it did change, and I'm just uprev'ing .. I'll fix it, since it
> > being wrong
> > in the past doesn't give me a free pass to keep it wrong in an update :)
> 
> Too funny. There have been the three MIT licence files since 2011 .. so I agree
> that the recipe's summary is long.  I'll tack a patch onto the end of the series
> and wait to hear from RP/Saul about anything else I may have broken.

Sorry I thought you're maintainer of lttng-*, it seems like Laurentiu is
+ Laurentiu
maintainers.inc:RECIPE_MAINTAINER_pn-lttng-modules = "Laurentiu Palcu <laurentiu.palcu@intel.com>"
maintainers.inc:RECIPE_MAINTAINER_pn-lttng-ust = "Laurentiu Palcu <laurentiu.palcu@intel.com>"

The same LICENSE issue is in lttng-ust

git/LICENSE:
...
* MIT license :

Public header files are distributed under the MIT license. See
mit-license.txt for details.
...

> Bruce
> 
> >
> > Cheers,
> >
> > Bruce
> >
> >>
> >> git/LICENSE says:
> >>
> >> * MIT-style license
> >>
> >> These files are licensed under an MIT-style license. See mit-license.txt
> >> for details.
> >>
> >> lib/prio_heap/lttng_prio_heap.h
> >> lib/prio_heap/lttng_prio_heap.c
> >> lib/bitfield.h
> >>
> >>
> >>>
> >>>  inherit module
> >>>
> >>> -SRCREV = "a0383def517e3aebbbcebae61fe2bcfb50d31e71"
> >>> -PV = "2.4.1"
> >>> +SRCREV = "789fd1d06d07aeb9a403bdce1b3318560cfc6eca"
> >>>
> >>>  # lttng currently blacklists arm with gcc-4.8
> >>>  COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips).*-linux'
> >>>
> >>> -SRC_URI = "git://git.lttng.org/lttng-modules.git;branch=stable-2.4 \
> >>> +SRC_URI = "git://git.lttng.org/lttng-modules.git;branch=stable-2.5 \
> >>>             file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch \
> >>> +           file://Update-compaction-instrumentation-to-3.16-kernel.patch \
> >>> +           file://Update-vmscan-instrumentation-to-3.16-kernel.patch \
> >>>             "
> >>>
> >>>  export INSTALL_MOD_DIR="kernel/lttng-modules"
> >>> --
> >>> 1.8.1.2
> >>>
> >>> --
> >>> _______________________________________________
> >>> Openembedded-core mailing list
> >>> Openembedded-core@lists.openembedded.org
> >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>
> >> --
> >> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>
> >
> >
> >
> > --
> > "Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end"
> 
> 
> 
> -- 
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]