Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/8] test-dependencies, insane.bbclass: improve the message
@ 2014-08-09 16:07 Martin Jansa
  2014-08-09 16:07 ` [PATCH 2/8] gst-fluendo*: add --disable-debug only to gst-fluendo-mp3 Martin Jansa
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Martin Jansa @ 2014-08-09 16:07 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/insane.bbclass  | 2 +-
 scripts/test-dependencies.sh | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 55bfaf2..3dd2e7f 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -794,7 +794,7 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
                             break
                 if rdep_data and 'PN' in rdep_data and rdep_data['PN'] in taskdeps:
                     continue
-                error_msg = "%s rdepends on %s but its not a build dependency?" % (pkg, rdepend)
+                error_msg = "%s rdepends on %s, but it isn't a build dependency?" % (pkg, rdepend)
                 sane = package_qa_handle_error("build-deps", error_msg, d)
 
     return sane
diff --git a/scripts/test-dependencies.sh b/scripts/test-dependencies.sh
index ecbb710..2bcc2ca 100755
--- a/scripts/test-dependencies.sh
+++ b/scripts/test-dependencies.sh
@@ -244,9 +244,11 @@ compare_deps() {
     else
       missing_deps=
       for dep in ${max_deps}; do
-        echo "${min_deps}" | grep -q " ${dep} " || missing_deps="${missing_deps} ${dep}"
-        echo # to get rid of dots on last line
-        echo "WARN: ${recipe}: ${package} rdepends on ${dep} but its not a build dependency?" | tee -a ${OUTPUT_FILE}
+        if ! echo "${min_deps}" | grep -q " ${dep} " ; then
+          missing_deps="${missing_deps} ${dep}"
+          echo # to get rid of dots on last line
+          echo "WARN: ${recipe}: ${package} rdepends on ${dep}, but it isn't a build dependency?" | tee -a ${OUTPUT_FILE}
+        fi
       done
       if [ -n "${missing_deps}" ] ; then
         echo ${recipe} >> ${OUTPUTC}/failed-recipes.log
-- 
2.0.4



^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-08-17  8:57 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-09 16:07 [PATCH 1/8] test-dependencies, insane.bbclass: improve the message Martin Jansa
2014-08-09 16:07 ` [PATCH 2/8] gst-fluendo*: add --disable-debug only to gst-fluendo-mp3 Martin Jansa
2014-08-09 16:07 ` [PATCH 3/8] mpeg2dec: add PACKAGECONFIG for x11 and fix dependencies Martin Jansa
2014-08-09 16:07 ` [PATCH 4/8] libarchive: add PACKAGECONFIG for nettle Martin Jansa
2014-08-09 16:08 ` [PATCH 5/8] piglit: add dependency on libxrender Martin Jansa
2014-08-16 18:19   ` Martin Jansa
2014-08-17  8:57     ` Richard Purdie
2014-08-09 16:08 ` [PATCH 6/8] midori: add dependency on libxscrnsaver Martin Jansa
2014-08-09 16:08 ` [PATCH 7/8] directfb: add PACKAGECONFIG for drmkms and tiff Martin Jansa
2014-08-09 16:08 ` [PATCH 8/8] guile: add dependency on ncurses and readline Martin Jansa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox