From: Marek Vasut <marex@denx.de>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
Koen Kooi <koen@dominion.thruhere.net>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/7] kernel: Clean up KERNEL_IMAGETYPE_FOR_MAKE
Date: Sun, 19 Oct 2014 23:13:41 +0200 [thread overview]
Message-ID: <201410192313.41430.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKqaBcGWTh3e2-TQzqdr7SRFfSRc91R9_ZX=YALOnFhRzw@mail.gmail.com>
On Sunday, October 19, 2014 at 09:25:36 PM, Otavio Salvador wrote:
> On Sun, Oct 19, 2014 at 5:15 PM, Marek Vasut <marex@denx.de> wrote:
> > Remove the lambda function setting KERNEL_IMAGETYPE_FOR_MAKE and instead
> > set it in the anonymous python function. This also allows us to handle
> > image types which are not supported directly by kernel, but require some
> > other kernel target to be built. This is the case for example with the
> > fitImage, which is the uImage successor.
> >
> > There is no functional change.
>
> This is not really what the code shows; your regexp is more permissive
> than the previous lambda.
Do you happen to have a suggestion how to improve the patch please ? I'm
not really a python guru so any help is welcome ...
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-10-19 21:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 19:15 [PATCH 0/7] Add basic fitImage support Marek Vasut
2014-10-19 19:15 ` [PATCH 1/7] kernel: Clean up KERNEL_IMAGETYPE_FOR_MAKE Marek Vasut
2014-10-19 19:25 ` Otavio Salvador
2014-10-19 21:13 ` Marek Vasut [this message]
2014-10-19 21:26 ` Otavio Salvador
2014-10-22 20:39 ` Marek Vasut
2014-10-23 0:32 ` Otavio Salvador
2014-10-23 0:45 ` Marek Vasut
2014-10-19 19:15 ` [PATCH 2/7] kernel: Rework do_uboot_mkimage Marek Vasut
2014-10-19 19:15 ` [PATCH 3/7] kernel: Pull out the linux.bin generation Marek Vasut
2014-10-19 19:15 ` [PATCH 4/7] kernel: Pull uImage generation into separate class Marek Vasut
2014-10-19 21:29 ` Khem Raj
2014-10-19 22:31 ` Marek Vasut
2014-10-19 22:08 ` Bruce Ashfield
2014-10-19 22:29 ` Marek Vasut
2014-10-20 3:38 ` Bruce Ashfield
2014-10-20 10:26 ` Koen Kooi
2014-10-21 23:28 ` Marek Vasut
2014-10-22 8:42 ` Koen Kooi
2014-10-22 21:45 ` Marek Vasut
2014-10-26 11:29 ` Koen Kooi
2014-10-26 22:52 ` Marek Vasut
2014-10-27 6:59 ` Koen Kooi
2015-04-28 2:39 ` Marek Vasut
2015-04-28 8:22 ` Paul Eggleton
2014-10-22 20:51 ` Marek Vasut
2014-10-19 19:15 ` [PATCH 5/7] kernel: Separate out uboot_prep_kimage Marek Vasut
2014-10-19 19:15 ` [PATCH 6/7] kernel: Build DTBs early Marek Vasut
2014-10-19 19:15 ` [PATCH 7/7] kernel: Add basic fitImage support Marek Vasut
2014-10-19 19:32 ` [PATCH 0/7] " Otavio Salvador
2015-04-28 1:32 ` Marek Vasut
2014-10-22 23:26 ` Burton, Ross
2014-10-23 0:01 ` Marek Vasut
2015-04-28 1:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410192313.41430.marex@denx.de \
--to=marex@denx.de \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox