From: Marek Vasut <marex@denx.de>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/7] kernel: Pull uImage generation into separate class
Date: Tue, 28 Apr 2015 04:39:32 +0200 [thread overview]
Message-ID: <201504280439.32255.marex@denx.de> (raw)
In-Reply-To: <E8543342-2D6B-4707-810A-E88564881F20@dominion.thruhere.net>
On Monday, October 27, 2014 at 07:59:42 AM, Koen Kooi wrote:
Hi!
sorry for the very late reply.
> > So uh, what exactly would you propose then? Ask the BSPs to cater for the
> > change ? I don't quite like that option, since it's like breaking an API
> > (or similar interface, I'm not sure what the local equivalent of that
> > would be).
>
> Personally, I'd try to keep the kernel_foo() methods the same since those
> are very popular, a lot of BSPs append the configure one. So maybe
> something like:
>
> kernel.bbclass:
> do_configure
> do_install
> addtask
> etc
> inherit kernel-${KERNEL_IMAGETYPE.bbclass}
>
> kernel-${KERNEL_IMAGETYPE.bbclass}
> do_install (overrides the one in kernel.bbclass)
>
> Someone more familiar with bbclass method (re)naming and scoping should
> weigh in on the method override above, but I think it should work.
I wonder, is it possible to inherit bbclass if it exists as a file and inherit
nothing otherwise ?
In case I do:
inherit kernel-${@d.getVar("KERNEL_IMAGETYPE", True).lower()}
I get a nasty spit from bitbake in case I'm building with zImage
KERNEL_IMAGETYPE . The reason is obvious, the file kernel-zimage.bbclass
doesn't exist. So I wonder if there's some easy way to check if the class
actually exists.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-04-28 2:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 19:15 [PATCH 0/7] Add basic fitImage support Marek Vasut
2014-10-19 19:15 ` [PATCH 1/7] kernel: Clean up KERNEL_IMAGETYPE_FOR_MAKE Marek Vasut
2014-10-19 19:25 ` Otavio Salvador
2014-10-19 21:13 ` Marek Vasut
2014-10-19 21:26 ` Otavio Salvador
2014-10-22 20:39 ` Marek Vasut
2014-10-23 0:32 ` Otavio Salvador
2014-10-23 0:45 ` Marek Vasut
2014-10-19 19:15 ` [PATCH 2/7] kernel: Rework do_uboot_mkimage Marek Vasut
2014-10-19 19:15 ` [PATCH 3/7] kernel: Pull out the linux.bin generation Marek Vasut
2014-10-19 19:15 ` [PATCH 4/7] kernel: Pull uImage generation into separate class Marek Vasut
2014-10-19 21:29 ` Khem Raj
2014-10-19 22:31 ` Marek Vasut
2014-10-19 22:08 ` Bruce Ashfield
2014-10-19 22:29 ` Marek Vasut
2014-10-20 3:38 ` Bruce Ashfield
2014-10-20 10:26 ` Koen Kooi
2014-10-21 23:28 ` Marek Vasut
2014-10-22 8:42 ` Koen Kooi
2014-10-22 21:45 ` Marek Vasut
2014-10-26 11:29 ` Koen Kooi
2014-10-26 22:52 ` Marek Vasut
2014-10-27 6:59 ` Koen Kooi
2015-04-28 2:39 ` Marek Vasut [this message]
2015-04-28 8:22 ` Paul Eggleton
2014-10-22 20:51 ` Marek Vasut
2014-10-19 19:15 ` [PATCH 5/7] kernel: Separate out uboot_prep_kimage Marek Vasut
2014-10-19 19:15 ` [PATCH 6/7] kernel: Build DTBs early Marek Vasut
2014-10-19 19:15 ` [PATCH 7/7] kernel: Add basic fitImage support Marek Vasut
2014-10-19 19:32 ` [PATCH 0/7] " Otavio Salvador
2015-04-28 1:32 ` Marek Vasut
2014-10-22 23:26 ` Burton, Ross
2014-10-23 0:01 ` Marek Vasut
2015-04-28 1:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504280439.32255.marex@denx.de \
--to=marex@denx.de \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox