Re: [oe-commits] Jonathan Liu : systemd: fix firmware path to match linux-firmware

Re: [oe-commits] Jonathan Liu : systemd: fix firmware path to match linux-firmware

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2034 bytes --]

On Mon, Mar 23, 2015 at 11:27:36AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: d3fcfe346b3472170641d9194243c4bbe06b8585
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=d3fcfe346b3472170641d9194243c4bbe06b8585
> 
> Author: Jonathan Liu <net147@gmail.com>
> Date:   Mon Mar 23 22:18:46 2015 +1100
> 
> systemd: fix firmware path to match linux-firmware
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> ---
> 
>  meta/recipes-core/systemd/systemd_219.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_219.bb b/meta/recipes-core/systemd/systemd_219.bb
> index 5ecdda9..f2d3c13 100644
> --- a/meta/recipes-core/systemd/systemd_219.bb
> +++ b/meta/recipes-core/systemd/systemd_219.bb
> @@ -112,7 +112,7 @@ EXTRA_OECONF = " --with-rootprefix=${rootprefix} \
>                   --enable-split-usr \
>                   --without-python \
>                   --with-sysvrcnd-path=${sysconfdir} \
> -                 --with-firmware-path=${rootlibdir}/firmware \
> +                 --with-firmware-path=/lib/firmware \

Is this false-possitive from QA check or is this change really ignored
by systemd build?

NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Started
WARNING: QA Issue: systemd: configure was passed unrecognised options: --with-firmware-path [unknown-configure-option]
NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Succeeded

>                 "
>  # uclibc does not have NSS
>  EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
> 
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [oe-commits] Jonathan Liu : systemd: fix firmware path to match linux-firmware

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On 23 March 2015 at 18:43, Martin Jansa <martin.jansa@gmail.com> wrote:

> WARNING: QA Issue: systemd: configure was passed unrecognised options:
> --with-firmware-path [unknown-configure-option]
>

I for one don't see that.  Do you happen to have that build to hand still?
Actually seeing log.do_configure would be useful.

Ross

[-- Attachment #2: Type: text/html, Size: 752 bytes --]

Re: [oe-commits] Jonathan Liu : systemd: fix firmware path to match linux-firmware

[Randy Witt]

On 03/23/2015 09:43 AM, Martin Jansa wrote:
> On Mon, Mar 23, 2015 at 11:27:36AM +0000, git@git.openembedded.org wrote:
>> Module: openembedded-core.git
>> Branch: master
>> Commit: d3fcfe346b3472170641d9194243c4bbe06b8585
>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=d3fcfe346b3472170641d9194243c4bbe06b8585
>>
>> Author: Jonathan Liu <net147@gmail.com>
>> Date:   Mon Mar 23 22:18:46 2015 +1100
>>
>> systemd: fix firmware path to match linux-firmware
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>
>> ---
>>
>>   meta/recipes-core/systemd/systemd_219.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/systemd/systemd_219.bb b/meta/recipes-core/systemd/systemd_219.bb
>> index 5ecdda9..f2d3c13 100644
>> --- a/meta/recipes-core/systemd/systemd_219.bb
>> +++ b/meta/recipes-core/systemd/systemd_219.bb
>> @@ -112,7 +112,7 @@ EXTRA_OECONF = " --with-rootprefix=${rootprefix} \
>>                    --enable-split-usr \
>>                    --without-python \
>>                    --with-sysvrcnd-path=${sysconfdir} \
>> -                 --with-firmware-path=${rootlibdir}/firmware \
>> +                 --with-firmware-path=/lib/firmware \
>
> Is this false-possitive from QA check or is this change really ignored
> by systemd build?

Userspace firmware loading support was actually removed, but Jonathan added it 
back in:

https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=814252efd028ec99a15303d9a551e950e49a6726
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=4bd886fb0081954879aaa2f574f3c7f6ced745d5

> NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Started
> WARNING: QA Issue: systemd: configure was passed unrecognised options: --with-firmware-path [unknown-configure-option]
> NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Succeeded
>
>>                  "
>>   # uclibc does not have NSS
>>   EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
>>
>> --
>> _______________________________________________
>> Openembedded-commits mailing list
>> Openembedded-commits@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>
>
>

Re: [oe-commits] Jonathan Liu : systemd: fix firmware path to match linux-firmware

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2871 bytes --]

On Mon, Mar 23, 2015 at 10:14:57AM -0700, Randy Witt wrote:
> On 03/23/2015 09:43 AM, Martin Jansa wrote:
> > On Mon, Mar 23, 2015 at 11:27:36AM +0000, git@git.openembedded.org wrote:
> >> Module: openembedded-core.git
> >> Branch: master
> >> Commit: d3fcfe346b3472170641d9194243c4bbe06b8585
> >> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=d3fcfe346b3472170641d9194243c4bbe06b8585
> >>
> >> Author: Jonathan Liu <net147@gmail.com>
> >> Date:   Mon Mar 23 22:18:46 2015 +1100
> >>
> >> systemd: fix firmware path to match linux-firmware
> >>
> >> Signed-off-by: Jonathan Liu <net147@gmail.com>
> >> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >>
> >> ---
> >>
> >>   meta/recipes-core/systemd/systemd_219.bb | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/systemd/systemd_219.bb b/meta/recipes-core/systemd/systemd_219.bb
> >> index 5ecdda9..f2d3c13 100644
> >> --- a/meta/recipes-core/systemd/systemd_219.bb
> >> +++ b/meta/recipes-core/systemd/systemd_219.bb
> >> @@ -112,7 +112,7 @@ EXTRA_OECONF = " --with-rootprefix=${rootprefix} \
> >>                    --enable-split-usr \
> >>                    --without-python \
> >>                    --with-sysvrcnd-path=${sysconfdir} \
> >> -                 --with-firmware-path=${rootlibdir}/firmware \
> >> +                 --with-firmware-path=/lib/firmware \
> >
> > Is this false-possitive from QA check or is this change really ignored
> > by systemd build?
> 
> Userspace firmware loading support was actually removed, but Jonathan added it 
> back in:
> 
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=814252efd028ec99a15303d9a551e950e49a6726
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=4bd886fb0081954879aaa2f574f3c7f6ced745d5

Ah, sorry I see it now.

meta-android adds --with-firmware-path and it was applied without these
patches from Jonathan. So now it should be fine and I dont need to
remove android firmware path tweak.

Thanks for clarification and sorry for noise.

> 
> > NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Started
> > WARNING: QA Issue: systemd: configure was passed unrecognised options: --with-firmware-path [unknown-configure-option]
> > NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Succeeded
> >
> >>                  "
> >>   # uclibc does not have NSS
> >>   EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-commits mailing list
> >> Openembedded-commits@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
> >
> >
> >
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]