From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Mario Domenech Goulart <mario@ossystems.com.br>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] oeqa/utils: Allow ~ in bblayers
Date: Thu, 30 Apr 2015 16:24:23 +0300 [thread overview]
Message-ID: <20150430132423.GA6936@linux.intel.com> (raw)
In-Reply-To: <87egn12286.fsf@email.parenteses.org>
On Thu, Apr 30, 2015 at 01:08:09PM +0000, Mario Domenech Goulart wrote:
> Hi Ed,
>
> On Thu, 30 Apr 2015 14:04:50 +0300 Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
>
> > Bitbake can parse ~ in bblayer's paths.
> > Added this functionality to oeqa code.
> >
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > ---
> > meta/lib/oeqa/utils/commands.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/lib/oeqa/utils/commands.py b/meta/lib/oeqa/utils/commands.py
> > index e8a467f..bc1dbb1 100644
> > --- a/meta/lib/oeqa/utils/commands.py
> > +++ b/meta/lib/oeqa/utils/commands.py
> > @@ -155,6 +155,8 @@ def get_test_layer():
> > layers = get_bb_var("BBLAYERS").split()
> > testlayer = None
> > for l in layers:
> > + if '~' in l:
> > + l = os.path.expanduser(l)
>
> Is the "if '~' in l" test necessary?
>
I did this to show why expanduser is called at all. This makes code self-explanatory and easier to understand.
I was suggested to do it here: http://lists.openembedded.org/pipermail/bitbake-devel/2015-April/005661.html
--
Regards,
Ed
prev parent reply other threads:[~2015-04-30 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 11:04 [PATCH] oeqa/utils: Allow ~ in bblayers Ed Bartosh
2015-04-30 13:08 ` Mario Domenech Goulart
2015-04-30 13:16 ` Gary Thomas
2015-04-30 13:30 ` Mario Domenech Goulart
2015-04-30 13:24 ` Ed Bartosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430132423.GA6936@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=mario@ossystems.com.br \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox