Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mario Domenech Goulart <mario@ossystems.com.br>
To: Ed Bartosh <ed.bartosh@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] oeqa/utils: Allow ~ in bblayers
Date: Thu, 30 Apr 2015 13:08:09 +0000	[thread overview]
Message-ID: <87egn12286.fsf@email.parenteses.org> (raw)
In-Reply-To: <1430391890-6083-1-git-send-email-ed.bartosh@linux.intel.com> (Ed Bartosh's message of "Thu, 30 Apr 2015 14:04:50 +0300")

Hi Ed,

On Thu, 30 Apr 2015 14:04:50 +0300 Ed Bartosh <ed.bartosh@linux.intel.com> wrote:

> Bitbake can parse ~ in bblayer's paths.
> Added this functionality to oeqa code.
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
>  meta/lib/oeqa/utils/commands.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/lib/oeqa/utils/commands.py b/meta/lib/oeqa/utils/commands.py
> index e8a467f..bc1dbb1 100644
> --- a/meta/lib/oeqa/utils/commands.py
> +++ b/meta/lib/oeqa/utils/commands.py
> @@ -155,6 +155,8 @@ def get_test_layer():
>      layers = get_bb_var("BBLAYERS").split()
>      testlayer = None
>      for l in layers:
> +        if '~' in l:
> +            l = os.path.expanduser(l)

Is the "if '~' in l" test necessary?

AFAIK, applying expanduser to a string that doesn't contain '~' will
just return the string itself.

>          if "/meta-selftest" in l and os.path.isdir(l):
>              testlayer = l
>              break
> -- 
> 2.1.4

Best wishes.
Mario
-- 
http://www.ossystems.com.br


  reply	other threads:[~2015-04-30 13:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 11:04 [PATCH] oeqa/utils: Allow ~ in bblayers Ed Bartosh
2015-04-30 13:08 ` Mario Domenech Goulart [this message]
2015-04-30 13:16   ` Gary Thomas
2015-04-30 13:30     ` Mario Domenech Goulart
2015-04-30 13:24   ` Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egn12286.fsf@email.parenteses.org \
    --to=mario@ossystems.com.br \
    --cc=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox