[daisy][PATCH 0/1] Backport BAD_RECOMMENDATIONS fix from master/dizzy

[daisy][PATCH 0/1] Backport BAD_RECOMMENDATIONS fix from master/dizzy

[Denys Dmytriyenko]

From: Denys Dmytriyenko <denys@ti.com>

This is a self-contained clean backport of BAD_RECOMMENDATIONS fix for opkg.
Please consider applying to daisy.

Paul Barker (1):
  package_manager: Fix BAD_RECOMMENDATIONS for opkg

 meta/lib/oe/package_manager.py | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.2.0

[daisy][PATCH 1/1] package_manager: Fix BAD_RECOMMENDATIONS for opkg

[Denys Dmytriyenko]

From: Paul Barker <paul@paulbarker.me.uk>

In package_manager.py, when using opkg as the packager, the command 'opkg <args>
info <pkg>' is called to get information about each pkg in BAD_RECOMMENDATIONS
in a format that can be written to the status file. The 'Status: ...' line is
modified and all other lines are passed through. Changing the verbosity level
argument for this command will change what it written into the status file.
Crucially, with the default verbosity level, no blank lines are being printed by
the opkg command and so no blank lines are being written to the status file to
separate each package entry.

The package parsing code in opkg expects package entries in the status file to
be separated by at least one blank line. If no blank line is seen, the next
package entry is interpreted as a continuation of the last package entry, but
the new values overwrite the old values.

So with the default verbosity level, a blank line follows some package entries
and these are parsed. The others are dropped due to the lack of blank lines. As
the verbosity increases, more debugging messages add blank lines and more
packages are parsed.

The solution to ensure that this works correctly regardless of the verbosity
level is simply add a blank line after the output of 'opkg info' is written to
the status file, ensuring that the next package is separated from the current
package.

[YOCTO #6816]

Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
Cc: Chris Carr <chris.carr@ge.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>

(From oe-core master rev: 3fa24eee41c26fecd5e4f680082288ec772d2de9)

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta/lib/oe/package_manager.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
index 1c33b0f..8e871a5 100644
--- a/meta/lib/oe/package_manager.py
+++ b/meta/lib/oe/package_manager.py
@@ -1381,6 +1381,10 @@ class OpkgPM(PackageManager):
                     else:
                         status.write(line + "\n")
 
+                # Append a blank line after each package entry to ensure that it
+                # is separated from the following entry
+                status.write("\n")
+
     '''
     The following function dummy installs pkgs and returns the log of output.
     '''
-- 
2.2.0

Re: [daisy][PATCH 0/1] Backport BAD_RECOMMENDATIONS fix from master/dizzy

[Denys Dmytriyenko]

I know Daisy is rather old, but is there any chance to get this fix pulled in? 
Or should I look for a local workaround instead? Thanks!

-- 
Denys


On Thu, Jun 11, 2015 at 03:07:54PM -0400, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@ti.com>
> 
> This is a self-contained clean backport of BAD_RECOMMENDATIONS fix for opkg.
> Please consider applying to daisy.
> 
> Paul Barker (1):
>   package_manager: Fix BAD_RECOMMENDATIONS for opkg
> 
>  meta/lib/oe/package_manager.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> -- 
> 2.2.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core