Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Brendan Le Foll <brendan.le.foll@intel.com>
To: Christopher Larson <clarson@kergoth.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] toolchain-shar-extract.sh: better default install path for extensible SDK
Date: Thu, 20 Aug 2015 08:34:11 +0100	[thread overview]
Message-ID: <20150820073410.GA18330@jupiter.iwi.intel.com> (raw)
In-Reply-To: <CABcZANnhYzCmt0yZHayQ4TxQMgQ1DPYwZRAXJMH-9sovCHY6mg@mail.gmail.com>

On Wed, Aug 19, 2015 at 06:52:49PM +0100, Christopher Larson wrote:
>    On Wed, Aug 19, 2015 at 6:32 AM, <[1]brendan.le.foll@intel.com> wrote:
> 
>    From: Brendan Le Foll <[2]brendan.le.foll@intel.com>
>    Extensible SDK cannot be installed as root so by default offer to
>    install it in
>    user's home directory under distro/distro_version replacing the normal
>    SDK
>    version '+' char with a '_' as that's a restricted character for
>    bitbake
>    Signed-off-by: Brendan Le Foll <[3]brendan.le.foll@intel.com>
> 
>    Why not use a metadata variable for the default, replacing with @@ as
>    with the other metadata variables, rather than hardcoding the default
>    in the .sh where it can't be easily overridden by the distro or user?

'~' seemed like a good option for all SDKs/distros seemed like a
decent 'default' to me and the rest is fairly customisable with
SDK_TITLE which has to be set anyways. Or do you mean a different var?

Thanks,
Brendan


  reply	other threads:[~2015-08-20  7:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 13:32 Extensible SDK install patch fixes brendan.le.foll
2015-08-19 13:32 ` [PATCH 1/3] toolchain-shar-extract.sh: ensure extensible SDK install path obeys restrictions brendan.le.foll
2015-08-19 13:32 ` [PATCH 2/3] toolchain-shar-extract.sh: better default install path for extensible SDK brendan.le.foll
2015-08-19 17:52   ` Christopher Larson
2015-08-20  7:34     ` Brendan Le Foll [this message]
2015-08-20 16:47       ` Christopher Larson
2015-08-19 13:32 ` [PATCH 3/3] toolchain-shar-extract.sh: explain why we cannot use sudo in " brendan.le.foll
2015-08-20 19:30   ` Randy Witt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150820073410.GA18330@jupiter.iwi.intel.com \
    --to=brendan.le.foll@intel.com \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox